Devicetree
 help / color / mirror / Atom feed
From: "Kumar, Udit" <u-kumar1@ti.com>
To: Kendall Willis <k-willis@ti.com>, Nishanth Menon <nm@ti.com>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: <s-kochidanadu@ti.com>, <a-kaur@ti.com>, <s-tripathi1@ti.com>,
	<vishalm@ti.com>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<u-kumar1@ti.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: ti: k3-am62p: use ti,am62-m_can compatible for m_can devices
Date: Fri, 4 Sep 2026 19:39:33 +0530	[thread overview]
Message-ID: <412fc9b3-cac5-4fff-8071-ca2d4855db30@ti.com> (raw)
In-Reply-To: <20260902-smth-v2-3-b3678ca44c7b@ti.com>

Hello Kendall,

On 9/3/2026 2:34 AM, Kendall Willis wrote:
> Prepend "ti,am62-m_can" to the m_can device compatible property since
> this compatible adds out-of-band wakeup functionality to the m_can devices.
> The m_can pins can be a wakeup source in the deepest low power states,
> despite being in the MCU domain which is OFF during deeper low power states
> since it has the out-of-band wakeup capability.
> 

Instead of adding new compatible,
what you think

1) if pinctrl_state_wakeup is set ("wakeup", prop in pin control)  then
treat this as out of band wakeup
2) if device itself enabled as wakeup device treat as in band wakeup source
> Signed-off-by: Kendall Willis <k-willis@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index 5288c959f3c1aecfde363f9e2440253545591171..d26d6b6d0cf46a19bde9f58769b3eb8c86c836ab 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> @@ -154,7 +154,7 @@ mcu_rti0: watchdog@4880000 {
>  	};
>  
>  	mcu_mcan0: can@4e08000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-m_can", "bosch,m_can";
>  		reg = <0x00 0x4e08000 0x00 0x200>,
>  		      <0x00 0x4e00000 0x00 0x8000>;
>  		reg-names = "m_can", "message_ram";
> @@ -169,7 +169,7 @@ mcu_mcan0: can@4e08000 {
>  	};
>  
>  	mcu_mcan1: can@4e18000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-m_can", "bosch,m_can";
>  		reg = <0x00 0x4e18000 0x00 0x200>,
>  		      <0x00 0x4e10000 0x00 0x8000>;
>  		reg-names = "m_can", "message_ram";
> 


  parent reply	other threads:[~2026-09-04 14:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 21:04 [PATCH v2 0/3] arm64: dts: ti: use ti,am62-m_can compatible for m_can devices Kendall Willis
2026-09-02 21:04 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-02 21:16   ` sashiko-bot
2026-09-02 21:04 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-02 21:16   ` sashiko-bot
2026-09-02 21:04 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-02 21:13   ` sashiko-bot
2026-09-04 14:09   ` Kumar, Udit [this message]
2026-09-04 14:59     ` Kendall Willis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412fc9b3-cac5-4fff-8071-ca2d4855db30@ti.com \
    --to=u-kumar1@ti.com \
    --cc=a-kaur@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k-willis@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=s-kochidanadu@ti.com \
    --cc=s-tripathi1@ti.com \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox