From: Kendall Willis <k-willis@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
<s-kochidanadu@ti.com>, <a-kaur@ti.com>, <s-tripathi1@ti.com>,
<vishalm@ti.com>, <linux-can@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: can: m_can: add ti,am62-m_can compatible
Date: Thu, 3 Sep 2026 15:00:41 -0500 [thread overview]
Message-ID: <20260903200041.uz4hguhoihvtsyza@uda0506412> (raw)
In-Reply-To: <20260903-swinging-carmine-oriole-75b35a@quoll>
Hi Krzysztof,
On 15:45-20260903, Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 04:03:27PM -0500, Kendall Willis wrote:
> > Add "ti,am62-m_can" to the list of compatible strings for the M_CAN
>
> Compatibles do not have underscores. Poor existing examples are not the
> example to follow.
>
I'll change it to "ti,am62-mcu-mcan" in the next revision.
> Also, no need to repeat the diff - we see that from the diff. Just say
> "Add foo bar, a baz-baz device, fully compatible or not compatible with
> Bosch because of this and that".
>
Noted.
Best,
Kendall
next prev parent reply other threads:[~2026-09-03 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 21:03 [PATCH v4 0/2] can: m_can: introduce ti,am62-m_can compatible for out-of-band wakeup Kendall Willis
2026-09-02 21:03 ` [PATCH v4 1/2] dt-bindings: can: m_can: add ti,am62-m_can compatible Kendall Willis
2026-09-03 8:28 ` Markus Schneider-Pargmann
2026-09-03 19:04 ` Kendall Willis
2026-09-03 13:45 ` Krzysztof Kozlowski
2026-09-03 20:00 ` Kendall Willis [this message]
2026-09-02 21:03 ` [PATCH v4 2/2] can: m_can: add ti,am62-m_can compatible with out-of-band wakeup support Kendall Willis
2026-09-03 8:55 ` Markus Schneider-Pargmann
2026-09-03 19:22 ` Kendall Willis
2026-09-03 13:46 ` Krzysztof Kozlowski
2026-09-03 21:47 ` Kendall Willis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903200041.uz4hguhoihvtsyza@uda0506412 \
--to=k-willis@ti.com \
--cc=a-kaur@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=msp@baylibre.com \
--cc=rcsekar@samsung.com \
--cc=robh@kernel.org \
--cc=s-kochidanadu@ti.com \
--cc=s-tripathi1@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox