Devicetree
 help / color / mirror / Atom feed
From: Kendall Willis <k-willis@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	<s-kochidanadu@ti.com>, <a-kaur@ti.com>, <s-tripathi1@ti.com>,
	<vishalm@ti.com>, <linux-can@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] can: m_can: add ti,am62-m_can compatible with out-of-band wakeup support
Date: Thu, 3 Sep 2026 16:47:38 -0500	[thread overview]
Message-ID: <20260903214738.utkkjnyjdpnug6hu@uda0506412> (raw)
In-Reply-To: <20260903-crystal-wrasse-of-trust-a9dbc3@quoll>

Hi Krzysztof,
On 15:46-20260903, Krzysztof Kozlowski wrote:
> On Wed, Sep 02, 2026 at 04:03:28PM -0500, Kendall Willis wrote:
> > +struct m_can_pdata {
> > +	bool out_band_wakeup;
> > +};
> > +
> >  struct m_can_classdev *m_can_class_allocate_dev(struct device *dev, int sizeof_priv);
> >  void m_can_class_free_dev(struct net_device *net);
> >  int m_can_class_register(struct m_can_classdev *cdev);
> > diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> > index 56da411878af0185ff9cc512e325137428a68255..ae2d89b65fe8da65b1ca73cbf80cd8ee8483e2e8 100644
> > --- a/drivers/net/can/m_can/m_can_platform.c
> > +++ b/drivers/net/can/m_can/m_can_platform.c
> > @@ -218,8 +218,13 @@ static const struct dev_pm_ops m_can_pmops = {
> >  	SET_SYSTEM_SLEEP_PM_OPS(m_can_suspend, m_can_resume)
> >  };
> >  
> > +static const struct m_can_pdata m_can_plat_am62 = {
> > +	.out_band_wakeup = true,
> > +};
> > +
> >  static const struct of_device_id m_can_of_table[] = {
> >  	{ .compatible = "bosch,m_can", .data = NULL },
> > +	{ .compatible = "ti,am62-m_can", .data = &m_can_plat_am62 },
> 
> How exactly having out of band wakeup makes this device INCOMPATIBLE
> with Bosch (in terms of DT compatibility)?
> 

It does not make it incompatible with Bosch. The DT binding is
incorrect for having it be compatible with both TI and Bosch. I'm
correcting it on the next revision.

Best,
Kendall

      reply	other threads:[~2026-09-03 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 21:03 [PATCH v4 0/2] can: m_can: introduce ti,am62-m_can compatible for out-of-band wakeup Kendall Willis
2026-09-02 21:03 ` [PATCH v4 1/2] dt-bindings: can: m_can: add ti,am62-m_can compatible Kendall Willis
2026-09-03  8:28   ` Markus Schneider-Pargmann
2026-09-03 19:04     ` Kendall Willis
2026-09-03 13:45   ` Krzysztof Kozlowski
2026-09-03 20:00     ` Kendall Willis
2026-09-02 21:03 ` [PATCH v4 2/2] can: m_can: add ti,am62-m_can compatible with out-of-band wakeup support Kendall Willis
2026-09-03  8:55   ` Markus Schneider-Pargmann
2026-09-03 19:22     ` Kendall Willis
2026-09-03 13:46   ` Krzysztof Kozlowski
2026-09-03 21:47     ` Kendall Willis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903214738.utkkjnyjdpnug6hu@uda0506412 \
    --to=k-willis@ti.com \
    --cc=a-kaur@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=msp@baylibre.com \
    --cc=rcsekar@samsung.com \
    --cc=robh@kernel.org \
    --cc=s-kochidanadu@ti.com \
    --cc=s-tripathi1@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox