Re: [PATCH net-next 6/9] net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Deprecation warning causes kernel log spam on every link-up event
--

commit e45fa290281055cacebbbfec0d13fc25cf76f918
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes

The qcom-ethqos driver is moving towards using "rgmii-id" together
with PHY-provided delays. This commit warns when legacy PHY modes
are used to encourage users to migrate to updated DTBs.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> index 67738c1598c50..2ca2f03de3017 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> @@ -554,6 +554,8 @@ static void ethqos_fix_mac_speed_rgmii(void *bsp_priv,
>  		return;
>  	}
>  
> +	dev_warn(dev, "legacy RGMII phy-mode detected; consider upgrading to a newer DTB\n");

[Severity: Medium]
Is it possible for this warning to cause kernel log spam on every link-up
event?

This statement evaluates every time the link transitions to up, since
stmmac_mac_link_up() calls the priv->plat->fix_mac_speed() callback. If the
Ethernet link flaps, auto-negotiates repeatedly, or is reconnected
frequently, this could flood the kernel log.

Since the phy_mode is evaluated from a static device tree property, would
it be better to use dev_warn_once() here, or move the warning to the
probe path entirely?

> +
>  	/* Initialize the DLL first */
>  
>  	/* Set DLL_RST */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com?part=6