[PATCH] ARM: dts: BCM5301X: AC56U: add nvram node

[PATCH] ARM: dts: BCM5301X: AC56U: add nvram node

[Rosen Penev]

Add it and set for gmac0, which is the only GMAC used on this board.

nvram size found from a random bootlog online.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 .../boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts    | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
index c80ac16ad949..550cc67f5ba6 100644
--- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
+++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
@@ -25,6 +25,15 @@ memory@0 {
 		      <0x88000000 0x08000000>;
 	};
 
+	nvram@1c080000 {
+		compatible = "brcm,nvram";
+		reg = <0x1c080000 0x180000>;
+
+		et0macaddr: et0macaddr {
+			#nvmem-cell-cells = <1>;
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -92,3 +101,8 @@ button-wps {
 &usb3_phy {
 	status = "okay";
 };
+
+gmac0 {
+	nvmem-cells = <&et0macaddr 0>;
+	nvmem-cell-names = "mac-address";
+};
-- 
2.55.0

Re: [PATCH] ARM: dts: BCM5301X: AC56U: add nvram node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `gmac0` node override at the top level of the DTS file is missing the `&` ampersand prefix, causing a syntax error and build failure.
--

commit b3e9863f98ae6b1a8bec5d68e2e1b2a375393644
Author: Rosen Penev <rosenp@gmail.com>

ARM: dts: BCM5301X: AC56U: add nvram node

This patch adds an nvram node to the AC56U device tree based on bootlog
sizes. It also sets up the nvmem cells for the gmac0 node to supply its
mac address.

> diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> index c80ac16ad9496..550cc67f5ba6c 100644
> --- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts

[ ... ]

> @@ -92,3 +101,8 @@ button-wps {
>  &usb3_phy {
>  	status = "okay";
>  };
> +
> +gmac0 {

[Severity: Low]
Is this missing an ampersand prefix? Overriding an existing node from the top
level of the device tree requires an ampersand like &gmac0, otherwise this
will cause a syntax error in the Device Tree Compiler and break the build.

> +	nvmem-cells = <&et0macaddr 0>;
> +	nvmem-cell-names = "mac-address";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907194032.20042-1-rosenp@gmail.com?part=1