Re: [PATCH 5/5] arm64: dts: st: add TAMP backup register in stm32mp251.dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] DT Schema Violation: additionalProperties not allowed in syscon node
- [Low] Undocumented DT Binding: st,stm32mp25-tamp-nvram
--

commit d9b7574bfcac6134021b52991b2d481d5704a393
Author: Simeon Marijon <simeon.marijon@foss.st.com>

arm64: dts: st: add TAMP backup register in stm32mp251.dtsi
    
TAMP backup registers allow information sharing between different
software components/execution levels. They are described individually
as nvmem cells.

> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 9c63fdb5a885a..aa7ae8b6fd21c 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -2118,6 +2118,36 @@ rtc: rtc@46000000 {
>  			status = "disabled";
>  		};
>  
> +		tamp: tamp@46010000 {
> +			compatible = "st,stm32-tamp", "syscon", "simple-mfd";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			reg = <0x46010000 0x400>;
> +			ranges;
> +
> +			nvram: nvram@46010100 {

[Severity: Low]
Does this configuration trigger warnings during dtbs_check?

The parent schema Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
(which binds to st,stm32-tamp) strictly enforces additionalProperties: false
without defining #address-cells, #size-cells, ranges, or any child nodes.

> +				compatible = "st,stm32mp25-tamp-nvram";

[Severity: Low]
Is this compatible string missing its corresponding YAML binding document?

All new DT hardware bindings must be documented to avoid schema validation
warnings during dtbs_check.

> +				reg = <0x46010100 0x200>;
> +				nvmem-layout {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-upstream_tamp_nvram_dts_part-v1-0-e2bca58a65f4@foss.st.com?part=5