From: sashiko-bot@kernel.org
To: "Patrice Chotard" <patrice.chotard@foss.st.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/5] ARM: dts: stm32: add TAMP backup register in stm32mp131.dtsi
Date: Thu, 10 Sep 2026 15:29:35 +0000 [thread overview]
Message-ID: <20260910152936.59E461F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910-upstream_tamp_nvram_dts_part-v1-1-e2bca58a65f4@foss.st.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding child nodes and properties to a syscon node that has `additionalProperties: false` in its schema causes immediate validation failure.
--
commit fd4960b03c2c4e269bdd41d3965ee803d12b57df
Author: Simeon Marijon <simeon.marijon@foss.st.com>
ARM: dts: stm32: add TAMP backup register in stm32mp131.dtsi
This commit adds TAMP backup registers as nvmem cells in the stm32mp131
device tree to allow information sharing between different software
components.
> diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
> index 83ae59b73dd09..b37c22b1379cc 100644
> --- a/arch/arm/boot/dts/st/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
> @@ -1918,5 +1918,39 @@ gpioi: gpio@5000a000 {
[ ... ]
> +
> + tamp: tamp@5c00a000 {
> + compatible = "st,stm32-tamp", "syscon", "simple-mfd";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x5c00a000 0x400>;
> + ranges;
> +
> + nvram: nvram@5c00a100 {
[Severity: Low]
Will this introduce a schema validation regression when running make
dtbs_check?
The matching schema in
Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml dictates
additionalProperties: false and does not define #address-cells, #size-cells,
ranges, or child nodes like nvram.
Does the schema need to be updated to support these new properties, or
should they be structured differently?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-upstream_tamp_nvram_dts_part-v1-0-e2bca58a65f4@foss.st.com?part=1
next prev parent reply other threads:[~2026-09-10 15:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 15:14 [PATCH 0/5] Add STM32 TAMP nvram support Patrice Chotard
2026-09-10 15:14 ` [PATCH 1/5] ARM: dts: stm32: add TAMP backup register in stm32mp131.dtsi Patrice Chotard
2026-09-10 15:29 ` sashiko-bot [this message]
2026-09-11 8:17 ` Patrice CHOTARD
2026-09-10 15:14 ` [PATCH 2/5] ARM: dts: stm32: add TAMP backup register in stm32mp151.dtsi Patrice Chotard
2026-09-10 15:26 ` sashiko-bot
2026-09-11 8:18 ` Patrice CHOTARD
2026-09-10 15:14 ` [PATCH 3/5] arm64: dts: st: add TAMP backup register in stm32mp211.dtsi Patrice Chotard
2026-09-10 15:14 ` [PATCH 4/5] arm64: dts: st: add TAMP backup register in stm32mp231.dtsi Patrice Chotard
2026-09-10 15:14 ` [PATCH 5/5] arm64: dts: st: add TAMP backup register in stm32mp251.dtsi Patrice Chotard
2026-09-10 15:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910152936.59E461F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=patrice.chotard@foss.st.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox