Re: [PATCH v6 4/4] arm64: dts: qcom: Add PMIC thermal support for Shikra IQ2390S SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The pinctrl configuration for the PMIC ADC incorrectly sets up PMIC GPIO2 and GPIO3 for analog input, but the configured ADC channels are actually mapped to read from PMIC GPIO1 and GPIO4.
--

commit 16888acda3cf4c853fe7f5fde0d880b0e2116d1a
Author: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

arm64: dts: qcom: Add PMIC thermal support for Shikra IQ2390S SoM platform

This commit adds ADC channels for system thermistors which are used for
thermal mitigation. It also adds ADC_TM nodes for pa/quiet/msm thermistors
along with their thermal zones.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> index e119ace54e588..a6769364c1921 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
[ ... ]
> @@ -76,7 +115,81 @@ vreg_pmu_ch1: ldo4 {
>  	};
>  };
>  
> +&pm8150_adc {
> +	pinctrl-0 = <&pm8150_adc_gpio2_default>, <&pm8150_adc_gpio3_default>;
> +	pinctrl-names = "default";

[Severity: High]
Does this incorrectly assign the pinctrl states for GPIO2 and GPIO3,
rather than GPIO1 and GPIO4?

As seen in the channels defined below, the gnss_therm and pa_therm are
mapped to read from ADC5_GPIO1_100K_PU and ADC5_GPIO4_100K_PU.

> +
> +	channel@4d {
> +		reg = <ADC5_AMUX_THM1_100K_PU>;
> +		label = "msm_therm";
> +		qcom,ratiometric;
> +		qcom,hw-settle-time = <200>;
> +		qcom,pre-scaling = <1 1>;
> +	};
> +
> +	channel@4e {
> +		reg = <ADC5_AMUX_THM2_100K_PU>;
> +		label = "quiet_therm";
> +		qcom,ratiometric;
> +		qcom,hw-settle-time = <200>;
> +		qcom,pre-scaling = <1 1>;
> +	};
> +
> +	channel@52 {
> +		reg = <ADC5_GPIO1_100K_PU>;
> +		label = "gnss_therm";
> +		qcom,ratiometric;
> +		qcom,hw-settle-time = <200>;
> +		qcom,pre-scaling = <1 1>;
> +	};
> +
> +	channel@55 {
> +		reg = <ADC5_GPIO4_100K_PU>;
> +		label = "pa_therm";
> +		qcom,ratiometric;
> +		qcom,hw-settle-time = <200>;
> +		qcom,pre-scaling = <1 1>;
> +	};
> +};
[ ... ]
>  &pm8150_gpios {
> +	pm8150_adc_gpio2_default: pm8150-adc-gpio2-state {
> +		pins = "gpio2";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		bias-high-impedance;
> +	};
> +
> +	pm8150_adc_gpio3_default: pm8150-adc-gpio3-state {
> +		pins = "gpio3";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		bias-high-impedance;
> +	};

[Severity: High]
Should these pinctrl states configure GPIO1 and GPIO4 instead?

Without high-impedance configuration on GPIO1 and GPIO4, their default
digital states or internal biases might interfere with the analog thermistor
voltage. This can result in incorrect temperature readings, potentially
causing the system to either overheat or spuriously shut down.

> +
>  	vol_up_n: vol-up-n-state {
>  		pins = "gpio6";
>  		function = PMIC_GPIO_FUNC_NORMAL;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-shikra_adc_support-v6-0-e4b2da5cd55c@oss.qualcomm.com?part=4