Re: [PATCH 1/6] dt-bindings: media: Add bindings for qcom,nord-camss

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: media: Artificial limit of 5 CSI input ports in regex
--

commit ba64c074737d8584213f4eaf83a7f188c30698a0
Author: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>

dt-bindings: media: Add bindings for qcom,nord-camss

This commit adds bindings for the camera subsystem (CAMSS) on the Qualcomm
Nord platform. The hardware introduces a significant number of blocks,
including 3 CSID and 10 CSID Lite receivers.

> diff --git a/Documentation/devicetree/bindings/media/qcom,nord-camss.yaml b/Documentation/devicetree/bindings/media/qcom,nord-camss.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,nord-camss.yaml

[ ... ]

> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    description:
> +      CSI input ports.
> +
> +    patternProperties:
> +      "^port@[0-4]$":

[Severity: Medium]
Does this regex artificially limit the allowed CSI input ports?

The commit message notes that the Nord CAMSS hardware exposes 13 CSID
receivers (3 CSID and 10 CSID Lite). However, restricting the ports block to
"^port@[0-4]$" limits the allowed ports to 5, preventing configuration of the
remaining 8 hardware receivers.

If a device tree attempts to map external PHYs to CSID ports 5 through 12,
won't it fail schema validation and drop the nodes from the parsed
configuration?

> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +
> +        description:
> +          Input port for receiving CSI data.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-nord-v1-0-20db41a7f1ff@oss.qualcomm.com?part=1