Re: [PATCH net-next 3/4] dt-bindings: net: allwinner,sun8i-a83t-emac: Add Allwinner H616 EMAC1 and syscon index

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing mdio-mux conditional for h616-internal-emac
--

commit 32bf9c78551205e690dd92ce3a439bc48e70a630
Author: Alastair D'Silva <alastair@d-silva.org>

dt-bindings: net: allwinner,sun8i-a83t-emac: Add Allwinner H616 EMAC1 and syscon index

The commit documents the Allwinner H616 EMAC1 and internal EMAC compatible
strings. It also updates the syscon property schema to support an optional
register index offset argument.

> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> index 323a669fa9823..cd1075dab5810 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> @@ -39,6 +39,8 @@ properties:
>                - allwinner,sun50i-a100-emac
>                - allwinner,sun50i-h6-emac
>                - allwinner,sun50i-h616-emac0
> +              - allwinner,sun50i-h616-emac1
> +              - allwinner,sun50i-h616-internal-emac

[Severity: Low]
Does the newly added allwinner,sun50i-h616-internal-emac variant need to be
included in the conditional block for mdio-mux?

Looking at the schema file, there is a conditional block that permits the
mdio-mux property for internal PHYs:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - allwinner,sun8i-h3-emac
              - allwinner,sun8i-v3s-emac
    then:
      properties:
        ...
        mdio-mux:
          type: object
          unevaluatedProperties: false

Since allwinner,sun50i-h616-internal-emac is not in this enum, valid device
trees using this new compatible string with an mdio-mux node will fail
schema validation.

The driver itself requires the mdio-mux node to avoid an -ENODEV error
during probe, so it seems the property is needed, but the schema will
reject it due to unevaluatedProperties: false at the root level.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916044119.475666-1-alastair@d-silva.org?part=3