Re: [PATCH net-next 1/4] dt-bindings: net: phy: Add Allwinner AC300 EPHY binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: net: phy: conflicting duplicate schema for AC300 EPHY
- [Low] dt-bindings: net: phy: schema validation failure on 3-item compatible
--

commit 78619c40b1c730a8fe995945c43fe97d336ddfb6
Author: Alastair D'Silva <alastair@d-silva.org>

dt-bindings: net: phy: Add Allwinner AC300 EPHY binding

Add device tree binding documentation for the Allwinner AC300
Fast Ethernet Physical Layer (EPHY) co-packaged on Allwinner
H616 and H618 SoCs.

> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun50i-h618-ac300-ephy.yaml b/Documentation/devicetree/bindings/net/allwinner,sun50i-h618-ac300-ephy.yaml
> new file mode 100644
> index 0000000000000..a04416e781382
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun50i-h618-ac300-ephy.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/allwinner,sun50i-h618-ac300-ephy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner AC300 Ethernet PHY

[Severity: Medium]
Will this binding conflict with the existing x-powers,acx00-ephy-package.yaml?

The AC300 hardware appears to already be modeled by the ethernet-phy-package
architecture, which represents its split-address control architecture (where
control registers sit at base + 16). 

Introducing a standalone flattened binding seems to attach package-level
properties directly to the link PHY, potentially fragmenting the device tree
ABI. This could force drivers to hardcode a + 16 MDIO offset instead of
relying on the standard package architecture.

> +
> +maintainers:
> +  - Alastair D'Silva <alastair@d-silva.org>

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - const: ethernet-phy-id0044.1400
> +      - const: allwinner,sun50i-h618-ac300-ephy
> +      - const: ethernet-phy-ieee802.3-c22

[Severity: Low]
Will this compatible string array fail dt_binding_check validation?

The included core ethernet-phy.yaml enforces a oneOf constraint that restricts
compatible arrays to a maximum of two elements (such as PHY ID and IEEE
clause). This block defines a 3-element array, which appears structurally
invalid under the included constraints.

> +
> +  reg:
> +    maxItems: 1

[ ... ]

> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy@0 {
> +            compatible = "ethernet-phy-id0044.1400",
> +                         "allwinner,sun50i-h618-ac300-ephy",
> +                         "ethernet-phy-ieee802.3-c22";

[Severity: Low]
Will this example node fail validation?

This example demonstrates the 3-item list, which will violate the two-element
restriction inherited from the base ethernet-phy.yaml schema.

> +            reg = <0>;
> +            clocks = <&ccu 81>, <&ac300_pwm_clk>;
> +            clock-names = "ephy", "pwm";
> +            nvmem-cells = <&ephy_calibration>;
> +            nvmem-cell-names = "calibration";
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916044119.475666-1-alastair@d-silva.org?part=1