Re: [PATCH v7 06/11] iio: dac: mcp47feb02: Avoid unjustified probe error on missing label

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] iio: dac: mcp47feb02: dev_warn_probe() spams on valid missing optional label
--

commit e0f4987920f8a3564ad483dd9c2d2cc4904bdc2f
Author: Ariana Lazar <ariana.lazar@microchip.com>

iio: dac: mcp47feb02: Avoid unjustified probe error on missing label

This commit avoids a probe failure when the optional 'label' property is
missing by replacing dev_err_probe() with dev_warn_probe(). It also
returns -ENOENT in the read_label sysfs callback when attempting to read a
missing label.

Closes: https://lore.kernel.org/all/20260804134616.1D8A21F00A3E@smtp.kernel.org/

> diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c
> index 9d4ba95da84ac..43cf69e43a41e 100644
> --- a/drivers/iio/dac/mcp47feb02.c
> +++ b/drivers/iio/dac/mcp47feb02.c
[ ... ]
> @@ -976,8 +979,7 @@ static int mcp47feb02_parse_fw(struct iio_dev *indio_dev,
>  
>  		ret = fwnode_property_read_string(child, "label", &data->labels[reg]);
>  		if (ret)
> -			return dev_err_probe(dev, ret, "%pfw: invalid label\n",
> -					     fwnode_get_name(child));
> +			dev_warn_probe(dev, ret, "%pfw: invalid label\n", child);

[Severity: Medium]
Since the label is an optional property, fwnode_property_read_string()
returning a non-zero value is a valid and expected condition when the
property is omitted. 

Does this unconditional dev_warn_probe() cause unnecessary warning spam in
the kernel boot log for valid configurations that don't specify a label?

>  
>  		chanspec.address = reg;
>  		chanspec.channel = reg;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-mcp47feb02_refactor-v7-0-82ca794eafe2@microchip.com?part=6