Re: [PATCH 02/11] dt-bindings: display: panel: samsung,s6e3ha8: Add AMB630QY01 panel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: commit message omits deprecation and new compatible string
--

commit 1def073e2834624beafbcc0f1b404f941e99bc1b
Author: David Heidelberg <david@ixit.cz>

dt-bindings: display: panel: samsung,s6e3ha8: Add AMB630QY01 panel

This commit adds device tree binding support for the AMB630QY01 6.3" flexible
AMOLED panel used in the Google Pixel 3 XL.

> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
> --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml

[ ... ]

> @@ -38,12 +60,17 @@ properties:
>    compatible:
>      oneOf:
> -      - const: samsung,s6e3ha8-amb577px01
> +      - enum:
> +          - samsung,s6e3ha8-amb577px01

[Severity: Low]
This isn't a bug, but does this introduce a new compatible string that is
completely undocumented in the commit message? The commit log solely claims to
add support for the AMB630QY01 panel, leaving this change unexplained.

> +          - samsung,s6e3ha8-amb630qy01
>        - const: samsung,s6e3ha8
>          deprecated: true

[Severity: Low]
This isn't a bug, but could the commit message be updated to explain the
deprecation of the original generic compatible string? The change implicitly
deprecates the generic samsung,s6e3ha8 string without explanation in the
commit log.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-crosshatch-panel-v1-0-de6e9512da96@ixit.cz?part=2