Re: [PATCH v7 02/10] ASoC: qcom: Add QAIF shared data structures and variant interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: undeclared AIF DAI identifiers cause build breakage
--

commit 7db49396552f308adb4bd0b64f488c2ce96b394b
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: qcom: Add QAIF shared data structures and variant interface

This commit introduces qaif.h to hold common definitions shared by the
QAIF CPU DAI and PCM platform drivers. It adds driver data structures,
AIF and CIF register-field descriptions, IRQ mapping helpers, and the
SoC variant descriptor.

> diff --git a/sound/soc/qcom/qaif.h b/sound/soc/qcom/qaif.h
> new file mode 100644
> index 0000000000000..ba02784771a25
> --- /dev/null
> +++ b/sound/soc/qcom/qaif.h
[ ... ]
> +static inline bool qaif_is_aif_mi2s_port(unsigned int dai_id)
> +{
> +	return (dai_id >= AIF_MI2S_RX_0 && dai_id <= AIF_MI2S_RX_12) ||
> +	       (dai_id >= AIF_MI2S_TX_0 && dai_id <= AIF_MI2S_TX_12);
> +}

[Severity: Low]
Are the AIF_MI2S_RX_0 and AIF_MI2S_TX_0 identifiers declared elsewhere in
this series? Because they are referenced inside a static inline function in
a header file, any source file including qaif.h will fail to compile with
an undeclared identifier error if these aren't already defined.

> +
> +static inline bool qaif_is_aif_tdm_port(unsigned int dai_id)
> +{
> +	return (dai_id >= AIF_TDM_RX_0 && dai_id <= AIF_TDM_RX_12) ||
> +	       (dai_id >= AIF_TDM_TX_0 && dai_id <= AIF_TDM_TX_12);
> +}

[Severity: Low]
Similarly, does this code rely on AIF_TDM_RX_0 and AIF_TDM_TX_0 being
defined prior to inclusion? This will cause immediate build failures for
consumers of this header that do not have those definitions.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-b4-qaif-shikra-audio-v7-0-d5b6f056568e@oss.qualcomm.com?part=2