Re: [PATCH v7 09/10] ASoC: qcom: Add Shikra QAIF support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Logic error in shikra_qaif_get_dma_idx due to contiguous DAI ID assumption
- [Low] Build failure due to undefined AIF_* constants
--

commit 8d479b4be68dbcc2201e8313200c13e70d03bca1
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: qcom: Add Shikra QAIF support

Add the Shikra variant data for the Qualcomm Audio Interface driver so
the common QAIF code can bind to the Shikra QAIF device and expose the
SoC-specific DAIs. This commit provides the Shikra DMA-to-DAI mappings,
layout, clock names, DAI driver data, and PM hooks required by QAIF.

> diff --git a/sound/soc/qcom/qaif-shikra.c b/sound/soc/qcom/qaif-shikra.c
> new file mode 100644
> index 0000000000000..0d5c2baade28f
> --- /dev/null
> +++ b/sound/soc/qcom/qaif-shikra.c
> @@ -0,0 +1,447 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + *
> + * qaif-shikra.c -- ALSA SoC CPU-Platform DAI driver for QTi QAIF
> + */
> +
> +#include <linux/module.h>
> +#include <linux/pm.h>
> +#include <sound/pcm.h>
> +#include <sound/soc.h>
> +#include "qaif.h"
> +
> +static const struct qaif_dmaidx_dai_map shikra_mi2s_dma_dai_map[] = {
> +	{ AIF_MI2S_RX_0, QAIF_DMA_IDX0 },

[Severity: Low]
Are the AIF_MI2S_RX_0, AIF_TDM_RX_0, and similar constants defined anywhere
in the kernel tree?

It appears their definitions might be missing, which could cause an immediate
compilation failure when building this newly added file.

[ ... ]

> +static int shikra_qaif_get_dma_idx(unsigned int dai_id)
> +{
> +	const struct qaif_dmaidx_dai_map *map;
> +	int i, size;
> +
> +	if (dai_id >= AIF_MI2S_RX_0 && dai_id <= AIF_MI2S_TX_12) {

[Severity: Medium]
Could this condition incorrectly classify non-MI2S ports if they fall
between the RX and TX ranges?

This logic assumes that AIF_MI2S_RX_0 through AIF_MI2S_TX_12 form a
contiguous block of IDs. However, in the shared header,
qaif_is_aif_mi2s_port() treats the RX and TX ranges as distinct:

sound/soc/qcom/qaif.h:qaif_is_aif_mi2s_port() {
    ...
    return (dai_id >= AIF_MI2S_RX_0 && dai_id <= AIF_MI2S_RX_12) ||
           (dai_id >= AIF_MI2S_TX_0 && dai_id <= AIF_MI2S_TX_12);
}

If the underlying enum places other IDs (such as TDM ports) in between
the MI2S RX and TX ranges, this function could misclassify them as MI2S
ports, fail to find them in shikra_mi2s_dma_dai_map, and return -EINVAL.

> +		map = shikra_mi2s_dma_dai_map;
> +		size = ARRAY_SIZE(shikra_mi2s_dma_dai_map);
> +	} else if (dai_id >= AIF_TDM_RX_0 && dai_id <= AIF_TDM_TX_12) {
> +		map = shikra_tdm_dma_dai_map;
> +		size = ARRAY_SIZE(shikra_tdm_dma_dai_map);
> +	} else {
> +		map = shikra_cif_dma_dai_map;
> +		size = ARRAY_SIZE(shikra_cif_dma_dai_map);
> +	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923-b4-qaif-shikra-audio-v7-0-d5b6f056568e@oss.qualcomm.com?part=9