Re: [PATCH v10 04/19] dmaengine: ti: k3-udma: move static inline helper functions to header file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dmaengine: missing <linux/io.h> include in k3-udma.h
--

commit 5bd09b8edabbd7745c849b6097d830d3dac4a91b
Author: Sai Sree Kartheek Adivi <s-adivi@ti.com>

dmaengine: ti: k3-udma: move static inline helper functions to header file

This commit moves static inline helper functions from k3-udma.c to the
k3-udma.h header file to improve separation and reuse.

> diff --git a/drivers/dma/ti/k3-udma.h b/drivers/dma/ti/k3-udma.h
> index 11d08adb0d69f..54e1757c3de38 100644
> --- a/drivers/dma/ti/k3-udma.h
> +++ b/drivers/dma/ti/k3-udma.h
> @@ -451,6 +451,115 @@ struct udma_chan {

[ ... ]

> +/* Generic register access functions */
> +static inline u32 udma_read(void __iomem *base, int reg)
> +{
> +	return readl(base + reg);
> +}
> +
> +static inline void udma_write(void __iomem *base, int reg, u32 val)
> +{
> +	writel(val, base + reg);
> +}

[Severity: Low]
Should drivers/dma/ti/k3-udma.h explicitly include <linux/io.h>?

It uses readl() and writel() here in udma_read() and udma_write(), which are
defined in <linux/io.h>, but the header does not explicitly include it. This
can lead to build failures if the header is included in source files that do
not indirectly provide <linux/io.h>.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928025749.1055383-1-s-adivi@ti.com?part=4