Re: [PATCH v10 18/19] dmaengine: ti: k3-udma-v2: Update glue layer to support PKTDMA V2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dmaengine: ti: k3-udma-glue: RX channel incorrectly filters requested metadata
--

commit b3e94e1224d88a6c81029a4dc336d837a68ff7a7
Author: Sai Sree Kartheek Adivi <s-adivi@ti.com>

    dmaengine: ti: k3-udma-v2: Update glue layer to support PKTDMA V2
    
    Update glue layer to support PKTDMA V2 for non DMAengine users. The updates
    include handling absence of TISCI, direct IRQs, and autopairing.

> diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c
> index 996c130b10f4a..309a74a0b2a67 100644
> --- a/drivers/dma/ti/k3-udma-glue.c
> +++ b/drivers/dma/ti/k3-udma-glue.c

[ ... ]

> @@ -725,11 +770,24 @@ static int k3_udma_glue_cfg_rx_chn(struct k3_udma_glue_rx_channel *rx_chn)
>  	req.rx_chan_type = TI_SCI_RM_UDMAP_CHAN_TYPE_PKT_PBRR;
>  	req.rx_atype = rx_chn->common.atype_asel;
>  
> +	if (!tisci_rm->tisci) {
> +		u32 val = 0;
> +
> +		if (rx_chn->common.epib)
> +			val |= UDMA_CHAN_CFG_FILT_EINFO;
> +		if (rx_chn->common.psdata_size)
> +			val |= UDMA_CHAN_CFG_FILT_PSWORDS;

[Severity: High]
Does this logic invert the requested configuration? The epib and psdata_size
fields indicate that the user wants to receive this metadata. However,
setting the FILT bits configures the hardware to drop this data, which seems
to contradict the requested channel configuration. Could this be a copy-paste
error from the TX channel configuration?

> +
> +		xudma_rchanrt_write(rx_chn->udma_rchanx, UDMA_CHAN_RT_CFG_REG, val);
> +
> +		return 0;
> +	}
> +
> +	req.nav_id = tisci_rm->tisci_dev_id;
>  	ret = tisci_rm->tisci_udmap_ops->rx_ch_cfg(tisci_rm->tisci, &req);
>  	if (ret)
>  		dev_err(rx_chn->common.dev, "rchan%d cfg failed %d\n",
> -			rx_chn->udma_rchan_id, ret);
> -
> +				rx_chn->udma_rchan_id, ret);
>  	return ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928025749.1055383-1-s-adivi@ti.com?part=18