Re: [PATCH v2 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: lm3643: informational logging during probe violates subsystem guidelines
--

commit 526bd68dbe5899ef1f96b678f6b5d764ba338f79
Author: Ruslan Koreev <koreev.r@gmail.com>

leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes

This commit adds a DMI table to describe the LM3643 LED setup on Lenovo
ThinkPads that lack proper firmware descriptions (no _DSD). It provides
a software node configuration to drive the Windows Hello IR flood
illuminator.

> diff --git a/drivers/leds/flash/leds-lm3643.c b/drivers/leds/flash/leds-lm3643.c
> index bbe9358c9caaf..1c0de38ebcdf4 100644
> --- a/drivers/leds/flash/leds-lm3643.c
> +++ b/drivers/leds/flash/leds-lm3643.c
[ ... ]
> @@ -690,6 +691,92 @@ static int lm3643_register_led(struct device *dev, struct lm3643 *chip,
[ ... ]
> +static int lm3643_add_dmi_leds(struct device *dev)
> +{
[ ... ]
> +	ret = software_node_register_node_group(nodes);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to register the LED description\n");
> +
> +	set_secondary_fwnode(dev, software_node_fwnode(nodes[0]));
> +	dev_info(dev, "no LED nodes in firmware, using the DMI description\n");

[Severity: Low]
Does this informational log message violate the LED subsystem guidelines?

The subsystem rules strictly mandate: "Only log errors or warnings." Since this
call to dev_info() executes automatically in lm3643_add_dmi_leds() during
hardware enumeration on matching laptops, it will add unnecessary minor log
noise during boot.

> +
> +	return devm_add_action_or_reset(dev, lm3643_remove_dmi_leds, dev);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928094302.86966-1-rillian.grant@gmail.com?part=3