Re: [PATCH v2 1/4] dt-bindings: leds: Document TI LM3643 dual LED flash driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Sep 28, 2026 at 10:42:34AM +0100, Rillian Grant wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - ti,lm3643
> +
> +  reg:
> +    maxItems: 1
> +

Missing supply, enable-gpios.

> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[0-1]$":
> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        description: Index of the LED.
> +        minimum: 0

Drop, that's alerady minimum.

> +        maximum: 1
> +
> +      led-sources:
> +        minItems: 1
> +        maxItems: 2
> +        items:
> +          minimum: 0

As well

> +          maximum: 1
> +
> +      flash-max-microamp:
> +        description: |
> +          Maximum flash current through this LED. Each high-side current source
> +          can provide up to 1.5A. The maximum current the boost can deliver is
> +          1.5A across both sources.
> +
> +          Valid values for an LED connected to one source:
> +            10900 - 1500000, step by 11725 (rounded down)
> +          Valid values for an LED connected to both sources:
> +            21800 - 1500000, step by 23450 (rounded down)
> +
> +        minimum: 10900
> +        maximum: 1500000
> +
> +      led-max-microamp:
> +        description: |
> +          Maximum torch current through this LED. In torch mode each high-side
> +          current source can provide up to 179mA.
> +
> +          Valid values for an LED connected to one source:
> +            977 - 179000, step by 1400 (rounded down)
> +          Valid values for an LED connected to both sources:
> +            1954 - 358000, step by 2800 (rounded down)
> +
> +        minimum: 977
> +        maximum: 358000
> +
> +      flash-max-timeout-us:
> +        description: |

Drop |

> +          The chip supports timeouts from 10ms to 100ms in increments of 10ms
> +          and from 100ms to 400ms in increments of 50ms. The provided value
> +          will be rounded down to a supported value.
> +

Drop blank line

> +        minimum: 10000
> +        maximum: 400000
> +
> +    required:
> +      - reg
> +      - led-sources
> +      - flash-max-microamp
> +      - led-max-microamp
> +      - flash-max-timeout-us
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        flash-led-controller@63 {

led-controller@63


Best regards,
Krzysztof