Devicetree
 help / color / mirror / Atom feed
From: Rillian Grant <rillian.grant@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, lee@kernel.org,
	linux-leds@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
	Rillian Grant <rillian.grant@gmail.com>
Subject: Re: [PATCH v2 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes
Date: Mon, 28 Sep 2026 11:08:25 +0100	[thread overview]
Message-ID: <Spi1SCcTSB2Ab7fZGVbFXQ@gmail.com> (raw)
In-Reply-To: <20260928095015.096591F000FF@smtp.kernel.org>

On Monday, 28 September 2026 10:50:14 BST sashiko-bot@kernel.org wrote:
> The subsystem rules strictly mandate: "Only log errors or warnings." Since
> this call to dev_info() executes automatically in lm3643_add_dmi_leds()
> during hardware enumeration on matching laptops, it will add unnecessary
> minor log noise during boot.
> 
> > +
> > +	return devm_add_action_or_reset(dev, lm3643_remove_dmi_leds, dev);
> > +}

Agreed. I will replace with a dev_dbg() call in the next revision.



  reply	other threads:[~2026-09-28 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  9:42 [PATCH v2 0/4] leds: flash: LM3643 dual LED flash driver Rillian Grant
2026-09-28  9:42 ` [PATCH v2 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-09-28  9:49   ` sashiko-bot
2026-10-01  6:34   ` Krzysztof Kozlowski
2026-09-28  9:42 ` [PATCH v2 2/4] leds: flash: Add support for the " Rillian Grant
2026-09-28  9:54   ` sashiko-bot
2026-09-28  9:42 ` [PATCH v2 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-09-28  9:50   ` sashiko-bot
2026-09-28 10:08     ` Rillian Grant [this message]
2026-09-28  9:42 ` [PATCH v2 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-09-28  9:49   ` sashiko-bot
2026-09-29  9:29 ` [PATCH v2 0/4] leds: flash: LM3643 dual LED flash driver Ruslan Koreev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Spi1SCcTSB2Ab7fZGVbFXQ@gmail.com \
    --to=rillian.grant@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox