Re: [PATCH v8 3/3] arm: dts: altera: add Draeger M48 CPU Module

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [Low] dts: unnecessary address/size cells in flash leaf node
- [Low] dts: deprecated name property in memory node
- [Low] dts: deprecated placement of PHY skew properties in MAC node
- [Low] dts: typo in aliases node comment
--

commit b96c17a8d8e5c99eb2bdb2439e91d0063679636c
Author: Petko Manolov <petko.manolov@konsulko.com>

arm: dts: altera: add Draeger M48 CPU Module

This commit introduces device tree support for the Altera SoCFPGA Cyclone 5
component of the heterogeneous Draeger M48 CPU module. The board boots
independently via QSPI and monitors a companion i.MX6 processor.

> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
> new file mode 100644
> index 0000000000000..85daa839c3147
> --- /dev/null
> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + *  (C) Copyright 2020 Draeger and Licensors, info@draeger.com
> + */
> +#include "socfpga_cyclone5.dtsi"
> +
> +/ {
> +	model = "Draeger M48 Cyclone V SoC";
> +	compatible = "draeger,socfpga-m48", "altr,socfpga-cyclone5", "altr,socfpga";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	memory@0 {
> +		name = "memory";

[Severity: Low]
Is this name property intended? Explicit use of the name property in the
memory node is deprecated by the Devicetree Specification as it is
automatically generated by DTC. Leaving it here generates a name_properties
DTC warning.

> +		device_type = "memory";
> +		reg = <0x0 0x40000000>;
> +	};
> +
> +	aliases {
> +		/* this allow the ethaddr uboot environmnet variable contents

[Severity: Low]
This isn't a bug, but there's a typo in this comment. The word "environmnet"
should be "environment".

> +		 * to be added to the gmac0 device tree blob.
> +		 */
> +		ethernet0 = &gmac0;
> +	};
> +};
> +
> +&gmac0 {
> +	status = "okay";
> +	phy-mode = "rgmii-id";
> +	rxc-skew-ps = <1860>;
> +	rxd0-skew-ps = <0>;

[Severity: Low]
Are these PHY-specific skew properties attached to the correct node?

Placing them directly in the &gmac0 MAC node relies on a deprecated driver
fallback mechanism (documented in drivers/net/phy/micrel.c). They should
normally be attached to a dedicated mdio PHY sub-node.

> +	rxd1-skew-ps = <0>;
> +	rxd2-skew-ps = <0>;
> +	rxd3-skew-ps = <0>;
> +	rxdv-skew-ps = <0>;
> +	txc-skew-ps = <900>;
> +	txd0-skew-ps = <0>;
> +	txd1-skew-ps = <0>;
> +	txd2-skew-ps = <0>;
> +	txd3-skew-ps = <0>;
> +	txen-skew-ps = <0>;
> +};

[ ... ]

> +&qspi {
> +	status = "okay";
> +
> +	flash: flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;

[Severity: Low]
Are these cells necessary?

The flash@0 node lacks child partitions, leaving these properties dangling
and triggering an avoid_unnecessary_addr_size DTC warning during
compilation.

> +		compatible = "micron,n25q256a", "jedec,spi-nor";
> +		reg = <0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929134058.819371-1-petko.manolov@konsulko.com?part=3