Re: [PATCH 4/5] arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit address vs reg mismatch in restartreason-sram node
--

commit 4b33adc218a1891c7f1ef39e3eac2b1ba37f9136
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM

This commit adds the "sram" property to the watchdog device node to enable
retrieval of the system restart reason from IMEM, and creates the required
SRAM child node to map the restart reason memory region.

> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index f7cc6f274ca91..2156911876cca 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -760,8 +760,16 @@ usb_0_qmpphy: phy@7d000 {
>  		sram@8600000 {
>  			compatible = "qcom,ipq9574-imem", "mmio-sram";
>  			reg = <0x08600000 0x8000>;
> +			ranges = <0 0x08600000 0x8000>;
>  
>  			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			restart_reason: restartreason-sram@7b0 {
> +				reg = <0x7a4 0x4>;
> +			};

[Severity: Low]
Does the unit address in the node name (@7b0) need to match the first address
specified in the reg property (0x7a4)? A mismatch here typically triggers a
unit_address_vs_reg warning from the device tree compiler during the build.

Should the node name be updated to restartreason-sram@7a4, or does the reg
property need to be corrected to 0x7b0?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=4