Re: [PATCH 5/5] arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit-address mismatch for restart_reason node
--

commit 5d6664a4ef4cd5e108f7a22f5edd5974f3708b98
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

This commit adds the sram property to the watchdog device node to enable
retrieval of the system restart reason from IMEM. It also defines the
restartreason-sram node in the IMEM SRAM block.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 3e10f45e182e1..6a54a548b4f86 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -496,8 +496,16 @@ qpic_nand: spi@79b0000 {
>  		sram@8600000 {
>  			compatible = "qcom,ipq5332-imem", "mmio-sram";
>  			reg = <0x08600000 0x14000>;
> +			ranges = <0 0x08600000 0x14000>;
>  
>  			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			restart_reason: restartreason-sram@7b0 {
> +				reg = <0x7a4 0x4>;
> +			};

[Severity: Low]
Does this node name violate the Devicetree Specification? The unit-address in
the node name (7b0) does not match the first address specified in its reg
property (0x7a4). This will cause a unit_address_vs_reg compiler warning
during dtc execution.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=5