[PATCH 0/5] Add support for reporting boot status on Qualcomm IPQ9574 and IPQ5332

[PATCH 0/5] Add support for reporting boot status on Qualcomm IPQ9574 and IPQ5332

[Kathiravan Thirumoorthy]

Similar to IPQ5424, add the IMEM node and the restart-reason child node
on IPQ9574 and IPQ5332 to enable reporting of watchdog boot status.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
Kathiravan Thirumoorthy (5):
      dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332
      arm64: dts: qcom: ipq9574: add the IMEM node
      arm64: dts: qcom: ipq5332: add the IMEM node
      arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM
      arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

 Documentation/devicetree/bindings/sram/sram.yaml |  2 ++
 arch/arm64/boot/dts/qcom/ipq5332.dtsi            | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq9574.dtsi            | 16 ++++++++++++++++
 3 files changed, 34 insertions(+)
---
base-commit: 6c2cb8b8b843d216ab549b678a0d8831c43153e0
change-id: 20260929-imem_restart_reason-15c5b95f9a5a

Best regards,
--  
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

[PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

[Kathiravan Thirumoorthy]

Document the compatibles for the IMEM found in the Qualcomm's IPQ9574
and IPQ5332 SoCs.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sram/sram.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
index 6ee0b1464722..d65696885e6a 100644
--- a/Documentation/devicetree/bindings/sram/sram.yaml
+++ b/Documentation/devicetree/bindings/sram/sram.yaml
@@ -37,6 +37,8 @@ properties:
         - qcom,eliza-imem
         - qcom,glymur-imem
         - qcom,hawi-imem
+        - qcom,ipq9574-imem
+        - qcom,ipq5332-imem
         - qcom,ipq5424-imem
         - qcom,kaanapali-imem
         - qcom,maili-imem

-- 
2.34.1

Re: [PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: sram: compatible strings not sorted alphabetically
--

commit be343d0f902aa8be0dcbad3550c7127521779814
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

This commit documents the compatible strings for the IMEM found in the 
Qualcomm IPQ9574 and IPQ5332 SoCs.

> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
> index 6ee0b14647222..d65696885e6a5 100644
> --- a/Documentation/devicetree/bindings/sram/sram.yaml
> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
> @@ -37,6 +37,8 @@ properties:
>          - qcom,eliza-imem
>          - qcom,glymur-imem
>          - qcom,hawi-imem
> +        - qcom,ipq9574-imem
> +        - qcom,ipq5332-imem
>          - qcom,ipq5424-imem

[Severity: Low]
This isn't a bug, but does this addition break the alphabetical sorting of
the compatible string list?

Placing qcom,ipq9574-imem and qcom,ipq5332-imem directly above 
qcom,ipq5424-imem results in ipq9574 appearing before ipq5332 and ipq5424,
which seems to violate the expected alphabetical sort order.

>          - qcom,kaanapali-imem
>          - qcom,maili-imem

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=1

Re: [PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

[Krzysztof Kozlowski]

On Thu, Oct 01, 2026 at 08:41:11PM +0530, Kathiravan Thirumoorthy wrote:
> Document the compatibles for the IMEM found in the Qualcomm's IPQ9574
> and IPQ5332 SoCs.
> 
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sram/sram.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
> index 6ee0b1464722..d65696885e6a 100644
> --- a/Documentation/devicetree/bindings/sram/sram.yaml
> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
> @@ -37,6 +37,8 @@ properties:
>          - qcom,eliza-imem
>          - qcom,glymur-imem
>          - qcom,hawi-imem
> +        - qcom,ipq9574-imem

Why reversed order?

> +        - qcom,ipq5332-imem

Best regards,
Krzysztof

Re: [PATCH 1/5] dt-bindings: sram: Document IMEM found in Qualcomm's IPQ9574 and IPQ5332

[Kathiravan Thirumoorthy]

On 10/2/2026 3:11 PM, Krzysztof Kozlowski wrote:
> On Thu, Oct 01, 2026 at 08:41:11PM +0530, Kathiravan Thirumoorthy wrote:
>> Document the compatibles for the IMEM found in the Qualcomm's IPQ9574
>> and IPQ5332 SoCs.
>>
>> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/sram/sram.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sram/sram.yaml b/Documentation/devicetree/bindings/sram/sram.yaml
>> index 6ee0b1464722..d65696885e6a 100644
>> --- a/Documentation/devicetree/bindings/sram/sram.yaml
>> +++ b/Documentation/devicetree/bindings/sram/sram.yaml
>> @@ -37,6 +37,8 @@ properties:
>>           - qcom,eliza-imem
>>           - qcom,glymur-imem
>>           - qcom,hawi-imem
>> +        - qcom,ipq9574-imem
> Why reversed order?

My bad! Fixed it in v2.

>
>> +        - qcom,ipq5332-imem
> Best regards,
> Krzysztof
>

[PATCH 2/5] arm64: dts: qcom: ipq9574: add the IMEM node

[Kathiravan Thirumoorthy]

Add the IMEM node to the device tree to extract debugging information
like system restart reason, which is populated via IMEM. Define the
IMEM region to enable this functionality.

As described, overall IMEM region is 32KB but only initial 4KB is
accessible by all masters in the SoC.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 771a59585645..f7cc6f274ca9 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -757,6 +757,13 @@ usb_0_qmpphy: phy@7d000 {
 			status = "disabled";
 		};
 
+		sram@8600000 {
+			compatible = "qcom,ipq9574-imem", "mmio-sram";
+			reg = <0x08600000 0x8000>;
+
+			no-memory-wc;
+		};
+
 		usb3: usb@8af8800 {
 			compatible = "qcom,ipq9574-dwc3", "qcom,dwc3";
 			reg = <0x08af8800 0x400>;

-- 
2.34.1

[PATCH 3/5] arm64: dts: qcom: ipq5332: add the IMEM node

[Kathiravan Thirumoorthy]

Add the IMEM node to the device tree to extract debugging information
like system restart reason, which is populated via IMEM. Define the
IMEM region to enable this functionality.

As described, overall IMEM region is 80KB but only initial 4KB is
accessible by all masters in the SoC.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 74d9de8d7641..3e10f45e182e 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -493,6 +493,13 @@ qpic_nand: spi@79b0000 {
 			status = "disabled";
 		};
 
+		sram@8600000 {
+			compatible = "qcom,ipq5332-imem", "mmio-sram";
+			reg = <0x08600000 0x14000>;
+
+			no-memory-wc;
+		};
+
 		usb: usb@8af8800 {
 			compatible = "qcom,ipq5332-dwc3", "qcom,dwc3";
 			reg = <0x08af8800 0x400>;

-- 
2.34.1

Re: [PATCH 3/5] arm64: dts: qcom: ipq5332: add the IMEM node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: mmio-sram maps inaccessible memory into genalloc pool
--

commit 9c529a16f97d21ecf65fd333c3ade51834ef2084
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5332: add the IMEM node

This commit adds the IMEM node to the ipq5332 device tree to extract debugging
information. It defines an 80KB IMEM region, noting that only the initial 4KB
is accessible by all masters in the SoC.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -493,6 +493,13 @@ qpic_nand: spi@79b0000 {
>  			status = "disabled";
>  		};
>  
> +		sram@8600000 {
> +			compatible = "qcom,ipq5332-imem", "mmio-sram";
> +			reg = <0x08600000 0x14000>;

[Severity: High]
Will this map the inaccessible 76KB of memory into the generic allocator pool?

The commit message notes that only the initial 4KB is accessible, but the
defined region is 80KB (0x14000). Because this node uses the mmio-sram
compatible, the generic sram driver will unconditionally ioremap the full
region and add all unreserved memory into the kernel's genalloc pool:

drivers/misc/sram.c:sram_reserve_regions()
    ret = gen_pool_add_virt(sram->pool,
            (unsigned long)sram->virt_base + cur_start,
            res->start + cur_start, cur_size, -1);

If a driver dynamically requests SRAM, or if speculative hardware accesses
occur across the mapped device memory, could this trigger a fatal synchronous
external abort (SError) and system panic?

Would it be better to either restrict the reg property size to the accessible
4KB (0x1000) or add a driver quirk to explicitly avoid mapping the inaccessible
regions?

> +
> +			no-memory-wc;
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=3

[PATCH 4/5] arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM

[Kathiravan Thirumoorthy]

Add the "sram" property to the watchdog device node to enable
retrieval of the system restart reason from IMEM, populated by XBL.
Parse this information in the watchdog driver and update the bootstatus
sysFS if the restart was triggered by a watchdog timeout.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index f7cc6f274ca9..2156911876cc 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -760,8 +760,16 @@ usb_0_qmpphy: phy@7d000 {
 		sram@8600000 {
 			compatible = "qcom,ipq9574-imem", "mmio-sram";
 			reg = <0x08600000 0x8000>;
+			ranges = <0 0x08600000 0x8000>;
 
 			no-memory-wc;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			restart_reason: restartreason-sram@7b0 {
+				reg = <0x7a4 0x4>;
+			};
 		};
 
 		usb3: usb@8af8800 {
@@ -854,6 +862,7 @@ watchdog: watchdog@b017000 {
 			interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&sleep_clk>;
 			timeout-sec = <30>;
+			sram = <&restart_reason>;
 		};
 
 		apcs_glb: mailbox@b111000 {

-- 
2.34.1

Re: [PATCH 4/5] arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit address vs reg mismatch in restartreason-sram node
--

commit 4b33adc218a1891c7f1ef39e3eac2b1ba37f9136
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq9574: add support to get watchdog bootstatus from IMEM

This commit adds the "sram" property to the watchdog device node to enable
retrieval of the system restart reason from IMEM, and creates the required
SRAM child node to map the restart reason memory region.

> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index f7cc6f274ca91..2156911876cca 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -760,8 +760,16 @@ usb_0_qmpphy: phy@7d000 {
>  		sram@8600000 {
>  			compatible = "qcom,ipq9574-imem", "mmio-sram";
>  			reg = <0x08600000 0x8000>;
> +			ranges = <0 0x08600000 0x8000>;
>  
>  			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			restart_reason: restartreason-sram@7b0 {
> +				reg = <0x7a4 0x4>;
> +			};

[Severity: Low]
Does the unit address in the node name (@7b0) need to match the first address
specified in the reg property (0x7a4)? A mismatch here typically triggers a
unit_address_vs_reg warning from the device tree compiler during the build.

Should the node name be updated to restartreason-sram@7a4, or does the reg
property need to be corrected to 0x7b0?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=4

[PATCH 5/5] arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

[Kathiravan Thirumoorthy]

Add the "sram" property to the watchdog device node to enable
retrieval of the system restart reason from IMEM, populated by XBL.
Parse this information in the watchdog driver and update the bootstatus
sysFS if the restart was triggered by a watchdog timeout.

Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/ipq5332.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
index 3e10f45e182e..6a54a548b4f8 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
@@ -496,8 +496,16 @@ qpic_nand: spi@79b0000 {
 		sram@8600000 {
 			compatible = "qcom,ipq5332-imem", "mmio-sram";
 			reg = <0x08600000 0x14000>;
+			ranges = <0 0x08600000 0x14000>;
 
 			no-memory-wc;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			restart_reason: restartreason-sram@7b0 {
+				reg = <0x7a4 0x4>;
+			};
 		};
 
 		usb: usb@8af8800 {
@@ -585,6 +593,7 @@ watchdog: watchdog@b017000 {
 			interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
 			clocks = <&sleep_clk>;
 			timeout-sec = <30>;
+			sram = <&restart_reason>;
 		};
 
 		apcs_glb: mailbox@b111000 {

-- 
2.34.1

Re: [PATCH 5/5] arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit-address mismatch for restart_reason node
--

commit 5d6664a4ef4cd5e108f7a22f5edd5974f3708b98
Author: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

arm64: dts: qcom: ipq5332: add support to get watchdog bootstatus from IMEM

This commit adds the sram property to the watchdog device node to enable
retrieval of the system restart reason from IMEM. It also defines the
restartreason-sram node in the IMEM SRAM block.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 3e10f45e182e1..6a54a548b4f86 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -496,8 +496,16 @@ qpic_nand: spi@79b0000 {
>  		sram@8600000 {
>  			compatible = "qcom,ipq5332-imem", "mmio-sram";
>  			reg = <0x08600000 0x14000>;
> +			ranges = <0 0x08600000 0x14000>;
>  
>  			no-memory-wc;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			restart_reason: restartreason-sram@7b0 {
> +				reg = <0x7a4 0x4>;
> +			};

[Severity: Low]
Does this node name violate the Devicetree Specification? The unit-address in
the node name (7b0) does not match the first address specified in its reg
property (0x7a4). This will cause a unit_address_vs_reg compiler warning
during dtc execution.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001-imem_restart_reason-v1-0-79f516906010@oss.qualcomm.com?part=5