From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Ulf Hansson <ulfh@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v3 1/7] dt-bindings: power: qcom-rpmpd: define RPMPD_VDDMD
Date: Fri, 2 Oct 2026 11:57:25 +0200 [thread overview]
Message-ID: <20261002-devious-mauve-wrasse-66bbeb@quoll> (raw)
In-Reply-To: <20261002-sdm632-rpmpd-v3-1-95c47d0f26cf@mainlining.org>
On Fri, Oct 02, 2026 at 12:38:29AM +0200, Barnabás Czémán wrote:
> Define RPMPD_VDDMD can be used for SDM439 and SDM632 MSS.
There is no sdm439 RPMPD... The SDM632 is added later and bindings
header come with the compatible patch. Squash these.
>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> include/dt-bindings/power/qcom-rpmpd.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index 4371ac941f29..beb066b3aa8c 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -15,6 +15,7 @@
> #define RPMPD_VDDMX 3
> #define RPMPD_VDDMX_AO 4
> #define RPMPD_VDDMX_VFL 5
> +#define RPMPD_VDDMD 5
Problem is that it is platform specific and comment in that file says
"don't do it" yet you do it.
So the device has nbo MX? Why commit msg is silent on this? Explains
not much except repeating the diff and referencing users which are
almost obvious if this is properly squashed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-02 9:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 22:38 [PATCH v3 0/7] MSM8953/SDM632 rpmpd/mss fixes Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 1/7] dt-bindings: power: qcom-rpmpd: define RPMPD_VDDMD Barnabás Czémán
2026-10-02 9:14 ` sashiko-bot
2026-10-02 9:57 ` Krzysztof Kozlowski [this message]
2026-10-02 14:04 ` Barnabás Czémán
2026-10-05 7:00 ` Dmitry Baryshkov
2026-10-01 22:38 ` [PATCH v3 2/7] dt-bindings: power: qcom,rpmpd: Add SDM632 Barnabás Czémán
2026-10-05 7:01 ` Dmitry Baryshkov
2026-10-01 22:38 ` [PATCH v3 3/7] pmdomain: qcom: rpmpd: Split SDM632 pm domains from MSM8953 Barnabás Czémán
2026-10-02 9:14 ` sashiko-bot
2026-10-05 7:04 ` Dmitry Baryshkov
2026-10-06 18:21 ` Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 4/7] remoteproc: qcom_q6v5_mss: Use mss as regulator for MSM8953 Barnabás Czémán
2026-10-02 9:14 ` sashiko-bot
2026-10-05 7:06 ` Dmitry Baryshkov
2026-10-06 18:18 ` Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632 Barnabás Czémán
2026-10-02 9:14 ` sashiko-bot
2026-10-02 10:01 ` Krzysztof Kozlowski
2026-10-02 14:05 ` Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 6/7] remoteproc: qcom_q6v5_mss: Add SDM632 MSS Barnabás Czémán
2026-10-01 22:38 ` [PATCH v3 7/7] arm64: dts: qcom: sdm632: Correct power domains Barnabás Czémán
2026-10-02 9:14 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002-devious-mauve-wrasse-66bbeb@quoll \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=stephan@gerhold.net \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox