Re: [PATCH v3 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dt-bindings: remoteproc: msm8953 device trees lack newly required mss-supply
--

commit 9361957c0df3f4f2db804dba4f7e53e9096f9d42
Author: Barnabás Czémán <barnabas.czeman@mainlining.org>

dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632

This commit updates the dt-bindings for the MSM8916 MSS PIL to include
SDM632. It adjusts the schemas because SDM632 is similar to MSM8953 but
uses a power domain for the mss-supply instead of a regulator.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
> index 4049157dd83d7..049191cad5f83 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml

[ ... ]

> @@ -287,6 +289,7 @@ allOf:
>                - qcom,msm8917-mss-pil
>                - qcom,msm8937-mss-pil
>                - qcom,msm8940-mss-pil
> +              - qcom,msm8953-mss-pil
>                - qcom,msm8974-mss-pil
>      then:
>        required:
>          - mss-supply

[Severity: High]
Does making mss-supply a required property for msm8953 break existing
device trees?

Looking at existing in-tree device trees for msm8953, such as
arch/arm64/boot/dts/qcom/msm8953.dtsi, the mpss node uses the compatible
string but does not provide an mss-supply property:

		mpss: remoteproc@4080000 {
			compatible = "qcom,msm8953-mss-pil";
			...
			power-domains = <&rpmpd MSM8953_VDDCX>,
					<&rpmpd MSM8953_VDDMX>;
			power-domain-names = "cx", "mx";

Earlier patches in this series removed the MSM8953_VDDMD power domain and
updated the driver to request an mss regulator, but the mss-supply
property was not actually added to the msm8953 device tree nodes.

Because the property is missing from the device tree nodes, merging this
series will cause schema validation to fail for all msm8953 boards.

Furthermore, at runtime, the qcom_q6v5_mss driver will silently receive a
dummy regulator for mss. Since the actual hardware regulator is never
enabled, will this cause the modem to silently fail to boot on msm8953
devices?

This issue does not appear to be resolved by any subsequent patches in the
series.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-sdm632-rpmpd-v3-0-95c47d0f26cf@mainlining.org?part=5