Re: [PATCH v3 7/7] arm64: dts: qcom: sdm632: Correct power domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] remoteproc: qcom_q6v5_mss: probe failure due to missing mss-supply for MSM8953
- [Medium] dt-bindings: power: qcom-rpmpd: RPMPD_VDDMD conflicts with RPMPD_VDDMX_VFL
--

commit f5ae81644790ad18298d9d35e487c425be535c4d
Author: Barnabás Czémán <barnabas.czeman@mainlining.org>

arm64: dts: qcom: sdm632: Correct power domains

This commit adds power domain overrides for the SDM632. It specifies 
domains for various subsystems, acknowledging that SDM632 uses different 
power domains from the MSM8953 it is based on.

> diff --git a/arch/arm64/boot/dts/qcom/sdm632.dtsi b/arch/arm64/boot/dts/qcom/sdm632.dtsi
> index 40d86d91b67fa..5a677da5afb01 100644
> --- a/arch/arm64/boot/dts/qcom/sdm632.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm632.dtsi
[ ... ]
> @@ -87,3 +87,37 @@ opp-725000000 {
[ ... ]
> +&mpss {
> +	compatible = "qcom,sdm632-mss-pil";
> +	power-domains = <&rpmpd RPMPD_VDDCX>,
> +			<&rpmpd RPMPD_VDDMX>,
> +			<&rpmpd RPMPD_VDDMD>;

[Severity: Medium]
Does the use of RPMPD_VDDMD here conflict with RPMPD_VDDMX_VFL?

In include/dt-bindings/power/qcom-rpmpd.h, both are defined as 5:

#define RPMPD_VDDMX_VFL         5
#define RPMPD_VDDMD             5

A SoC that has both domains would have a conflict in the provider array,
or a user specifying RPMPD_VDDMD on a board that has VDDMX_VFL will scale
the wrong regulator.

[Severity: High]
While overriding the domains for SDM632 here, does this leave MSM8953 broken?

The mss power domain was removed in arch/arm64/boot/dts/qcom/msm8953.dtsi
at the mpss node, but the required mss-supply was not added.

The MSS driver now requires an mss-supply active regulator for MSM8953.
Consequently, the driver falls back to a dummy regulator.
When q6v5_regulator_enable() attempts to set 1.05V, regulator_set_voltage()
returns -EINVAL on the dummy regulator, causing a fatal start failure.

Furthermore, this breaks backward compatibility for older MSM8953 DTBs
because the MSM8953_VDDMD power domain was removed from the
msm8953_rpmpds[] provider array, causing genpd attach to fail.

> +	power-domain-names = "cx",
> +			     "mx",
> +			     "mss";
> +};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002-sdm632-rpmpd-v3-0-95c47d0f26cf@mainlining.org?part=7