From: Kanak Shilledar <kanak.shilledar@axis.com>
To: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Kanak Shilledar <kanak.shilledar@axis.com>
Subject: [PATCH 2/4] riscv: dts: thead: th1520: Cleanup with dt-check-style
Date: Fri, 2 Oct 2026 15:43:34 +0200 [thread overview]
Message-ID: <20261002-fix-dts-th1520-v1-2-9a8810091d47@axis.com> (raw)
In-Reply-To: <20261002-fix-dts-th1520-v1-0-9a8810091d47@axis.com>
Fix warnings related to "property-order" and "required-blank-lines"
reported from krzk's recent updates to dt-check-style tool. Leave
out reordering of the nodes as it creates a very bit diff. After this
patch only the following warnings remain which can be fixed in future
work:
thead/th1520.dtsi:221: [child-name-order] child node 'oscillator' out of name order
thead/th1520.dtsi:227: [child-name-order] child node '32k-oscillator' out of name order
thead/th1520.dtsi:248: [property-name] property name "snps,wr_osr_lmt" is using discouraged style
thead/th1520.dtsi:249: [property-name] property name "snps,rd_osr_lmt" is using discouraged style
thead/th1520.dtsi:253: [child-name-order] child node 'aon' out of name order
Fix these warnings to make the file more readable and maintainable
along with that to make it more compliant with the devicetree
specifications.
Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
---
arch/riscv/boot/dts/thead/th1520.dtsi | 108 ++++++++++++++++++++++------------
1 file changed, 69 insertions(+), 39 deletions(-)
diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
index b01a94785d870..aa6572b4af559 100644
--- a/arch/riscv/boot/dts/thead/th1520.dtsi
+++ b/arch/riscv/boot/dts/thead/th1520.dtsi
@@ -20,15 +20,8 @@ cpus: cpus {
timebase-frequency = <3000000>;
c910_0: cpu@0 {
- compatible = "thead,c910", "riscv";
device_type = "cpu";
- riscv,isa = "rv64imafdc";
- riscv,isa-base = "rv64i";
- riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
- "ziccrse", "zicntr", "zicsr",
- "zifencei", "zihpm", "zfh",
- "xtheadvector";
- thead,vlenb = <16>;
+ compatible = "thead,c910", "riscv";
reg = <0>;
i-cache-block-size = <64>;
i-cache-size = <65536>;
@@ -38,6 +31,13 @@ c910_0: cpu@0 {
d-cache-sets = <512>;
next-level-cache = <&l2_cache>;
mmu-type = "riscv,sv39";
+ riscv,isa = "rv64imafdc";
+ riscv,isa-base = "rv64i";
+ riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
+ "ziccrse", "zicntr", "zicsr",
+ "zifencei", "zihpm", "zfh",
+ "xtheadvector";
+ thead,vlenb = <16>;
cpu0_intc: interrupt-controller {
compatible = "riscv,cpu-intc";
@@ -47,15 +47,8 @@ cpu0_intc: interrupt-controller {
};
c910_1: cpu@1 {
- compatible = "thead,c910", "riscv";
device_type = "cpu";
- riscv,isa = "rv64imafdc";
- riscv,isa-base = "rv64i";
- riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
- "ziccrse", "zicntr", "zicsr",
- "zifencei", "zihpm", "zfh",
- "xtheadvector";
- thead,vlenb = <16>;
+ compatible = "thead,c910", "riscv";
reg = <1>;
i-cache-block-size = <64>;
i-cache-size = <65536>;
@@ -65,6 +58,13 @@ c910_1: cpu@1 {
d-cache-sets = <512>;
next-level-cache = <&l2_cache>;
mmu-type = "riscv,sv39";
+ riscv,isa = "rv64imafdc";
+ riscv,isa-base = "rv64i";
+ riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
+ "ziccrse", "zicntr", "zicsr",
+ "zifencei", "zihpm", "zfh",
+ "xtheadvector";
+ thead,vlenb = <16>;
cpu1_intc: interrupt-controller {
compatible = "riscv,cpu-intc";
@@ -74,15 +74,8 @@ cpu1_intc: interrupt-controller {
};
c910_2: cpu@2 {
- compatible = "thead,c910", "riscv";
device_type = "cpu";
- riscv,isa = "rv64imafdc";
- riscv,isa-base = "rv64i";
- riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
- "ziccrse", "zicntr", "zicsr",
- "zifencei", "zihpm", "zfh",
- "xtheadvector";
- thead,vlenb = <16>;
+ compatible = "thead,c910", "riscv";
reg = <2>;
i-cache-block-size = <64>;
i-cache-size = <65536>;
@@ -92,6 +85,13 @@ c910_2: cpu@2 {
d-cache-sets = <512>;
next-level-cache = <&l2_cache>;
mmu-type = "riscv,sv39";
+ riscv,isa = "rv64imafdc";
+ riscv,isa-base = "rv64i";
+ riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
+ "ziccrse", "zicntr", "zicsr",
+ "zifencei", "zihpm", "zfh",
+ "xtheadvector";
+ thead,vlenb = <16>;
cpu2_intc: interrupt-controller {
compatible = "riscv,cpu-intc";
@@ -101,15 +101,8 @@ cpu2_intc: interrupt-controller {
};
c910_3: cpu@3 {
- compatible = "thead,c910", "riscv";
device_type = "cpu";
- riscv,isa = "rv64imafdc";
- riscv,isa-base = "rv64i";
- riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
- "ziccrse", "zicntr", "zicsr",
- "zifencei", "zihpm", "zfh",
- "xtheadvector";
- thead,vlenb = <16>;
+ compatible = "thead,c910", "riscv";
reg = <3>;
i-cache-block-size = <64>;
i-cache-size = <65536>;
@@ -119,6 +112,13 @@ c910_3: cpu@3 {
d-cache-sets = <512>;
next-level-cache = <&l2_cache>;
mmu-type = "riscv,sv39";
+ riscv,isa = "rv64imafdc";
+ riscv,isa-base = "rv64i";
+ riscv,isa-extensions = "i", "m", "a", "f", "d", "c",
+ "ziccrse", "zicntr", "zicsr",
+ "zifencei", "zihpm", "zfh",
+ "xtheadvector";
+ thead,vlenb = <16>;
cpu3_intc: interrupt-controller {
compatible = "riscv,cpu-intc";
@@ -261,11 +261,11 @@ aon: aon {
soc {
compatible = "simple-bus";
+ ranges;
interrupt-parent = <&plic>;
#address-cells = <2>;
#size-cells = <2>;
dma-noncoherent;
- ranges;
plic: interrupt-controller@ffd8000000 {
compatible = "thead,th1520-plic", "thead,c900-plic";
@@ -302,6 +302,7 @@ spi0: spi@ffe700c000 {
clocks = <&clk CLK_SPI>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -313,6 +314,7 @@ uart0: serial@ffe7014000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -330,6 +332,7 @@ gmac1: ethernet@ffe7060000 {
snps,multicast-filter-bins = <64>;
snps,perfect-filter-entries = <32>;
snps,axi-config = <&stmmac_axi_config>;
+
status = "disabled";
mdio1: mdio {
@@ -353,6 +356,7 @@ gmac0: ethernet@ffe7070000 {
snps,multicast-filter-bins = <64>;
snps,perfect-filter-entries = <32>;
snps,axi-config = <&stmmac_axi_config>;
+
status = "disabled";
mdio0: mdio {
@@ -368,6 +372,7 @@ emmc: mmc@ffe7080000 {
interrupts = <62 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk CLK_EMMC_SDIO>;
clock-names = "core";
+
status = "disabled";
};
@@ -377,6 +382,7 @@ sdio0: mmc@ffe7090000 {
interrupts = <64 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk CLK_EMMC_SDIO>;
clock-names = "core";
+
status = "disabled";
};
@@ -386,6 +392,7 @@ sdio1: mmc@ffe70a0000 {
interrupts = <71 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clk CLK_EMMC_SDIO>;
clock-names = "core";
+
status = "disabled";
};
@@ -397,6 +404,7 @@ uart1: serial@ffe7f00000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -408,6 +416,7 @@ uart3: serial@ffe7f04000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -418,6 +427,7 @@ i2c0: i2c@ffe7f20000 {
clocks = <&clk CLK_I2C0>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -428,6 +438,7 @@ i2c1: i2c@ffe7f24000 {
clocks = <&clk CLK_I2C1>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -438,6 +449,7 @@ i2c4: i2c@ffe7f28000 {
clocks = <&clk CLK_I2C4>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -451,11 +463,11 @@ gpio@ffe7f34000 {
gpio2: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <32>;
gpio-ranges = <&padctrl0_apsys 0 0 32>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <58 IRQ_TYPE_LEVEL_HIGH>;
@@ -472,11 +484,11 @@ gpio@ffe7f38000 {
gpio3: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <23>;
gpio-ranges = <&padctrl0_apsys 0 32 23>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <59 IRQ_TYPE_LEVEL_HIGH>;
@@ -500,11 +512,11 @@ gpio@ffec005000 {
gpio0: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <32>;
gpio-ranges = <&padctrl1_apsys 0 0 32>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <56 IRQ_TYPE_LEVEL_HIGH>;
@@ -521,11 +533,11 @@ gpio@ffec006000 {
gpio1: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <31>;
gpio-ranges = <&padctrl1_apsys 0 32 31>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <57 IRQ_TYPE_LEVEL_HIGH>;
@@ -546,6 +558,7 @@ i2c2: i2c@ffec00c000 {
clocks = <&clk CLK_I2C2>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -557,6 +570,7 @@ uart2: serial@ffec010000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -567,6 +581,7 @@ i2c3: i2c@ffec014000 {
clocks = <&clk CLK_I2C3>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -648,6 +663,7 @@ hdmi: hdmi@ffef540000 {
resets = <&rst TH1520_RESET_ID_HDMI>,
<&rst TH1520_RESET_ID_HDMI_APB>;
reset-names = "main", "apb";
+
status = "disabled";
ports {
@@ -682,6 +698,7 @@ dpu: display@ffef600000 {
<&rst TH1520_RESET_ID_DPU_AXI>,
<&rst TH1520_RESET_ID_DPU_AHB>;
reset-names = "core", "axi", "ahb";
+
status = "disabled";
ports {
@@ -714,6 +731,7 @@ dmac0: dma-controller@ffefc00000 {
snps,dma-masters = <1>;
snps,data-width = <4>;
snps,axi-max-burst-len = <16>;
+
status = "disabled";
};
@@ -723,6 +741,7 @@ timer0: timer@ffefc32000 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <16 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -732,6 +751,7 @@ timer1: timer@ffefc32014 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -741,6 +761,7 @@ timer2: timer@ffefc32028 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <18 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -750,6 +771,7 @@ timer3: timer@ffefc3203c {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -761,6 +783,7 @@ uart4: serial@fff7f08000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -772,6 +795,7 @@ uart5: serial@fff7f0c000 {
clock-names = "baudclk", "apb_pclk";
reg-shift = <2>;
reg-io-width = <4>;
+
status = "disabled";
};
@@ -782,6 +806,7 @@ i2c5: i2c@fff7f2c000 {
clocks = <&clk CLK_I2C5>;
#address-cells = <1>;
#size-cells = <0>;
+
status = "disabled";
};
@@ -791,6 +816,7 @@ timer4: timer@ffffc33000 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -800,6 +826,7 @@ timer5: timer@ffffc33014 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -809,6 +836,7 @@ timer6: timer@ffffc33028 {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -818,6 +846,7 @@ timer7: timer@ffffc3303c {
clocks = <&clk CLK_PERI_APB_PCLK>;
clock-names = "timer";
interrupts = <23 IRQ_TYPE_LEVEL_HIGH>;
+
status = "disabled";
};
@@ -845,11 +874,11 @@ gpio@fffff41000 {
aogpio: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <16>;
gpio-ranges = <&padctrl_aosys 0 9 16>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <76 IRQ_TYPE_LEVEL_HIGH>;
@@ -860,6 +889,7 @@ rst_ao: reset-controller@fffff44000 {
compatible = "thead,th1520-reset-ao";
reg = <0xff 0xfff44000 0x0 0x2000>;
#reset-cells = <1>;
+
status = "reserved";
};
@@ -893,11 +923,11 @@ gpio@fffff52000 {
gpio4: gpio-controller@0 {
compatible = "snps,dw-apb-gpio-port";
+ reg = <0>;
gpio-controller;
#gpio-cells = <2>;
ngpios = <23>;
gpio-ranges = <&padctrl_aosys 0 25 22>, <&padctrl_aosys 22 7 1>;
- reg = <0>;
interrupt-controller;
#interrupt-cells = <2>;
interrupts = <55 IRQ_TYPE_LEVEL_HIGH>;
--
2.43.0
next prev parent reply other threads:[~2026-10-02 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 13:43 [PATCH 0/4] riscv: dts: thead: Cleanup with dt-check-style Kanak Shilledar
2026-10-02 13:43 ` [PATCH 1/4] riscv: dts: thead: beaglev-ahead: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar [this message]
2026-10-02 13:43 ` [PATCH 3/4] riscv: dts: th1520-lichee-module-4a: " Kanak Shilledar
2026-10-02 13:43 ` [PATCH 4/4] riscv: dts: thead: th1520-lichee-pi-4a: " Kanak Shilledar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002-fix-dts-th1520-v1-2-9a8810091d47@axis.com \
--to=kanak.shilledar@axis.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox