Devicetree
 help / color / mirror / Atom feed
From: Kanak Shilledar <kanak.shilledar@axis.com>
To: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
	Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Kanak Shilledar <kanak.shilledar@axis.com>
Subject: [PATCH 4/4] riscv: dts: thead: th1520-lichee-pi-4a: Cleanup with dt-check-style
Date: Fri, 2 Oct 2026 15:43:36 +0200	[thread overview]
Message-ID: <20261002-fix-dts-th1520-v1-4-9a8810091d47@axis.com> (raw)
In-Reply-To: <20261002-fix-dts-th1520-v1-0-9a8810091d47@axis.com>

Fix warnings thrown by krzk's recent updates to the dt-check-style
tool when run with strict mode. Fix the following warnings:

	thead/th1520-lichee-pi-4a.dts:161: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
	thead/th1520-lichee-pi-4a.dts:163: [required-blank-lines] "status" must be preceded by a blank line
	thead/th1520-lichee-pi-4a.dts:217: [child-name-order] child node 'rx-pins' out of name order

After this patch, there are no more warnings thrown. Fix these
warnings to make the file more readable and maintainable along with
that to make it more compliant with the devicetree specifications.

Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
---
 arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 90 ++++++++++++-----------
 1 file changed, 47 insertions(+), 43 deletions(-)

diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
index 1eb575aa9a74f..5908b21d558d4 100644
--- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
+++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
@@ -41,10 +41,13 @@ hdmi_con_in: endpoint {
 		};
 	};
 
-	wifi_pwrseq: wifi-pwrseq {
-		compatible = "mmc-pwrseq-simple";
-		reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
-		post-power-on-delay-ms = <200>;
+	fan: pwm-fan {
+		compatible = "pwm-fan";
+		pinctrl-0 = <&fan_pins>;
+		pinctrl-names = "default";
+		#cooling-cells = <2>;
+		pwms = <&pwm 1 10000000 0>;
+		cooling-levels = <0 66 196 255>;
 	};
 
 	thermal-zones {
@@ -53,6 +56,23 @@ cpu-thermal {
 			polling-delay-passive = <1000>;
 			thermal-sensors = <&pvt 0>;
 
+			cooling-maps {
+				map-active-0 {
+					cooling-device = <&fan 1 1>;
+					trip = <&fan_config0>;
+				};
+
+				map-active-1 {
+					cooling-device = <&fan 2 2>;
+					trip = <&fan_config1>;
+				};
+
+				map-active-2 {
+					cooling-device = <&fan 3 3>;
+					trip = <&fan_config2>;
+				};
+			};
+
 			trips {
 				fan_config0: fan-trip0 {
 					temperature = <39000>;
@@ -72,35 +92,14 @@ fan_config2: fan-trip2 {
 					type = "active";
 				};
 			};
-
-			cooling-maps {
-				map-active-0 {
-					cooling-device = <&fan 1 1>;
-					trip = <&fan_config0>;
-				};
-
-				map-active-1 {
-					cooling-device = <&fan 2 2>;
-					trip = <&fan_config1>;
-				};
-
-				map-active-2 {
-					cooling-device = <&fan 3 3>;
-					trip = <&fan_config2>;
-				};
-			};
 		};
 	};
 
-	fan: pwm-fan {
-		pinctrl-names = "default";
-		pinctrl-0 = <&fan_pins>;
-		compatible = "pwm-fan";
-		#cooling-cells = <2>;
-		pwms = <&pwm 1 10000000 0>;
-		cooling-levels = <0 66 196 255>;
+	wifi_pwrseq: wifi-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;
+		post-power-on-delay-ms = <200>;
 	};
-
 };
 
 &dpu {
@@ -119,8 +118,9 @@ hdmi_out_con: endpoint {
 
 &i2c0 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp1: gpio@18 {
@@ -136,8 +136,9 @@ ioexp1: gpio@18 {
 
 &i2c1 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp2: gpio@18 {
@@ -158,8 +159,9 @@ ioexp2: gpio@18 {
 
 &i2c3 {
 	clock-frequency = <400000>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&i2c3_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	ioexp3: gpio@18 {
@@ -204,16 +206,6 @@ i2c-pins {
 	};
 
 	uart0_pins: uart0-0 {
-		tx-pins {
-			pins = "UART0_TXD";
-			function = "uart";
-			bias-disable;
-			drive-strength = <3>;
-			input-disable;
-			input-schmitt-disable;
-			slew-rate = <0>;
-		};
-
 		rx-pins {
 			pins = "UART0_RXD";
 			function = "uart";
@@ -223,6 +215,16 @@ rx-pins {
 			input-schmitt-enable;
 			slew-rate = <0>;
 		};
+
+		tx-pins {
+			pins = "UART0_TXD";
+			function = "uart";
+			bias-disable;
+			drive-strength = <3>;
+			input-disable;
+			input-schmitt-disable;
+			slew-rate = <0>;
+		};
 	};
 };
 
@@ -261,11 +263,13 @@ &sdio1 {
 	keep-power-in-suspend;
 	mmc-pwrseq = <&wifi_pwrseq>;
 	non-removable;
+
 	status = "okay";
 };
 
 &uart0 {
-	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };

-- 
2.43.0


      parent reply	other threads:[~2026-10-02 13:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 13:43 [PATCH 0/4] riscv: dts: thead: Cleanup with dt-check-style Kanak Shilledar
2026-10-02 13:43 ` [PATCH 1/4] riscv: dts: thead: beaglev-ahead: " Kanak Shilledar
2026-10-02 13:43 ` [PATCH 2/4] riscv: dts: thead: th1520: " Kanak Shilledar
2026-10-02 13:43 ` [PATCH 3/4] riscv: dts: th1520-lichee-module-4a: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261002-fix-dts-th1520-v1-4-9a8810091d47@axis.com \
    --to=kanak.shilledar@axis.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fustini@kernel.org \
    --cc=guoren@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox