From: Kanak Shilledar <kanak.shilledar@axis.com>
To: Drew Fustini <fustini@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Kanak Shilledar <kanak.shilledar@axis.com>
Subject: [PATCH 3/4] riscv: dts: th1520-lichee-module-4a: Cleanup with dt-check-style
Date: Fri, 2 Oct 2026 15:43:35 +0200 [thread overview]
Message-ID: <20261002-fix-dts-th1520-v1-3-9a8810091d47@axis.com> (raw)
In-Reply-To: <20261002-fix-dts-th1520-v1-0-9a8810091d47@axis.com>
Fix warnings thrown by krzk's recent updates to the dt-check-style
tool when run with strict mode. Fix the following warnings:
thead/th1520-lichee-module-4a.dtsi:62: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
thead/th1520-lichee-module-4a.dtsi:66: [required-blank-lines] "status" must be preceded by a blank line
thead/th1520-lichee-module-4a.dtsi:129: [child-name-order] child node 'rx-pins' out of name order
After this patch, there are no more warnings left. Fix these warnings
to make the file more readable and maintainable along with that to
make it more compliant with the devicetree specifications.
Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
---
.../boot/dts/thead/th1520-lichee-module-4a.dtsi | 56 ++++++++++++----------
1 file changed, 30 insertions(+), 26 deletions(-)
diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
index 8e76b63e0100a..e8930e994e91a 100644
--- a/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
+++ b/arch/riscv/boot/dts/thead/th1520-lichee-module-4a.dtsi
@@ -47,22 +47,25 @@ &emmc {
non-removable;
no-sdio;
no-sd;
+
status = "okay";
};
&gmac0 {
- pinctrl-names = "default";
pinctrl-0 = <&gmac0_pins>, <&mdio0_pins>;
+ pinctrl-names = "default";
phy-handle = <&phy0>;
phy-mode = "rgmii-id";
+
status = "okay";
};
&gmac1 {
- pinctrl-names = "default";
pinctrl-0 = <&gmac1_pins>;
+ pinctrl-names = "default";
phy-handle = <&phy1>;
phy-mode = "rgmii-id";
+
status = "okay";
};
@@ -111,21 +114,6 @@ phy1: ethernet-phy@2 {
&padctrl0_apsys {
gmac0_pins: gmac0-0 {
- tx-pins {
- pins = "GMAC0_TX_CLK",
- "GMAC0_TXEN",
- "GMAC0_TXD0",
- "GMAC0_TXD1",
- "GMAC0_TXD2",
- "GMAC0_TXD3";
- function = "gmac0";
- bias-disable;
- drive-strength = <25>;
- input-disable;
- input-schmitt-disable;
- slew-rate = <0>;
- };
-
rx-pins {
pins = "GMAC0_RX_CLK",
"GMAC0_RXDV",
@@ -140,24 +128,24 @@ rx-pins {
input-schmitt-disable;
slew-rate = <0>;
};
- };
- gmac1_pins: gmac1-0 {
tx-pins {
- pins = "GPIO2_18", /* GMAC1_TX_CLK */
- "GPIO2_20", /* GMAC1_TXEN */
- "GPIO2_21", /* GMAC1_TXD0 */
- "GPIO2_22", /* GMAC1_TXD1 */
- "GPIO2_23", /* GMAC1_TXD2 */
- "GPIO2_24"; /* GMAC1_TXD3 */
- function = "gmac1";
+ pins = "GMAC0_TX_CLK",
+ "GMAC0_TXEN",
+ "GMAC0_TXD0",
+ "GMAC0_TXD1",
+ "GMAC0_TXD2",
+ "GMAC0_TXD3";
+ function = "gmac0";
bias-disable;
drive-strength = <25>;
input-disable;
input-schmitt-disable;
slew-rate = <0>;
};
+ };
+ gmac1_pins: gmac1-0 {
rx-pins {
pins = "GPIO2_19", /* GMAC1_RX_CLK */
"GPIO2_25", /* GMAC1_RXDV */
@@ -172,6 +160,21 @@ rx-pins {
input-schmitt-disable;
slew-rate = <0>;
};
+
+ tx-pins {
+ pins = "GPIO2_18", /* GMAC1_TX_CLK */
+ "GPIO2_20", /* GMAC1_TXEN */
+ "GPIO2_21", /* GMAC1_TXD0 */
+ "GPIO2_22", /* GMAC1_TXD1 */
+ "GPIO2_23", /* GMAC1_TXD2 */
+ "GPIO2_24"; /* GMAC1_TXD3 */
+ function = "gmac1";
+ bias-disable;
+ drive-strength = <25>;
+ input-disable;
+ input-schmitt-disable;
+ slew-rate = <0>;
+ };
};
mdio0_pins: mdio0-0 {
@@ -200,5 +203,6 @@ mdio-pins {
&sdio0 {
bus-width = <4>;
max-frequency = <198000000>;
+
status = "okay";
};
--
2.43.0
next prev parent reply other threads:[~2026-10-02 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 13:43 [PATCH 0/4] riscv: dts: thead: Cleanup with dt-check-style Kanak Shilledar
2026-10-02 13:43 ` [PATCH 1/4] riscv: dts: thead: beaglev-ahead: " Kanak Shilledar
2026-10-02 13:43 ` [PATCH 2/4] riscv: dts: thead: th1520: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar [this message]
2026-10-02 13:43 ` [PATCH 4/4] riscv: dts: thead: th1520-lichee-pi-4a: " Kanak Shilledar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002-fix-dts-th1520-v1-3-9a8810091d47@axis.com \
--to=kanak.shilledar@axis.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fustini@kernel.org \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox