Re: [PATCH v2 10/21] arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dts: codec ti,tas5770l is unprobeable due to missing driver binding
- [Low] dts: duplicate &i2c2 node definition
--

commit 880aa6b0e6df0b9fa5a017a1a3c706d5c89c5508
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes

This commit adds speaker and headset jack nodes for the M1 Mac mini. It
integrates Apple-specific variants of the TI TAS2770 and Cirrus CS42L42 by
advertising them to the machine driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -75,4 +75,71 @@ &i2c2 {
>  	status = "okay";
>  };
>  
> +/* Audio codecs */
> +&i2c1 {
> +	status = "okay";
> +
> +	speaker: codec@31 {
> +		compatible = "ti,tas5770l";

[Severity: High]
Will this codec successfully probe? The intended codec driver's match table
in sound/soc/codecs/tas2770.c does not appear to include this compatible
string:

sound/soc/codecs/tas2770.c:tas2770_of_match[] {
	{ .compatible = "ti,tas2770" },
	{},
};

Without a matching driver binding or a generic fallback string like
"ti,tas2770" in the DTS, the kernel's I2C core and OF matching will fail
to bind a driver. Does this leave the codec component permanently in
deferred probe and prevent the sound card from initializing?

> +		reg = <0x31>;
> +		interrupts-extended = <&pinctrl_ap 182 IRQ_TYPE_LEVEL_LOW>;

[ ... ]

> +	};
> +};
> +
> +&i2c2 {

[Severity: Low]
Does this file already have an &i2c2 node defined right above this hunk?
While the Device Tree Compiler safely merges duplicate nodes into a single
block during compilation, is it preferred to nest the new jack_codec node
inside the existing &i2c2 block to avoid redundant top-level references?

> +	status = "okay";
> +
> +	jack_codec: codec@48 {
> +		compatible = "cirrus,cs42l83";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-macaudio-v2-0-7b47ed6335a8@gmail.com?part=10