Re: [PATCH v2 12/21] arm64: dts: apple: t8103-j293: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: apple: missing driver binding for ti,tas5770l codec
--

commit e9c4bfa294ab34a3256cffd555e149932dd05469
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j293: Add speaker/headset jack nodes

The M1 MacBook Pro integrates Apple-specific variants of the TI TAS2770
and Cirrus CS42L42. Add these nodes and advertise them to the machine
driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 1d074b9e60183..42f1127151fa7 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
[ ... ]
> @@ -133,5 +133,116 @@ &displaydfr_dart {
>  	status = "okay";
>  };
>  
> +/* Audio codecs */
> +&i2c1 {
> +	status = "okay";
> +
> +	speaker_left_rear: codec@31 {
> +		compatible = "ti,tas5770l";

[Severity: Medium]
Will this device node successfully bind to a driver?

This declares a compatible string that lacks driver support in the kernel,
and has no fallback. Looking at the codec driver's OF match table in
sound/soc/codecs/tas2770.c:

static const struct of_device_id tas2770_of_match[] = {
	{ .compatible = "ti,tas2770" },
	{},
};

The match table does not include ti,tas5770l, causing binding to fail. As a
result, the ASoC sound card apple,j293-macaudio will indefinitely defer
probing because no codec driver binds to the ti,tas5770l I2C devices,
leaving the machine without sound.

Could the codec driver be updated to match this compatible string, or
should a fallback compatible string be added here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-macaudio-v2-0-7b47ed6335a8@gmail.com?part=12