Re: [PATCH v2 18/21] arm64: dts: apple: t600x-j31x: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: resource conflict on shared shutdown-gpios for multiple codecs
--

commit 9045c7a2c2a0f6174f098238d3400d7d5ed2d1f8
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t600x-j31x: Add speaker/headset jack nodes

The M1 Pro/Max MacBooks integrate Apple-specific variants of the TI TAS2764
and Cirrus CS42L42. Add these nodes and advertise them to the machine
driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
> index caded1636f3d2..1f23ae3e4e1ad 100644
> --- a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi

[ ... ]

> @@ -169,6 +169,94 @@ hpm5: usb-pd@3a {
>  	};
>  };
>  
> +/* Audio codecs */
> +&i2c1 {
> +	status = "okay";
> +
> +	speaker_left_woof1: codec@38 {
> +		compatible = "ti,sn012776";
> +		reg = <0x38>;
> +		interrupts-extended = <&pinctrl_ap 179 IRQ_TYPE_LEVEL_LOW>;
> +		shutdown-gpios = <&pinctrl_ap 178 GPIO_ACTIVE_HIGH>;

[Severity: High]
Does sharing the shutdown-gpios line identically across all six codec nodes
cause a resource conflict during probe?

When probing the ti,sn012776 codecs, the tas2764 driver uses an exclusive
request for shutdown-gpios. The first codec successfully acquires the GPIO,
but the remaining five codecs will receive an -EBUSY error. They silently
ignore the error, set their GPIO descriptor to NULL, and continue.

If the system or audio card later suspends, the first probed codec will
unilaterally assert the shared shutdown-gpios line. This physically powers
down the remaining active codecs while they are still awaiting their own
suspend sequence.

Will the subsequent I2C writes during the suspend callbacks of those powered
down codecs fail due to NACK timeouts, potentially delaying or aborting the
entire system suspend process?

> +		#sound-dai-cells = <0>;
> +		sound-name-prefix = "Left Woofer 1";
> +		ti,imon-slot-no = <0>;
> +		ti,vmon-slot-no = <2>;
> +	};
> +
> +	speaker_left_woof2: codec@39 {
> +		compatible = "ti,sn012776";
> +		reg = <0x39>;
> +		interrupts-extended = <&pinctrl_ap 179 IRQ_TYPE_LEVEL_LOW>;
> +		shutdown-gpios = <&pinctrl_ap 178 GPIO_ACTIVE_HIGH>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004-macaudio-v2-0-7b47ed6335a8@gmail.com?part=18