Devicetree
 help / color / mirror / Atom feed
From: Andreas Kemnade <andreas@kemnade.info>
To: Ettore Chimenti <ettore.chimenti@linaro.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Christopher Obbard <chris.obbard@oss.qualcomm.com>,
	Andrew Goodbody <andrew.goodbody@linaro.org>,
	Paul Walmsley <paul@pwsan.com>,
	Russell King <linux@armlinux.org.uk>,
	Rouven Czerwinski <rouven.czerwinski@linaro.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/9] ARM: dts: omap: dm816x: Correct speed for sysclk5
Date: Sun, 1 Nov 2026 22:29:42 +0100	[thread overview]
Message-ID: <20261101222942.1a78c6fb@kemnade.info> (raw)
In-Reply-To: <20261028-patch-ektor5-dm8168-dts-v2-5-4544429251e2@linaro.org>

On Wed, 28 Oct 2026 17:06:06 +0100
Ettore Chimenti <ettore.chimenti@linaro.org> wrote:

> From: Andrew Goodbody <andrew.goodbody@linaro.org>
> 
> The default code for setting up the clocks results in sysclk5 running at
> 1.6GHz whereas it is expected to run at half that ie 813MHz. Force the
> divider to be /2 to achieve the 813MHz speed.
> 
> Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
> Signed-off-by: Ettore Chimenti <ettore.chimenti@linaro.org>
> ---
>  arch/arm/boot/dts/ti/omap/dm816x-clocks.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/dm816x-clocks.dtsi b/arch/arm/boot/dts/ti/omap/dm816x-clocks.dtsi
> index 76ebc6c3c3e5..cb990773b098 100644
> --- a/arch/arm/boot/dts/ti/omap/dm816x-clocks.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dm816x-clocks.dtsi
> @@ -144,7 +144,7 @@ sysclk5_ck: sysclk5_ck@310 {
>  		#clock-cells = <0>;
>  		compatible = "ti,divider-clock";
>  		clocks = <&sysclk4_ck>;
> -		ti,max-div = <1>;
> +		ti,dividers = <2>;

so this changes register value  0 is intepreted as divider 1
to divider 2. Sounds strange. It just changes the interpretation of the
register values, not the setting. Maybe checkout the register value from
user space with tools like devmem. The original interpretation was right.
So this change does not make any sense. I think sysclk5 still runs at
1.6Ghz, but it is displayed as 813Mhz.

I would expect some assigned-clocks / assigned-clock-rates pair somewhere
in this patch instead.

Regards,
Andreas

  reply	other threads:[~2026-11-01 21:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 16:06 [PATCH v2 0/9] ARM: dts: omap: dm816x: fixes and peripheral updates for DM8168 SoC Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 1/9] ARM: dts: omap: dm816x: Add specific pinctrl config defines Ettore Chimenti
2026-10-30 10:31   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 2/9] ARM: dts: omap: dm816x: use dedicated SoC pinctrl Ettore Chimenti
2026-10-30 10:34   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 3/9] ARM: dts: omap: dm816x: Fix pinctrl range Ettore Chimenti
2026-11-01 21:18   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 4/9] ARM: dts: omap: dm816x: refactor and align MMC node Ettore Chimenti
2026-10-30 10:30   ` Andreas Kemnade
2026-10-30 17:53     ` Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 5/9] ARM: dts: omap: dm816x: Correct speed for sysclk5 Ettore Chimenti
2026-11-01 21:29   ` Andreas Kemnade [this message]
2026-11-02 19:44     ` Ettore Chimenti
2026-10-28 16:06 ` [PATCH v2 6/9] ARM: dts: omap: dm816x: Update USB node Ettore Chimenti
2026-10-28 16:19   ` sashiko-bot
2026-10-28 16:06 ` [PATCH v2 7/9] ARM: dts: omap: dm816x: Remove hwmod code for USB Ettore Chimenti
2026-10-30 12:07   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 8/9] ARM: dts: omap: dm8168-evm: Correct SD card pinmux Ettore Chimenti
2026-11-01 21:31   ` Andreas Kemnade
2026-10-28 16:06 ` [PATCH v2 9/9] ARM: dts: omap: dm8168-evm: enable MUSB multipoint support Ettore Chimenti
2026-11-01 21:34   ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261101222942.1a78c6fb@kemnade.info \
    --to=andreas@kemnade.info \
    --cc=aaro.koskinen@iki.fi \
    --cc=andrew.goodbody@linaro.org \
    --cc=chris.obbard@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ettore.chimenti@linaro.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=paul@pwsan.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=rouven.czerwinski@linaro.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox