* [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
@ 2026-11-05 14:49 Rob Herring (Arm)
2026-11-05 14:59 ` sashiko-bot
2026-11-05 15:00 ` Marco Felsch
0 siblings, 2 replies; 9+ messages in thread
From: Rob Herring (Arm) @ 2026-11-05 14:49 UTC (permalink / raw)
To: Marco Felsch, Krzysztof Kozlowski, Conor Dooley, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel
These .dtsi files are not included anywhere in the tree and can't be
tested.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
- Rebased
It's been nearly a year and these are still orphans. There was a promise
to upstream something for the kontron ones, but that hasn't happened.
.../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 -----
.../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 -----
.../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ----------------
.../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 -------------------
4 files changed, 123 deletions(-)
delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
deleted file mode 100644
index 5a9b819d7ee8..000000000000
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
+++ /dev/null
@@ -1,12 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0 OR X11
-/*
- * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
- */
-
-#include "imx6dl.dtsi"
-#include "imx6qdl-kontron-samx6i.dtsi"
-
-/ {
- model = "Kontron SMARC-sAMX6i Dual-Lite/Solo";
- compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl";
-};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
deleted file mode 100644
index e76963436079..000000000000
--- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
+++ /dev/null
@@ -1,12 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0 OR X11
-/*
- * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
- */
-
-#include "imx6q.dtsi"
-#include "imx6qdl-kontron-samx6i.dtsi"
-
-/ {
- model = "Kontron SMARC-sAMX6i Quad/Dual";
- compatible = "kontron,imx6q-samx6i", "fsl,imx6q";
-};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
deleted file mode 100644
index 3a968782e854..000000000000
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
+++ /dev/null
@@ -1,45 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+ OR MIT
-//
-// Copyright 2017 NXP
-
-#include "imx6qdl-pico.dtsi"
-
-/ {
- leds {
- compatible = "gpio-leds";
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_gpio_leds>;
-
- led {
- label = "gpio-led";
- gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>;
- };
- };
-
-};
-
-&i2c1 {
- mpl3115@60 {
- compatible = "fsl,mpl3115";
- reg = <0x60>;
- };
-};
-
-&i2c2 {
- io-expander@25 {
- compatible = "nxp,pca9554";
- reg = <0x25>;
- gpio-controller;
- #gpio-cells = <2>;
- #interrupt-cells = <2>;
- };
-
-};
-
-&iomuxc {
- pinctrl_gpio_leds: gpioledsgrp {
- fsl,pins = <
- MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0
- >;
- };
-};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
deleted file mode 100644
index 3d56a4216448..000000000000
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
+++ /dev/null
@@ -1,54 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+ OR MIT
-
-#include "imx6qdl-pico.dtsi"
-
-/ {
- leds {
- compatible = "gpio-leds";
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_gpio_leds>;
-
- led {
- label = "gpio-led";
- gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>;
- };
- };
-
-};
-
-&i2c1 {
- adc@52 {
- compatible = "ti,adc081c";
- reg = <0x52>;
- vref-supply = <®_2p5v>;
- };
-};
-
-&i2c2 {
- io-expander@25 {
- compatible = "nxp,pca9554";
- reg = <0x25>;
- gpio-controller;
- #gpio-cells = <2>;
- #interrupt-cells = <2>;
- };
-};
-
-&i2c3 {
- rtc@68 {
- compatible = "dallas,ds1337";
- reg = <0x68>;
- };
-};
-
-&pcie {
- status = "okay";
-};
-
-&iomuxc {
- pinctrl_gpio_leds: gpioledsgrp {
- fsl,pins = <
- MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0
- >;
- };
-};
--
2.53.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 14:49 [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi Rob Herring (Arm)
@ 2026-11-05 14:59 ` sashiko-bot
2026-11-05 15:04 ` Rob Herring
2026-11-05 15:00 ` Marco Felsch
1 sibling, 1 reply; 9+ messages in thread
From: sashiko-bot @ 2026-11-05 14:59 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: devicetree, imx, conor+dt, Frank.Li
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ARM: dts: imx6: Deleting Dwarf and Nymph .dtsi omitted by copy-paste in .dts
--
commit 22f4920daa7995325841819b6b25c37d2efd2b30
Author: Rob Herring (Arm) <robh@kernel.org>
ARM: dts: nxp/imx6: Drop unused .dtsi
This commit removes four i.MX6 device tree include files that are not
currently included by any in-tree device tree sources.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> deleted file mode 100644
> index 3a968782e854b..0000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -//
> -// Copyright 2017 NXP
> -
> -#include "imx6qdl-pico.dtsi"
[ ... ]
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> deleted file mode 100644
> index 3d56a42164482..0000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -
> -#include "imx6qdl-pico.dtsi"
[Severity: Medium]
Should imx6qdl-pico-dwarf.dtsi and imx6qdl-pico-nymph.dtsi be wired up to
their existing board device trees instead of being deleted?
Unlike the Kontron files, the corresponding board files for Dwarf and Nymph
already exist in the tree and are built by arch/arm/boot/dts/nxp/imx/Makefile
(imx6dl-pico-dwarf.dts, imx6q-pico-dwarf.dts, imx6dl-pico-nymph.dts, and
imx6q-pico-nymph.dts).
When commit 98670a0bb0ef ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
added support for the Dwarf, Hobbit, Nymph, and Pi baseboards, a copy-paste
error left the Dwarf and Nymph .dts files including imx6qdl-pico-pi.dtsi:
arch/arm/boot/dts/nxp/imx/imx6dl-pico-dwarf.dts:
#include "imx6dl.dtsi"
#include "imx6qdl-pico-pi.dtsi"
/ {
model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";
};
arch/arm/boot/dts/nxp/imx/imx6dl-pico-nymph.dts:
#include "imx6dl.dtsi"
#include "imx6qdl-pico-pi.dtsi"
/ {
model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
};
(and similarly in imx6q-pico-dwarf.dts and imx6q-pico-nymph.dts).
As a result, the Dwarf and Nymph board DTBs are currently built with the Pi
baseboard description (which disables HDMI and routes the LED to GPIO5_IO18)
rather than their own baseboard descriptions in imx6qdl-pico-dwarf.dtsi
(GPIO5_IO31 LED, mpl3115@60 on i2c1, and pca9554 io-expander@25 on i2c2) and
imx6qdl-pico-nymph.dtsi (GPIO5_IO31 LED, adc@52 on i2c1, pca9554
io-expander@25 on i2c2, ds1337 rtc@68 on i2c3, and PCIe enabled).
Would it make sense to keep imx6qdl-pico-dwarf.dtsi and
imx6qdl-pico-nymph.dtsi and update the four Dwarf and Nymph .dts files to
include them?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105144920.2796623-2-robh@kernel.org?part=1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 14:59 ` sashiko-bot
@ 2026-11-05 15:04 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2026-11-05 15:04 UTC (permalink / raw)
To: sashiko-reviews; +Cc: devicetree, imx, conor+dt, Frank.Li
On Thu, Nov 5, 2026 at 8:59 AM <sashiko-bot@kernel.org> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] ARM: dts: imx6: Deleting Dwarf and Nymph .dtsi omitted by copy-paste in .dts
> --
>
> commit 22f4920daa7995325841819b6b25c37d2efd2b30
> Author: Rob Herring (Arm) <robh@kernel.org>
>
> ARM: dts: nxp/imx6: Drop unused .dtsi
>
> This commit removes four i.MX6 device tree include files that are not
> currently included by any in-tree device tree sources.
>
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> > deleted file mode 100644
> > index 3a968782e854b..0000000000000
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> > +++ /dev/null
> > @@ -1,45 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> > -//
> > -// Copyright 2017 NXP
> > -
> > -#include "imx6qdl-pico.dtsi"
>
> [ ... ]
>
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> > deleted file mode 100644
> > index 3d56a42164482..0000000000000
> > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> > +++ /dev/null
> > @@ -1,54 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> > -
> > -#include "imx6qdl-pico.dtsi"
>
> [Severity: Medium]
> Should imx6qdl-pico-dwarf.dtsi and imx6qdl-pico-nymph.dtsi be wired up to
> their existing board device trees instead of being deleted?
>
> Unlike the Kontron files, the corresponding board files for Dwarf and Nymph
> already exist in the tree and are built by arch/arm/boot/dts/nxp/imx/Makefile
> (imx6dl-pico-dwarf.dts, imx6q-pico-dwarf.dts, imx6dl-pico-nymph.dts, and
> imx6q-pico-nymph.dts).
>
> When commit 98670a0bb0ef ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
> added support for the Dwarf, Hobbit, Nymph, and Pi baseboards, a copy-paste
> error left the Dwarf and Nymph .dts files including imx6qdl-pico-pi.dtsi:
>
> arch/arm/boot/dts/nxp/imx/imx6dl-pico-dwarf.dts:
> #include "imx6dl.dtsi"
> #include "imx6qdl-pico-pi.dtsi"
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Dwarf baseboard";
> compatible = "technexion,imx6dl-pico-dwarf", "fsl,imx6dl";
> };
>
> arch/arm/boot/dts/nxp/imx/imx6dl-pico-nymph.dts:
> #include "imx6dl.dtsi"
> #include "imx6qdl-pico-pi.dtsi"
>
> / {
> model = "TechNexion PICO-IMX6 DualLite/Solo Board and Nymph baseboard";
> compatible = "technexion,imx6dl-pico-nymph", "fsl,imx6dl";
> };
>
> (and similarly in imx6q-pico-dwarf.dts and imx6q-pico-nymph.dts).
>
> As a result, the Dwarf and Nymph board DTBs are currently built with the Pi
> baseboard description (which disables HDMI and routes the LED to GPIO5_IO18)
> rather than their own baseboard descriptions in imx6qdl-pico-dwarf.dtsi
> (GPIO5_IO31 LED, mpl3115@60 on i2c1, and pca9554 io-expander@25 on i2c2) and
> imx6qdl-pico-nymph.dtsi (GPIO5_IO31 LED, adc@52 on i2c1, pca9554
> io-expander@25 on i2c2, ds1337 rtc@68 on i2c3, and PCIe enabled).
>
> Would it make sense to keep imx6qdl-pico-dwarf.dtsi and
> imx6qdl-pico-nymph.dtsi and update the four Dwarf and Nymph .dts files to
> include them?
Seems like the correct analysis. If someone cares about those
platforms, then they can send a fix. If not, we should delete them
too.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 14:49 [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi Rob Herring (Arm)
2026-11-05 14:59 ` sashiko-bot
@ 2026-11-05 15:00 ` Marco Felsch
2026-11-05 15:06 ` Rob Herring
1 sibling, 1 reply; 9+ messages in thread
From: Marco Felsch @ 2026-11-05 15:00 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-kernel
On 26-11-05 08:49, Rob Herring (Arm) wrote:
> These .dtsi files are not included anywhere in the tree and can't be
> tested.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> v2:
> - Rebased
>
> It's been nearly a year and these are still orphans. There was a promise
> to upstream something for the kontron ones, but that hasn't happened.
That's unfortunate, but these includes are used at least by the barebox
bootloader [1,2], dropping these would cause a DT regresssion.
Would it help to upstream [1,2]?
Regards,
Marco
[1] https://elixir.bootlin.com/barebox/v2026.10.0/source/arch/arm/dts/imx6dl-samx6i.dts#L8
[2] https://elixir.bootlin.com/barebox/v2026.10.0/source/arch/arm/dts/imx6q-samx6i.dts#L8
>
> .../dts/nxp/imx/imx6dl-kontron-samx6i.dtsi | 12 -----
> .../dts/nxp/imx/imx6q-kontron-samx6i.dtsi | 12 -----
> .../boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi | 45 ----------------
> .../boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi | 54 -------------------
> 4 files changed, 123 deletions(-)
> delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> delete mode 100644 arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> deleted file mode 100644
> index 5a9b819d7ee8..000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i.dtsi
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0 OR X11
> -/*
> - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
> - */
> -
> -#include "imx6dl.dtsi"
> -#include "imx6qdl-kontron-samx6i.dtsi"
> -
> -/ {
> - model = "Kontron SMARC-sAMX6i Dual-Lite/Solo";
> - compatible = "kontron,imx6dl-samx6i", "fsl,imx6dl";
> -};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> deleted file mode 100644
> index e76963436079..000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i.dtsi
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0 OR X11
> -/*
> - * Copyright 2019 (C) Pengutronix, Marco Felsch <kernel@pengutronix.de>
> - */
> -
> -#include "imx6q.dtsi"
> -#include "imx6qdl-kontron-samx6i.dtsi"
> -
> -/ {
> - model = "Kontron SMARC-sAMX6i Quad/Dual";
> - compatible = "kontron,imx6q-samx6i", "fsl,imx6q";
> -};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> deleted file mode 100644
> index 3a968782e854..000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-dwarf.dtsi
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -//
> -// Copyright 2017 NXP
> -
> -#include "imx6qdl-pico.dtsi"
> -
> -/ {
> - leds {
> - compatible = "gpio-leds";
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_gpio_leds>;
> -
> - led {
> - label = "gpio-led";
> - gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> - };
> - };
> -
> -};
> -
> -&i2c1 {
> - mpl3115@60 {
> - compatible = "fsl,mpl3115";
> - reg = <0x60>;
> - };
> -};
> -
> -&i2c2 {
> - io-expander@25 {
> - compatible = "nxp,pca9554";
> - reg = <0x25>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - #interrupt-cells = <2>;
> - };
> -
> -};
> -
> -&iomuxc {
> - pinctrl_gpio_leds: gpioledsgrp {
> - fsl,pins = <
> - MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0
> - >;
> - };
> -};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> deleted file mode 100644
> index 3d56a4216448..000000000000
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-pico-nymph.dtsi
> +++ /dev/null
> @@ -1,54 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+ OR MIT
> -
> -#include "imx6qdl-pico.dtsi"
> -
> -/ {
> - leds {
> - compatible = "gpio-leds";
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_gpio_leds>;
> -
> - led {
> - label = "gpio-led";
> - gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> - };
> - };
> -
> -};
> -
> -&i2c1 {
> - adc@52 {
> - compatible = "ti,adc081c";
> - reg = <0x52>;
> - vref-supply = <®_2p5v>;
> - };
> -};
> -
> -&i2c2 {
> - io-expander@25 {
> - compatible = "nxp,pca9554";
> - reg = <0x25>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - #interrupt-cells = <2>;
> - };
> -};
> -
> -&i2c3 {
> - rtc@68 {
> - compatible = "dallas,ds1337";
> - reg = <0x68>;
> - };
> -};
> -
> -&pcie {
> - status = "okay";
> -};
> -
> -&iomuxc {
> - pinctrl_gpio_leds: gpioledsgrp {
> - fsl,pins = <
> - MX6QDL_PAD_CSI0_DAT13__GPIO5_IO31 0x1b0b0
> - >;
> - };
> -};
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 15:00 ` Marco Felsch
@ 2026-11-05 15:06 ` Rob Herring
2026-11-05 15:09 ` Marco Felsch
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2026-11-05 15:06 UTC (permalink / raw)
To: Marco Felsch
Cc: Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-kernel
On Thu, Nov 5, 2026 at 9:00 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> On 26-11-05 08:49, Rob Herring (Arm) wrote:
> > These .dtsi files are not included anywhere in the tree and can't be
> > tested.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > v2:
> > - Rebased
> >
> > It's been nearly a year and these are still orphans. There was a promise
> > to upstream something for the kontron ones, but that hasn't happened.
>
> That's unfortunate, but these includes are used at least by the barebox
> bootloader [1,2], dropping these would cause a DT regresssion.
>
> Would it help to upstream [1,2]?
You said you were going to do that on v1:
>> I will add the som.dts, please don't remove the kontron dtsi files yet.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 15:06 ` Rob Herring
@ 2026-11-05 15:09 ` Marco Felsch
2026-11-05 15:35 ` Marco Felsch
0 siblings, 1 reply; 9+ messages in thread
From: Marco Felsch @ 2026-11-05 15:09 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, imx,
linux-arm-kernel, linux-kernel
On 26-11-05 09:06, Rob Herring wrote:
> On Thu, Nov 5, 2026 at 9:00 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> >
> > On 26-11-05 08:49, Rob Herring (Arm) wrote:
> > > These .dtsi files are not included anywhere in the tree and can't be
> > > tested.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > ---
> > > v2:
> > > - Rebased
> > >
> > > It's been nearly a year and these are still orphans. There was a promise
> > > to upstream something for the kontron ones, but that hasn't happened.
> >
> > That's unfortunate, but these includes are used at least by the barebox
> > bootloader [1,2], dropping these would cause a DT regresssion.
> >
> > Would it help to upstream [1,2]?
>
> You said you were going to do that on v1:
Unfortunate no Kontron dev was chiming in. Will do it now!
Regards,
Marco
>
> >> I will add the som.dts, please don't remove the kontron dtsi files yet.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 15:09 ` Marco Felsch
@ 2026-11-05 15:35 ` Marco Felsch
2026-11-05 16:41 ` Frank Li
0 siblings, 1 reply; 9+ messages in thread
From: Marco Felsch @ 2026-11-05 15:35 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Conor Dooley, imx, Sascha Hauer, Frank Li,
linux-kernel, Pengutronix Kernel Team, Krzysztof Kozlowski,
Fabio Estevam, linux-arm-kernel
On 26-11-05 16:09, Marco Felsch wrote:
> On 26-11-05 09:06, Rob Herring wrote:
> > On Thu, Nov 5, 2026 at 9:00 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> > >
> > > On 26-11-05 08:49, Rob Herring (Arm) wrote:
> > > > These .dtsi files are not included anywhere in the tree and can't be
> > > > tested.
> > > >
> > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > > ---
> > > > v2:
> > > > - Rebased
> > > >
> > > > It's been nearly a year and these are still orphans. There was a promise
> > > > to upstream something for the kontron ones, but that hasn't happened.
> > >
> > > That's unfortunate, but these includes are used at least by the barebox
> > > bootloader [1,2], dropping these would cause a DT regresssion.
> > >
> > > Would it help to upstream [1,2]?
> >
> > You said you were going to do that on v1:
>
> Unfortunate no Kontron dev was chiming in. Will do it now!
Okay, after checking the current linux source tree I noticed that
Kontron did upstream the carrier board .dts files but in a different
manner:
* arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i-ads2.dts
* arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i-ads2.dts
This means that barebox would need to adapt the includes. Can you please
mention that the .dtsi are not used by linux mainline and instead a
different approach was used?
Regards,
Marco
>
> Regards,
> Marco
>
> >
> > >> I will add the som.dts, please don't remove the kontron dtsi files yet.
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 15:35 ` Marco Felsch
@ 2026-11-05 16:41 ` Frank Li
2026-11-05 17:32 ` Marco Felsch
0 siblings, 1 reply; 9+ messages in thread
From: Frank Li @ 2026-11-05 16:41 UTC (permalink / raw)
To: Marco Felsch
Cc: Rob Herring, devicetree, Conor Dooley, imx, Sascha Hauer,
Frank Li, linux-kernel, Pengutronix Kernel Team,
Krzysztof Kozlowski, Fabio Estevam, linux-arm-kernel
On Thu, Nov 05, 2026 at 04:35:11PM +0100, Marco Felsch wrote:
> On 26-11-05 16:09, Marco Felsch wrote:
> > On 26-11-05 09:06, Rob Herring wrote:
> > > On Thu, Nov 5, 2026 at 9:00 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> > > >
> > > > On 26-11-05 08:49, Rob Herring (Arm) wrote:
> > > > > These .dtsi files are not included anywhere in the tree and can't be
> > > > > tested.
> > > > >
> > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > > > ---
> > > > > v2:
> > > > > - Rebased
> > > > >
> > > > > It's been nearly a year and these are still orphans. There was a promise
> > > > > to upstream something for the kontron ones, but that hasn't happened.
> > > >
> > > > That's unfortunate, but these includes are used at least by the barebox
> > > > bootloader [1,2], dropping these would cause a DT regresssion.
> > > >
> > > > Would it help to upstream [1,2]?
> > >
> > > You said you were going to do that on v1:
> >
> > Unfortunate no Kontron dev was chiming in. Will do it now!
>
> Okay, after checking the current linux source tree I noticed that
> Kontron did upstream the carrier board .dts files but in a different
> manner:
>
> * arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i-ads2.dts
> * arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i-ads2.dts
>
> This means that barebox would need to adapt the includes. Can you please
> mention that the .dtsi are not used by linux mainline and instead a
> different approach was used?
So, Is it okay to pick this patch?
Frank
>
> Regards,
> Marco
>
>
> >
> > Regards,
> > Marco
> >
> > >
> > > >> I will add the som.dts, please don't remove the kontron dtsi files yet.
> >
> >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi
2026-11-05 16:41 ` Frank Li
@ 2026-11-05 17:32 ` Marco Felsch
0 siblings, 0 replies; 9+ messages in thread
From: Marco Felsch @ 2026-11-05 17:32 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, devicetree, Conor Dooley, imx, Sascha Hauer,
Frank Li, linux-kernel, Pengutronix Kernel Team,
Krzysztof Kozlowski, Fabio Estevam, linux-arm-kernel
On 26-11-05 10:41, Frank Li wrote:
> On Thu, Nov 05, 2026 at 04:35:11PM +0100, Marco Felsch wrote:
> > On 26-11-05 16:09, Marco Felsch wrote:
> > > On 26-11-05 09:06, Rob Herring wrote:
> > > > On Thu, Nov 5, 2026 at 9:00 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
> > > > >
> > > > > On 26-11-05 08:49, Rob Herring (Arm) wrote:
> > > > > > These .dtsi files are not included anywhere in the tree and can't be
> > > > > > tested.
> > > > > >
> > > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > > > > ---
> > > > > > v2:
> > > > > > - Rebased
> > > > > >
> > > > > > It's been nearly a year and these are still orphans. There was a promise
> > > > > > to upstream something for the kontron ones, but that hasn't happened.
> > > > >
> > > > > That's unfortunate, but these includes are used at least by the barebox
> > > > > bootloader [1,2], dropping these would cause a DT regresssion.
> > > > >
> > > > > Would it help to upstream [1,2]?
> > > >
> > > > You said you were going to do that on v1:
> > >
> > > Unfortunate no Kontron dev was chiming in. Will do it now!
> >
> > Okay, after checking the current linux source tree I noticed that
> > Kontron did upstream the carrier board .dts files but in a different
> > manner:
> >
> > * arch/arm/boot/dts/nxp/imx/imx6dl-kontron-samx6i-ads2.dts
> > * arch/arm/boot/dts/nxp/imx/imx6q-kontron-samx6i-ads2.dts
> >
> > This means that barebox would need to adapt the includes. Can you please
> > mention that the .dtsi are not used by linux mainline and instead a
> > different approach was used?
>
> So, Is it okay to pick this patch?
Yes, if the commit message points out that the final linux devicetrees
did land in a different way. This helps the other projects to adapt
their devicetree ports.
Regards,
Marco
>
> Frank
>
> >
> > Regards,
> > Marco
> >
> >
> > >
> > > Regards,
> > > Marco
> > >
> > > >
> > > > >> I will add the som.dts, please don't remove the kontron dtsi files yet.
> > >
> > >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-11-05 17:32 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-05 14:49 [PATCH v2] ARM: dts: nxp/imx6: Drop unused .dtsi Rob Herring (Arm)
2026-11-05 14:59 ` sashiko-bot
2026-11-05 15:04 ` Rob Herring
2026-11-05 15:00 ` Marco Felsch
2026-11-05 15:06 ` Rob Herring
2026-11-05 15:09 ` Marco Felsch
2026-11-05 15:35 ` Marco Felsch
2026-11-05 16:41 ` Frank Li
2026-11-05 17:32 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox