Devicetree
 help / color / mirror / Atom feed
From: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>
To: neil.armstrong@linaro.org, jesszhan0024@gmail.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	u.kleine-koenig@baylibre.com,
	"Adil Hüsrev Tepe" <tadilhusrev@gmail.com>
Subject: [PATCH v4 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5)
Date: Fri, 20 Nov 2026 14:40:58 +0300	[thread overview]
Message-ID: <20261120114100.978148-1-tadilhusrev@gmail.com> (raw)
In-Reply-To: <20261116070212.314228-1-tadilhusrev@gmail.com>

This series adds a DRM panel driver and its DT binding for MIPI-DSI
video-mode panels based on the Novatek NT36525 controller, as fitted on
the Samsung Galaxy XCover5 (SM-G525F, Exynos850). The panel is 720x1480,
uses an active-low reset (RESX), and a DCS init sequence that mirrors
the stock Samsung bring-up. Backlight goes through drm_panel_of_backlight().

  Patch 1  dt-bindings (no change since v3)
  Patch 2  the panel driver

v4 addresses Uwe Kleine-König's v3 review comment: drop the unneeded
<linux/mod_devicetable.h> include (it is pulled in transitively; this
driver's of_device_id/MODULE_DEVICE_TABLE(of, ...) still build clean
without it).

Adding phone-devel@vger.kernel.org to Cc per Ivon Argel's suggestion
on the v3 thread, so the relevant ecosystem developers see it (not
adding Ivon's own address; he asked not to be personally Cc'd).

On Michael McAllister's offer to add Moto G10 (DJN NT36525B) support
on top of this series: happy to see a follow-up patch once this base
driver lands; I'll reply on-list separately rather than hold this
series on it.

Tested on a Samsung Galaxy XCover5 running 7.4-rc3 plus this series
(re-confirmed 2026-11-20, kernel 7.4.0-rc3-00023-gdcb8b91fb779+ #32,
after rebasing our local tree from 7.4.0-rc1 to the real 7.4-rc3 tag):
the DSI panel connector probes and reports "connected", debugfs
reports the reset gpio as ACTIVE LOW, and /sys/class/backlight/ is
present and readable. checkpatch.pl and dt_binding_check are clean
(bar the usual new-file MAINTAINERS note; the files are covered by
the DRM PANEL DRIVERS wildcards).

Based on v7.4-rc3.

Tool usage
----------
This series was developed during XCover5 mainline bring-up with the help
of an AI coding assistant (Claude Code, Anthropic). The assistant converted
the vendor init stream to mipi_dsi_dcs_write_seq_multi(), drafted the driver
skeleton and the DT binding, and drafted these changelogs. I reviewed every
line, validated the binding (dt_binding_check, yamllint), tested the driver
on hardware, and take full responsibility for the contribution.
Prompt summary: "convert the XCover5 NT36525 vendor panel init into a
mainline drm_panel driver plus DT binding; keep it checkpatch- and
dt_binding_check-clean; test on the device." Review comments are welcome
and I will answer them myself.

Adil Hüsrev Tepe (2):
  dt-bindings: display: panel: add Novatek NT36525
  drm/panel: add Novatek NT36525 panel driver

 .../display/panel/novatek,nt36525.yaml        |  83 +++
 drivers/gpu/drm/panel/Kconfig                 |  13 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-novatek-nt36525.c | 490 ++++++++++++++++++
 4 files changed, 587 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36525.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36525.c

--
2.53.0

  parent reply	other threads:[~2026-11-20 11:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  7:02 [PATCH v1 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-16  7:02 ` [PATCH v1 1/2] dt-bindings: display: panel: add Novatek NT36525 Adil Hüsrev Tepe
2026-11-16  7:14   ` sashiko-bot
2026-11-16  7:02 ` [PATCH v1 2/2] drm/panel: add Novatek NT36525 panel driver Adil Hüsrev Tepe
2026-11-16  7:22   ` sashiko-bot
2026-11-17 10:43 ` [PATCH v2 1/2] dt-bindings: display: panel: novatek,nt36525: fix v1 review issues Adil Hüsrev Tepe
2026-11-17 10:43   ` [PATCH v2 2/2] drm/panel: novatek-nt36525: " Adil Hüsrev Tepe
2026-11-17 10:47     ` Krzysztof Kozlowski
2026-11-17 17:33       ` Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 1/2] dt-bindings: display: panel: add Novatek NT36525 Adil Hüsrev Tepe
2026-11-17 17:33   ` [PATCH v3 2/2] drm/panel: add Novatek NT36525 panel driver Adil Hüsrev Tepe
2026-11-18  7:48     ` Uwe Kleine-König
2026-11-18 15:53   ` [PATCH v3 0/2] drm/panel: add Novatek NT36525 (Samsung Galaxy XCover5) Michael McAllister
2026-11-20 11:40 ` Adil Hüsrev Tepe [this message]
2026-11-20 11:40   ` [PATCH v4 1/2] dt-bindings: display: panel: add Novatek NT36525 Adil Hüsrev Tepe
2026-11-20 11:41   ` [PATCH v4 2/2] drm/panel: add Novatek NT36525 panel driver Adil Hüsrev Tepe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120114100.978148-1-tadilhusrev@gmail.com \
    --to=tadilhusrev@gmail.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox