Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <matti.vaittinen@linux.dev>
Cc: mazziesaccount@gmail.com, sashiko-reviews@lists.linux.dev,
	devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	open list <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111
Date: Sat, 21 Nov 2026 01:59:04 +0000	[thread overview]
Message-ID: <20261121015904.15215ca8@jic23-hlaptop> (raw)
In-Reply-To: <d2d8049d-7adc-4cfb-8e56-3af55c0abe8f@linux.dev>

On Fri, 20 Nov 2026 14:53:32 +0200
Matti Vaittinen <matti.vaittinen@linux.dev> wrote:

> On 20/11/2026 14:34, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issues to consider:
> > - [Low] iio: adc: rohm-bd79112: double semicolon in bd79112_probe()
> > - [Low] iio: adc: rohm-bd79112: unused BD79112_MAX_NUM_CHANNELS macro
> > --
> > 
> > commit d2b6757018d5ccee4c939ad0350d93a29d26239d
> > Author: Matti Vaittinen <mazziesaccount@gmail.com>
> > 
> > iio: adc: rohm-bd79112: Support ROHM BD79111
> > 
> > This commit adds support for the 16-channel ROHM BD79111 SAR ADC and GPIO
> > device to the rohm-bd79112 driver.
> >   
> >> diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c
> >> index 04084e88984a5..8bbb86098ff5a 100644
> >> --- a/drivers/iio/adc/rohm-bd79112.c
> >> +++ b/drivers/iio/adc/rohm-bd79112.c  
> > 
> > [ ... ]
> >   
> >> @@ -431,8 +458,17 @@ static const char * const bd79112_chan_names[] = {
> >>   	"AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B",	/* 28 - 31 */
> >>   };
> >>   
> >> +static const struct bd7911x_chip_data bd79111_chip_data = {
> >> +	.name = "bd79111",
> >> +	.chan_names = bd79111_chan_names,
> >> +	.num_max_channels = 16,
> >> +	.init_disable_gpios = bd79111_disable_gpios,
> >> +};
> >> +
> >>   static const struct bd7911x_chip_data bd79112_chip_data = {
> >> +	.name = "bd79112",
> >>   	.chan_names = bd79112_chan_names,
> >> +	.num_max_channels = 32,
> >>   	.init_disable_gpios = bd79112_disable_gpios,
> >>   };  
> > 
> > [Severity: Low]
> > This isn't a bug, but replacing the remaining uses of
> > BD79112_MAX_NUM_CHANNELS in bd79112_probe() with
> > data->cd->num_max_channels leaves the BD79112_MAX_NUM_CHANNELS macro
> > unused.
> > 
> > [ ... ]
> >   
> >> @@ -509,7 +545,7 @@ static int bd79112_probe(struct spi_device *spi)
> >>   		cs[i].datasheet_name = data->cd->chan_names[cs[i].channel];
> >>   
> >>   	iio_dev->info = &bd79112_info;
> >> -	iio_dev->name = "bd79112";
> >> +	iio_dev->name = data->cd->name;;
> >>   	iio_dev->modes = INDIO_DIRECT_MODE;  
> > 
> > [Severity: Low]
> > This isn't a bug, but there is a double semicolon at the end of this
> > assignment.
> >   
> 
> Both of the Sashiko's findings seem correct. However, I wonder why it 
> picked the device-tree folks and dropped IIO people? This particular 
> patch didn't have binding changes but driver changes. (Well I added 
> Jonathan + IIO-list here)

Currently we haven't opted in to received emails to linux-iio but
device tree folk have. There was some debate at LPC on what sashiko
should do when this happens but there isn't really a right answer.

If things ever quieten down I'll restart the discussion of whether
we should opt IIO in.  I'm personally in favour but want to here
if anyone has a strong counter argument.   I think we can manage
the false positives for newbies issue as they are getting smaller
all the time.


Jonathan

> 
> Yours,
>    -- Matti
> 


  reply	other threads:[~2026-11-21  1:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:26 [PATCH v2 0/3] Support ROHM BD79111 ADC/GPIO Matti Vaittinen
2026-11-20 12:27 ` [PATCH v2 1/3] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen
2026-11-20 17:39   ` Conor Dooley
2026-11-20 12:28 ` [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure Matti Vaittinen
2026-11-20 14:36   ` Andy Shevchenko
2026-11-20 12:28 ` [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:34   ` sashiko-bot
2026-11-20 12:53     ` Matti Vaittinen
2026-11-21  1:59       ` Jonathan Cameron [this message]
2026-11-20 14:44   ` Andy Shevchenko
2026-11-21  2:01     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121015904.15215ca8@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=matti.vaittinen@linux.dev \
    --cc=mazziesaccount@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox