* [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix
@ 2026-11-22 19:08 Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633 Gerard Marull-Paretas
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gerard Marull-Paretas @ 2026-11-22 19:08 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Frank Li, linux-iio,
devicetree, linux-kernel
The MMC5603 and MMC5633 are listed in trivial-devices.yaml, but boards
need to describe their supply and orientation. Patch 1 gives them a
binding of their own. These bindings are also used by PebbleOS, which
is where the need came from.
Patches 2 and 3 add the matching support to the driver. I have no board
running Linux with these sensors, so they are only compile tested (W=1);
feel free to take only patch 1 if you prefer.
Changes in v2:
- Cover the MMC5633 too, including its I3C connection (Jonathan)
- Add supply and mount matrix support to the driver (Jonathan)
- Drop the mention of the missing I/O supply (Jonathan)
v1: https://lore.kernel.org/all/20261122093412.71604-1-gerard@teslabs.com/
Gerard Marull-Paretas (3):
dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633
iio: magnetometer: mmc5633: Enable the VDD supply
iio: magnetometer: mmc5633: Add mount matrix support
.../iio/magnetometer/memsic,mmc5633.yaml | 61 +++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 4 --
drivers/iio/magnetometer/mmc5633.c | 28 +++++++++
3 files changed, 89 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/memsic,mmc5633.yaml
base-commit: c44104f3642da720164042623e4832836aefdd8e
--
2.45.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633
2026-11-22 19:08 [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix Gerard Marull-Paretas
@ 2026-11-22 19:08 ` Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 3/3] iio: magnetometer: mmc5633: Add mount matrix support Gerard Marull-Paretas
2 siblings, 0 replies; 4+ messages in thread
From: Gerard Marull-Paretas @ 2026-11-22 19:08 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Frank Li, linux-iio,
devicetree, linux-kernel
The MMC5603NJ and MMC5633NJL are listed in trivial-devices.yaml, which
allows no properties besides the register address and interrupts.
Boards need to describe how the sensor is oriented, and the supply it
runs from, which is often switched on wearables.
Give them a binding of their own, covering both the I2C and I3C
connections of the MMC5633NJL.
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
---
.../iio/magnetometer/memsic,mmc5633.yaml | 61 +++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 4 --
2 files changed, 61 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/memsic,mmc5633.yaml
diff --git a/Documentation/devicetree/bindings/iio/magnetometer/memsic,mmc5633.yaml b/Documentation/devicetree/bindings/iio/magnetometer/memsic,mmc5633.yaml
new file mode 100644
index 000000000000..423b8ecbb9e5
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/magnetometer/memsic,mmc5633.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/magnetometer/memsic,mmc5633.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MEMSIC MMC5603 and MMC5633 3-axis magnetic sensors
+
+maintainers:
+ - Gerard Marull-Paretas <gerard@teslabs.com>
+
+description:
+ The MMC5603NJ is connected over I2C, the MMC5633NJL over I2C or I3C.
+
+properties:
+ compatible:
+ enum:
+ - memsic,mmc5603
+ - memsic,mmc5633
+
+ reg:
+ maxItems: 1
+
+ vdd-supply: true
+
+ mount-matrix:
+ description: An optional 3x3 mounting rotation matrix.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ magnetometer@30 {
+ compatible = "memsic,mmc5603";
+ reg = <0x30>;
+ vdd-supply = <&vdd_1v8>;
+ mount-matrix = "-1", "0", "0",
+ "0", "1", "0",
+ "0", "0", "-1";
+ };
+ };
+
+ - |
+ i3c {
+ #address-cells = <3>;
+ #size-cells = <0>;
+
+ magnetometer@30,4a20000f000 {
+ compatible = "memsic,mmc5633";
+ reg = <0x30 0x4a2 0xf000>;
+ vdd-supply = <&vdd_1v8>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index a8b2b9deade4..523c205c0880 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -261,10 +261,6 @@ properties:
- meas,tsys01
# MEMSIC magnetometer
- memsic,mmc35240
- # MEMSIC 3-axis magnetometer
- - memsic,mmc5603
- # MEMSIC 3-axis magnetometer (Support I3C HDR)
- - memsic,mmc5633
# MEMSIC 3-axis accelerometer
- memsic,mxc4005
# MEMSIC 2-axis 8-bit digital accelerometer
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply
2026-11-22 19:08 [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633 Gerard Marull-Paretas
@ 2026-11-22 19:08 ` Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 3/3] iio: magnetometer: mmc5633: Add mount matrix support Gerard Marull-Paretas
2 siblings, 0 replies; 4+ messages in thread
From: Gerard Marull-Paretas @ 2026-11-22 19:08 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Frank Li, linux-iio,
devicetree, linux-kernel
Boards may switch the supply of the sensor, so get and enable it before
initialising the chip, and wait the 5 ms both parts need after VDD is
valid before they can be operated.
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
---
drivers/iio/magnetometer/mmc5633.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/magnetometer/mmc5633.c b/drivers/iio/magnetometer/mmc5633.c
index b651f01e1b5d..79015c7984de 100644
--- a/drivers/iio/magnetometer/mmc5633.c
+++ b/drivers/iio/magnetometer/mmc5633.c
@@ -27,6 +27,7 @@
#include <linux/mutex.h>
#include <linux/pm.h>
#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
#include <linux/time.h>
#include <linux/types.h>
#include <linux/unaligned.h>
@@ -64,6 +65,7 @@
#define MMC5633_CTRL1_BW_MASK GENMASK(1, 0)
#define MMC5633_WAIT_SET_RESET_US (1 * USEC_PER_MSEC)
+#define MMC5633_POWER_ON_US (5 * USEC_PER_MSEC)
#define MMC5633_HDR_CTRL0_MEAS_M 0x01
#define MMC5633_HDR_CTRL0_MEAS_T 0x03
@@ -472,6 +474,12 @@ static int mmc5633_common_probe(struct regmap *regmap, char *name,
if (ret)
return ret;
+ ret = devm_regulator_get_enable(dev, "vdd");
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to enable VDD regulator\n");
+
+ fsleep(MMC5633_POWER_ON_US);
+
indio_dev->info = &mmc5633_info;
indio_dev->name = name;
indio_dev->channels = mmc5633_channels;
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 3/3] iio: magnetometer: mmc5633: Add mount matrix support
2026-11-22 19:08 [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633 Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply Gerard Marull-Paretas
@ 2026-11-22 19:08 ` Gerard Marull-Paretas
2 siblings, 0 replies; 4+ messages in thread
From: Gerard Marull-Paretas @ 2026-11-22 19:08 UTC (permalink / raw)
To: Jonathan Cameron, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: David Lechner, Nuno Sá, Andy Shevchenko, Frank Li, linux-iio,
devicetree, linux-kernel
Read the mount matrix from the firmware and expose it, so that user
space can account for how the sensor is oriented on the board.
Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
---
drivers/iio/magnetometer/mmc5633.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/iio/magnetometer/mmc5633.c b/drivers/iio/magnetometer/mmc5633.c
index 79015c7984de..f9ecb3737cf6 100644
--- a/drivers/iio/magnetometer/mmc5633.c
+++ b/drivers/iio/magnetometer/mmc5633.c
@@ -83,6 +83,7 @@ struct mmc5633_data {
struct regmap *regmap;
struct i3c_device *i3cdev;
struct mutex mutex; /* protect to finish one whole measurement */
+ struct iio_mount_matrix orientation;
};
static int mmc5633_samp_freq[][2] = {
@@ -92,6 +93,20 @@ static int mmc5633_samp_freq[][2] = {
{ 6, 600000 },
};
+static const struct iio_mount_matrix *
+mmc5633_get_mount_matrix(const struct iio_dev *indio_dev,
+ const struct iio_chan_spec *chan)
+{
+ struct mmc5633_data *data = iio_priv(indio_dev);
+
+ return &data->orientation;
+}
+
+static const struct iio_chan_spec_ext_info mmc5633_ext_info[] = {
+ IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, mmc5633_get_mount_matrix),
+ { }
+};
+
#define MMC5633_CHANNEL(_axis) { \
.type = IIO_MAGN, \
.modified = 1, \
@@ -100,6 +115,7 @@ static int mmc5633_samp_freq[][2] = {
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \
BIT(IIO_CHAN_INFO_SCALE), \
+ .ext_info = mmc5633_ext_info, \
}
static const struct iio_chan_spec mmc5633_channels[] = {
@@ -480,6 +496,10 @@ static int mmc5633_common_probe(struct regmap *regmap, char *name,
fsleep(MMC5633_POWER_ON_US);
+ ret = iio_read_mount_matrix(dev, &data->orientation);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to read mount matrix\n");
+
indio_dev->info = &mmc5633_info;
indio_dev->name = name;
indio_dev->channels = mmc5633_channels;
--
2.45.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-22 19:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-22 19:08 [PATCH v2 0/3] iio: magnetometer: mmc5633: Binding, supply and mount matrix Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 1/3] dt-bindings: iio: magnetometer: Add MEMSIC MMC5603 and MMC5633 Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 2/3] iio: magnetometer: mmc5633: Enable the VDD supply Gerard Marull-Paretas
2026-11-22 19:08 ` [PATCH v2 3/3] iio: magnetometer: mmc5633: Add mount matrix support Gerard Marull-Paretas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox