From: "Heiko Stübner" <heiko@sntech.de>
To: Atish Patra <atishp@rivosinc.com>, linux-riscv@lists.infradead.org
Cc: "linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Atish Patra <atishp@atishpatra.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
DTML <devicetree@vger.kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh+dt@kernel.org>,
Anup Patel <anup@brainfault.org>
Subject: Re: [PATCH 1/2] RISC-V: Fix counter restart during overflow for RV32
Date: Thu, 12 May 2022 14:42:42 +0200 [thread overview]
Message-ID: <23274575.ouqheUzb2q@diego> (raw)
In-Reply-To: <CAAhSdy3mbGdK9LrLxZX0JL0mQxP5FrFUuneX1cQS2SABpO=7dw@mail.gmail.com>
Am Donnerstag, 12. Mai 2022, 06:44:12 CEST schrieb Anup Patel:
> On Thu, May 12, 2022 at 1:41 AM Atish Patra <atishp@rivosinc.com> wrote:
> >
> > Pass the upper half of the initial value of the counter correctly
> > for RV32.
> >
> > Fixes: 4905ec2fb7e6 ("RISC-V: Add sscofpmf extension support")
> >
> > Signed-off-by: Atish Patra <atishp@rivosinc.com>
> > ---
> > drivers/perf/riscv_pmu_sbi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c
> > index a1317a483512..24cea59612be 100644
> > --- a/drivers/perf/riscv_pmu_sbi.c
> > +++ b/drivers/perf/riscv_pmu_sbi.c
> > @@ -526,7 +526,7 @@ static inline void pmu_sbi_start_overflow_mask(struct riscv_pmu *pmu,
> > max_period = riscv_pmu_ctr_get_width_mask(event);
> > init_val = local64_read(&hwc->prev_count) & max_period;
> > sbi_ecall(SBI_EXT_PMU, SBI_EXT_PMU_COUNTER_START, idx, 1,
> > - flag, init_val, 0, 0);
> > + flag, init_val, init_val >> 32, 0);
>
> This should be under "#if __riscv_xlen == 32".
What's the difference between using CONFIG_32BIT
and checking the __riscv_xlen flag value?
CONFIG_32BIT seems to be a bit the more kernel'ish
way to do this, but it looks like most SBI parts check the
__riscv_xlen instead.
In any case, looking at the opensbi-side of the call,
this fix is abviously correct, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2022-05-12 12:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 20:11 [PATCH 1/2] RISC-V: Fix counter restart during overflow for RV32 Atish Patra
2022-05-11 20:11 ` [PATCH 2/2] RISC-V: Update user page mapping only once during start Atish Patra
2022-05-12 4:45 ` Anup Patel
2022-05-12 4:44 ` [PATCH 1/2] RISC-V: Fix counter restart during overflow for RV32 Anup Patel
2022-05-12 12:42 ` Heiko Stübner [this message]
2022-05-12 15:36 ` Anup Patel
2022-05-12 17:21 ` Atish Kumar Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23274575.ouqheUzb2q@diego \
--to=heiko@sntech.de \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=atishp@rivosinc.com \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox