From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Document Eliza LLCC block
Date: Wed, 6 May 2026 14:15:57 +0200 [thread overview]
Message-ID: <2920e0bc-3f60-49bf-969c-9c049b080703@kernel.org> (raw)
In-Reply-To: <486d6b30-8762-4f14-aa19-7c5497cba00f@oss.qualcomm.com>
On 06/05/2026 12:47, Konrad Dybcio wrote:
> On 5/6/26 11:56 AM, Krzysztof Kozlowski wrote:
>>>>> + then:
>>>>> + properties:
>>>>> + reg:
>>>>> + items:
>>>>> + - description: LLCC0 base register region
>>>>> + - description: LLCC2 base register region
>>>>
>>>> LLCC1?
>>>
>>> Unfortunately not
>>
>> Then let's just skip the names, because it will cause unnecessary
>> confusion when name is llcc1 (since it is the NEXT entry) but it points
>> to block called LLCC2 in the manual.
>
> I don't think skipping the names is a good idea, especially since if
> we keep them, we could teach the driver what channel the region actually
> corresponds to
You still can do it, because indices are fixed. Names are only helper
and makes that easier.
The problem looks to me purely doc-related, because this is logically
second channel, so LLCC1, just like qcom,sc7280-llcc or
qcom,sdm670-llcc. Does naming it as third channel (LLCC2) is relevant
for programming interface? Imagine driver taking LLCCx and using the 'x'
as offset?
I tried to find something in HPG but no luck.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-06 12:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:00 [PATCH 0/2] soc: qcom: llcc-qcom: Add support for Eliza and document bindings Abel Vesa
2026-05-04 10:00 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Document Eliza LLCC block Abel Vesa
2026-05-06 8:25 ` Krzysztof Kozlowski
2026-05-06 8:49 ` Konrad Dybcio
2026-05-06 9:56 ` Krzysztof Kozlowski
2026-05-06 10:47 ` Konrad Dybcio
2026-05-06 12:15 ` Krzysztof Kozlowski [this message]
2026-05-04 10:00 ` [PATCH 2/2] soc: qcom: llcc-qcom: Add support for Eliza Abel Vesa
2026-05-04 10:24 ` Konrad Dybcio
2026-05-04 10:39 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2920e0bc-3f60-49bf-969c-9c049b080703@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox