* [PATCH 0/2] Support ROHM BD79111 ADC/GPIO @ 2026-11-18 14:18 Matti Vaittinen 2026-11-18 14:19 ` [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen 2026-11-18 14:19 ` [PATCH 2/2] iio: adc: rohm-bd79112: " Matti Vaittinen 0 siblings, 2 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-18 14:18 UTC (permalink / raw) To: Matti Vaittinen, Matti Vaittinen, Matti Vaittinen Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 778 bytes --] Support ROHM BD79111 ADC/GPIO The ROHM BD79111 is a 12-bit, 16 channel SAR ADC / GPIO IC. Or, a "Signal Monitor Hub IC" as data-sheet describes it. The key difference compared to already supported BD79112 is the reduced number of channels (16, BD79112 had 32) and halved sampling rate (500 KSPS when BD79112 data-sheet stated 1 MSPS). Matti Vaittinen (2): dt-bindings: Support ROHM BD79111 iio: adc: rohm-bd79112: Support ROHM BD79111 .../bindings/iio/adc/rohm,bd79112.yaml | 72 +++++++---- drivers/iio/adc/Kconfig | 9 +- drivers/iio/adc/rohm-bd79112.c | 113 ++++++++++++++---- 3 files changed, 148 insertions(+), 46 deletions(-) base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4 -- 2.56.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 2026-11-18 14:18 [PATCH 0/2] Support ROHM BD79111 ADC/GPIO Matti Vaittinen @ 2026-11-18 14:19 ` Matti Vaittinen 2026-11-18 14:34 ` sashiko-bot 2026-11-18 17:37 ` Conor Dooley 2026-11-18 14:19 ` [PATCH 2/2] iio: adc: rohm-bd79112: " Matti Vaittinen 1 sibling, 2 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-18 14:19 UTC (permalink / raw) To: Matti Vaittinen, Matti Vaittinen, Matti Vaittinen Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 4096 bytes --] From: Matti Vaittinen <mazziesaccount@gmail.com> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, where pins can be configured to be either used as GPIO or ADC inputs. ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ sources. The main difference is amount of channels/GPIOs. The BD79112 has 32 pins for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI clock. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- Note, I had to change the 'root-level' additionalProperties: false to unevaluatedProperties: false in order to allow the properties in the new allOf: - if: ... section. It seems to me this is what a few other bindings in IIO do, but I suppose it makes this "less strict". Well, since I am terrible with writing bindings, I'd better point this out and ask if it's ok, or if there are better way(s) to handle this? --- .../bindings/iio/adc/rohm,bd79112.yaml | 72 +++++++++++++------ 1 file changed, 50 insertions(+), 22 deletions(-) diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml index aa8b07c3fac1..4f105124ee6f 100644 --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml @@ -4,18 +4,21 @@ $id: http://devicetree.org/schemas/iio/adc/rohm,bd79112.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: ROHM BD79112 ADC/GPO +title: ROHM BD79111 and BD79112 ADC/GPIO maintainers: - Matti Vaittinen <mazziesaccount@gmail.com> description: | - The ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. ADC input pins can be - also configured as general purpose inputs/outputs. SPI should use MODE 3. + The ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. The ROHM BD79111 is + a 12-bit, 16-channel, SAR ADC. ADC input pins can be also configured as + general purpose inputs/outputs. SPI should use MODE 3. properties: compatible: - const: rohm,bd79112 + enum: + - rohm,bd79111 + - rohm,bd79112 reg: maxItems: 1 @@ -37,23 +40,6 @@ properties: "#size-cells": const: 0 -patternProperties: - "^channel@([0-9]|[12][0-9]|3[01])$": - type: object - $ref: /schemas/iio/adc/adc.yaml# - description: Represents ADC channel. Omitted channels' inputs are GPIOs. - - properties: - reg: - description: AIN pin number - minimum: 0 - maximum: 31 - - required: - - reg - - additionalProperties: false - required: - compatible - reg @@ -62,7 +48,49 @@ required: - spi-cpha - spi-cpol -additionalProperties: false +unevaluatedProperties: false + +allOf: + - if: + properties: + compatible: + contains: + const: rohm,bd79112 + then: + patternProperties: + "^channel@([0-9]|[12][0-9]|3[01])$": + type: object + $ref: /schemas/iio/adc/adc.yaml# + description: Represents ADC channel. Omitted channels' inputs are GPIOs. + + properties: + reg: + description: AIN pin number + minimum: 0 + maximum: 31 + + required: + - reg + + additionalProperties: false + else: + # BD79111 has only 16 channels + patternProperties: + "^channel@([0-9]|1[0-5])$": + type: object + $ref: /schemas/iio/adc/adc.yaml# + description: Represents ADC channel. Omitted channels' inputs are GPIOs. + + properties: + reg: + description: AIN pin number + minimum: 0 + maximum: 15 + + required: + - reg + + additionalProperties: false examples: - | -- 2.56.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 2026-11-18 14:19 ` [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen @ 2026-11-18 14:34 ` sashiko-bot 2026-11-18 17:37 ` Conor Dooley 1 sibling, 0 replies; 10+ messages in thread From: sashiko-bot @ 2026-11-18 14:34 UTC (permalink / raw) To: Matti Vaittinen; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] dt-bindings: iio: adc: decimal instead of hex regex for channel nodes - [Low] dt-bindings: iio: adc: duplicate channel patternProperties inside allOf -- commit 1d2b4969234a59de95b2a054fda32ad7ef3510e0 Author: Matti Vaittinen <mazziesaccount@gmail.com> dt-bindings: iio: Support ROHM BD79111 This commit adds device tree binding support for the 16-channel ROHM BD79111 ADC/GPIO alongside the 32-channel BD79112. > diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml > index aa8b07c3fac10..4f105124ee6f6 100644 > --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml [ ... ] > @@ -37,23 +40,6 @@ properties: > "#size-cells": > const: 0 > > -patternProperties: > - "^channel@([0-9]|[12][0-9]|3[01])$": > - type: object > - $ref: /schemas/iio/adc/adc.yaml# > - description: Represents ADC channel. Omitted channels' inputs are GPIOs. > - > - properties: > - reg: > - description: AIN pin number > - minimum: 0 > - maximum: 31 > - > - required: > - - reg > - > - additionalProperties: false > - > required: > - compatible > - reg > @@ -62,7 +48,49 @@ required: > - spi-cpha > - spi-cpol > > -additionalProperties: false > +unevaluatedProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: rohm,bd79112 > + then: > + patternProperties: > + "^channel@([0-9]|[12][0-9]|3[01])$": > + type: object > + $ref: /schemas/iio/adc/adc.yaml# > + description: Represents ADC channel. Omitted channels' inputs are GPIOs. > + > + properties: > + reg: > + description: AIN pin number > + minimum: 0 > + maximum: 31 > + > + required: > + - reg > + > + additionalProperties: false > + else: > + # BD79111 has only 16 channels > + patternProperties: > + "^channel@([0-9]|1[0-5])$": [Severity: Medium] Should the channel unit-address regexes match hexadecimal rather than decimal ranges? Devicetree unit addresses and adc.yaml use lowercase hex without leading zeros, so "^channel@([0-9]|1[0-5])$" rejects valid nodes channel@a through channel@f on rohm,bd79111 while accepting out-of-range channel@10 through channel@15. Likewise, the 32-channel pattern rejects channel@a through channel@f and channel@1a through channel@1f while accepting channel@20 through channel@31; hex ranges would be "^channel@[0-9a-f]$" and "^channel@1?[0-9a-f]$". > + type: object > + $ref: /schemas/iio/adc/adc.yaml# > + description: Represents ADC channel. Omitted channels' inputs are GPIOs. > + > + properties: > + reg: > + description: AIN pin number > + minimum: 0 > + maximum: 15 > + > + required: > + - reg > + > + additionalProperties: false [Severity: Low] Could patternProperties stay at the top level with the 32-channel definition, and have the allOf if/then block for rohm,bd79111 only narrow reg maximum to 15 and disallow the upper 16 channel patterns? That avoids duplicating the entire channel sub-schema across both branches and allows keeping additionalProperties: false at the root level, matching Documentation/devicetree/bindings/writing-schema.rst. -- Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795009599.git.mazziesaccount@gmail.com?part=1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 2026-11-18 14:19 ` [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen 2026-11-18 14:34 ` sashiko-bot @ 2026-11-18 17:37 ` Conor Dooley 2026-11-18 17:46 ` Matti Vaittinen 1 sibling, 1 reply; 10+ messages in thread From: Conor Dooley @ 2026-11-18 17:37 UTC (permalink / raw) To: Matti Vaittinen Cc: Matti Vaittinen, Matti Vaittinen, Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 4928 bytes --] On Wed, Nov 18, 2026 at 04:19:11PM +0200, Matti Vaittinen wrote: > From: Matti Vaittinen <mazziesaccount@gmail.com> > > ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, > where pins can be configured to be either used as GPIO or ADC inputs. > ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ > sources. > > The main difference is amount of channels/GPIOs. The BD79112 has 32 pins > for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet > promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas > the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI > clock. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > > --- > > Note, I had to change the 'root-level' additionalProperties: false to > unevaluatedProperties: false in order to allow the properties in the new > allOf: > - if: > ... > > section. It seems to me this is what a few other bindings in IIO do, but > I suppose it makes this "less strict". Well, since I am terrible with > writing bindings, I'd better point this out and ask if it's ok, or if > there are better way(s) to handle this? I don't think you should have to do that though, since the children are described in the same file. If you instead retained the pattern properties section, and lowered the restriction to channel@<any number> with reg with the max of 31 and in the conditional section constrained reg to a max of 16 does it work without the unevaluatedProperties change? We typically want properties defined at the top level and constrained in conditional sections anyway. Chees, Conor. > --- > .../bindings/iio/adc/rohm,bd79112.yaml | 72 +++++++++++++------ > 1 file changed, 50 insertions(+), 22 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml > index aa8b07c3fac1..4f105124ee6f 100644 > --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79112.yaml > @@ -4,18 +4,21 @@ > $id: http://devicetree.org/schemas/iio/adc/rohm,bd79112.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: ROHM BD79112 ADC/GPO > +title: ROHM BD79111 and BD79112 ADC/GPIO > > maintainers: > - Matti Vaittinen <mazziesaccount@gmail.com> > > description: | > - The ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. ADC input pins can be > - also configured as general purpose inputs/outputs. SPI should use MODE 3. > + The ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. The ROHM BD79111 is > + a 12-bit, 16-channel, SAR ADC. ADC input pins can be also configured as > + general purpose inputs/outputs. SPI should use MODE 3. > > properties: > compatible: > - const: rohm,bd79112 > + enum: > + - rohm,bd79111 > + - rohm,bd79112 > > reg: > maxItems: 1 > @@ -37,23 +40,6 @@ properties: > "#size-cells": > const: 0 > > -patternProperties: > - "^channel@([0-9]|[12][0-9]|3[01])$": > - type: object > - $ref: /schemas/iio/adc/adc.yaml# > - description: Represents ADC channel. Omitted channels' inputs are GPIOs. > - > - properties: > - reg: > - description: AIN pin number > - minimum: 0 > - maximum: 31 > - > - required: > - - reg > - > - additionalProperties: false > - > required: > - compatible > - reg > @@ -62,7 +48,49 @@ required: > - spi-cpha > - spi-cpol > > -additionalProperties: false > +unevaluatedProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: rohm,bd79112 > + then: > + patternProperties: > + "^channel@([0-9]|[12][0-9]|3[01])$": > + type: object > + $ref: /schemas/iio/adc/adc.yaml# > + description: Represents ADC channel. Omitted channels' inputs are GPIOs. > + > + properties: > + reg: > + description: AIN pin number > + minimum: 0 > + maximum: 31 > + > + required: > + - reg > + > + additionalProperties: false > + else: > + # BD79111 has only 16 channels > + patternProperties: > + "^channel@([0-9]|1[0-5])$": > + type: object > + $ref: /schemas/iio/adc/adc.yaml# > + description: Represents ADC channel. Omitted channels' inputs are GPIOs. > + > + properties: > + reg: > + description: AIN pin number > + minimum: 0 > + maximum: 15 > + > + required: > + - reg > + > + additionalProperties: false > > examples: > - | > -- > 2.56.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 2026-11-18 17:37 ` Conor Dooley @ 2026-11-18 17:46 ` Matti Vaittinen 0 siblings, 0 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-18 17:46 UTC (permalink / raw) To: Conor Dooley Cc: Matti Vaittinen, Matti Vaittinen, Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel On 18/11/2026 19:37, Conor Dooley wrote: > On Wed, Nov 18, 2026 at 04:19:11PM +0200, Matti Vaittinen wrote: >> From: Matti Vaittinen <mazziesaccount@gmail.com> >> >> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, >> where pins can be configured to be either used as GPIO or ADC inputs. >> ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ >> sources. >> >> The main difference is amount of channels/GPIOs. The BD79112 has 32 pins >> for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet >> promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas >> the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI >> clock. >> >> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> >> >> --- >> >> Note, I had to change the 'root-level' additionalProperties: false to >> unevaluatedProperties: false in order to allow the properties in the new >> allOf: >> - if: >> ... >> >> section. It seems to me this is what a few other bindings in IIO do, but >> I suppose it makes this "less strict". Well, since I am terrible with >> writing bindings, I'd better point this out and ask if it's ok, or if >> there are better way(s) to handle this? > > I don't think you should have to do that though, since the children are > described in the same file. > If you instead retained the pattern properties section, and lowered the > restriction to channel@<any number> with reg with the max of 31 and in > the conditional section constrained reg to a max of 16 does it work Ah. I think it will, thanks for the help! I'll do that in v2. I'll just wait for a while to see what other comments I may collect :) Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] iio: adc: rohm-bd79112: Support ROHM BD79111 2026-11-18 14:18 [PATCH 0/2] Support ROHM BD79111 ADC/GPIO Matti Vaittinen 2026-11-18 14:19 ` [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen @ 2026-11-18 14:19 ` Matti Vaittinen 2026-11-19 2:51 ` Jonathan Cameron 2026-11-19 9:00 ` Andy Shevchenko 1 sibling, 2 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-18 14:19 UTC (permalink / raw) To: Matti Vaittinen, Matti Vaittinen, Matti Vaittinen Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 10163 bytes --] From: Matti Vaittinen <mazziesaccount@gmail.com> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, where pins can be configured to be either used as GPIO or ADC inputs. ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ sources. The main difference is amount of channels/GPIOs. The BD79112 has 32 pins for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI clock. NOTE: In order to achieve those speeds one needs to use more optimized protocol compared to the one implemented in this driver. This driver retrieves samples using two 16-bit SPI transactions. The first transaction writes the channel to be sampled, and ignores data on MISO. Then the next 16-bit transaction carries the data. Achieving maximum sample-rate would require the driver to interpret the MISO data of each 16-bit transaction so, that when the channel-to-be-sampled was sent in transaction N, the data is read at transaction N+1 - which also already configures the channel to be sampled for transaction N+2. Supporting this would require the channel-to-be-read for the future read to be known when the current channel data is retrieved. For raw-reads this is not possible and for buffered reads it would make things a bit hairy. So, here we aim for simplicity instead of the peak performance. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- drivers/iio/adc/Kconfig | 9 +-- drivers/iio/adc/rohm-bd79112.c | 113 +++++++++++++++++++++++++++------ 2 files changed, 98 insertions(+), 24 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index a802d8ee4dd9..db9e0a0713e1 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -1516,14 +1516,15 @@ config RN5T618_ADC will be called rn5t618-adc. config ROHM_BD79112 - tristate "Rohm BD79112 ADC driver" + tristate "ROHM BD79112 and BD79111 ADC/GPIO driver" depends on SPI && GPIOLIB select REGMAP_SPI select IIO_ADC_HELPER help - Say yes here to build support for the ROHM BD79112 ADC. The - ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. Analog inputs - can also be used for GPIO. + Say yes here to build support for the ROHM BD79112 and BD79111 + ADCs. Both of the ICs are 12-bit SAR ADCs. The ROHM BD79112 has + 32-channels, the BD79111 has 16. Analog inputs can also be used + for GPIO. config ROHM_BD79124 tristate "Rohm BD79124 ADC driver" diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c index 2506fec7be84..604c6ccafb4f 100644 --- a/drivers/iio/adc/rohm-bd79112.c +++ b/drivers/iio/adc/rohm-bd79112.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * ROHM ADC driver for BD79112 signal monitoring hub. + * ROHM ADC driver for BD79111 and BD79112 signal monitoring hubs. * Copyright (C) 2025, ROHM Semiconductor. * * SPI communication derived from ad7923.c and ti-ads7950.c @@ -26,7 +26,17 @@ #define BD79112_MAX_NUM_CHANNELS 32 +struct bd79112_data; + +struct bd7911x_chip_data { + const char *name; + const char * const *chan_names; + unsigned int num_channels; + int (*init_disable_gpios)(struct bd79112_data *data); +}; + struct bd79112_data { + const struct bd7911x_chip_data *cd; struct spi_device *spi; struct regmap *map; struct device *dev; @@ -369,7 +379,6 @@ static int bd79112_gpio_output(struct gpio_chip *gc, unsigned int offset, } static const struct gpio_chip bd79112_gpio_chip = { - .label = "bd79112-gpio", .get_direction = bd79112_gpio_dir_get, .direction_input = bd79112_gpio_input, .direction_output = bd79112_gpio_output, @@ -378,20 +387,20 @@ static const struct gpio_chip bd79112_gpio_chip = { .set_multiple = bd79112_gpio_set_multiple, .init_valid_mask = bd79112_gpio_init_valid_mask, .can_sleep = true, - .ngpio = 32, .base = -1, }; -static unsigned int bd79112_get_gpio_pins(const struct iio_chan_spec *cs, int num_channels) +static unsigned int bd79112_get_gpio_pins(const struct iio_chan_spec *cs, + int num_channels, int max_channels) { unsigned int i, gpio_channels; /* - * Let's initialize the mux config to say that all 32 channels are + * Let's initialize the mux config to say that all channels are * GPIOs. Then we can just loop through the iio_chan_spec and clear the * bits for found ADC channels. */ - gpio_channels = GENMASK(31, 0); + gpio_channels = GENMASK(max_channels - 1, 0); for (i = 0; i < num_channels; i++) gpio_channels &= ~BIT(cs[i].channel); @@ -410,6 +419,61 @@ static const char * const bd79112_chan_names[] = { "AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B", /* 28 - 31 */ }; +static int bd79112_disable_gpios(struct bd79112_data *data) +{ + unsigned int i; + int ret; + + for (i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { + ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0); + if (ret) + return ret; + } + + return 0; +} + +/* The BD79111 only has the registers for pins 0 - 15 */ +static int bd79111_disable_gpios(struct bd79112_data *data) +{ + static const unsigned int regs[] = { + BD79112_REG_GPI_EN_A8_A15, BD79112_REG_GPI_EN_A0_A7, + BD79112_REG_GPO_EN_A8_A15, BD79112_REG_GPO_EN_A0_A7, + }; + unsigned int i; + int ret; + + for (i = 0; i < ARRAY_SIZE(regs); i++) { + ret = regmap_write(data->map, regs[i], 0); + if (ret) + return ret; + } + + return 0; +} + +/* The BD79111 channel names as in the data-sheet */ +static const char * const bd79111_chan_names[] = { + "AGIO0", "AGIO1", "AGIO2", "AGIO3", /* 0 - 3 */ + "AGIO4", "AGIO5", "AGIO6", "AGIO7", /* 4 - 7 */ + "AGIO8", "AGIO9", "AGIO10", "AGIO11", /* 8 - 11 */ + "AGIO12", "AGIO13", "AGIO14", "AGIO15", /* 12 - 15 */ +}; + +static const struct bd7911x_chip_data bd79111_chip_data = { + .name = "bd79111", + .chan_names = bd79111_chan_names, + .num_channels = 16, + .init_disable_gpios = bd79111_disable_gpios, +}; + +static const struct bd7911x_chip_data bd79112_chip_data = { + .name = "bd79112", + .chan_names = bd79112_chan_names, + .num_channels = 32, + .init_disable_gpios = bd79112_disable_gpios, +}; + static int bd79112_probe(struct spi_device *spi) { struct bd79112_data *data; @@ -425,6 +489,10 @@ static int bd79112_probe(struct spi_device *spi) return -ENOMEM; data = iio_priv(iio_dev); + data->cd = spi_get_device_match_data(spi); + if (!data->cd) + return -ENODEV; + data->spi = spi; data->dev = dev; data->map = devm_regmap_init(dev, NULL, data, &bd79112_regmap); @@ -462,7 +530,7 @@ static int bd79112_probe(struct spi_device *spi) "Failed to optimize SPI write message\n"); ret = devm_iio_adc_device_alloc_chaninfo_se(dev, &bd79112_chan_template, - BD79112_MAX_NUM_CHANNELS - 1, + data->cd->num_channels - 1, &cs); /* Register all pins as GPIOs if there are no ADC channels */ @@ -476,10 +544,10 @@ static int bd79112_probe(struct spi_device *spi) iio_dev->channels = cs; for (i = 0; i < iio_dev->num_channels; i++) - cs[i].datasheet_name = bd79112_chan_names[cs[i].channel]; + cs[i].datasheet_name = data->cd->chan_names[cs[i].channel]; iio_dev->info = &bd79112_info; - iio_dev->name = "bd79112"; + iio_dev->name = data->cd->name; iio_dev->modes = INDIO_DIRECT_MODE; /* @@ -488,12 +556,9 @@ static int bd79112_probe(struct spi_device *spi) * without having to worry about some pins being initially used for * GPIO. */ - for (i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { - ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0); - if (ret) - return dev_err_probe(dev, ret, - "Failed to initialize channels\n"); - } + ret = data->cd->init_disable_gpios(data); + if (ret) + return dev_err_probe(dev, ret, "Failed to initialize channels\n"); ret = devm_iio_device_register(data->dev, iio_dev); if (ret) @@ -501,14 +566,15 @@ static int bd79112_probe(struct spi_device *spi) register_gpios: gpio_pins = bd79112_get_gpio_pins(iio_dev->channels, - iio_dev->num_channels); + iio_dev->num_channels, + data->cd->num_channels); /* If all channels are reserved for ADC, then we're done. */ if (!gpio_pins) return 0; /* Default all the GPIO pins to GPI */ - for_each_set_bit(pin, &gpio_pins, BD79112_MAX_NUM_CHANNELS) { + for_each_set_bit(pin, &gpio_pins, data->cd->num_channels) { ret = bd79112_gpio_dir_set(data, pin, GPIO_LINE_DIRECTION_IN); if (ret) return dev_err_probe(dev, ret, @@ -518,18 +584,25 @@ static int bd79112_probe(struct spi_device *spi) data->gpio_valid_mask = gpio_pins; data->gc = bd79112_gpio_chip; data->gc.parent = dev; + data->gc.ngpio = data->cd->num_channels; + data->gc.label = devm_kasprintf(dev, GFP_KERNEL, "%s-gpio", + data->cd->name); + if (!data->gc.label) + return -ENOMEM; return devm_gpiochip_add_data(dev, &data->gc, data); } static const struct of_device_id bd79112_of_match[] = { - { .compatible = "rohm,bd79112" }, + { .compatible = "rohm,bd79111", .data = &bd79111_chip_data }, + { .compatible = "rohm,bd79112", .data = &bd79112_chip_data }, { } }; MODULE_DEVICE_TABLE(of, bd79112_of_match); static const struct spi_device_id bd79112_id[] = { - { .name = "bd79112" }, + { .name = "bd79111", .driver_data = (kernel_ulong_t)&bd79111_chip_data }, + { .name = "bd79112", .driver_data = (kernel_ulong_t)&bd79112_chip_data }, { } }; MODULE_DEVICE_TABLE(spi, bd79112_id); @@ -545,6 +618,6 @@ static struct spi_driver bd79112_driver = { module_spi_driver(bd79112_driver); MODULE_AUTHOR("Matti Vaittinen <mazziesaccount@gmail.com>"); -MODULE_DESCRIPTION("Driver for ROHM BD79112 ADC/GPIO"); +MODULE_DESCRIPTION("Driver for ROHM BD79111 and BD79112 ADC/GPIO"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("IIO_DRIVER"); -- 2.56.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] iio: adc: rohm-bd79112: Support ROHM BD79111 2026-11-18 14:19 ` [PATCH 2/2] iio: adc: rohm-bd79112: " Matti Vaittinen @ 2026-11-19 2:51 ` Jonathan Cameron 2026-11-19 7:13 ` Matti Vaittinen 2026-11-19 9:00 ` Andy Shevchenko 1 sibling, 1 reply; 10+ messages in thread From: Jonathan Cameron @ 2026-11-19 2:51 UTC (permalink / raw) To: Matti Vaittinen, Jakub Szczudlo Cc: Matti Vaittinen, Matti Vaittinen, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Antoniu Miclaus, linux-iio, devicetree, linux-kernel On Wed, 18 Nov 2026 16:19:35 +0200 Matti Vaittinen <matti.vaittinen@linux.dev> wrote: > From: Matti Vaittinen <mazziesaccount@gmail.com> > > ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, > where pins can be configured to be either used as GPIO or ADC inputs. > ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ > sources. > > The main difference is amount of channels/GPIOs. The BD79112 has 32 pins > for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet > promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas > the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI > clock. > > NOTE: In order to achieve those speeds one needs to use more optimized > protocol compared to the one implemented in this driver. This driver > retrieves samples using two 16-bit SPI transactions. The first > transaction writes the channel to be sampled, and ignores data on MISO. > Then the next 16-bit transaction carries the data. > > Achieving maximum sample-rate would require the driver to interpret the > MISO data of each 16-bit transaction so, that when the > channel-to-be-sampled was sent in transaction N, the data is read at > transaction N+1 - which also already configures the channel to be > sampled for transaction N+2. Supporting this would require the > channel-to-be-read for the future read to be known when the current > channel data is retrieved. For raw-reads this is not possible and for > buffered reads it would make things a bit hairy. FWIW there are quite a few drivers implementing that scheme for buffered capture. Look for drivers that preprepare an SPI transfer. Absolutely fine to not support that optimization! This seems like text that probably applies to both parts rather than being directly relevant to what is added here? If you did add that support it would be in a different patch. I'd cut most of that info to keep the commit message focused. > > So, here we aim for simplicity instead of the peak performance. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > --- > drivers/iio/adc/Kconfig | 9 +-- > drivers/iio/adc/rohm-bd79112.c | 113 +++++++++++++++++++++++++++------ > 2 files changed, 98 insertions(+), 24 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index a802d8ee4dd9..db9e0a0713e1 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -1516,14 +1516,15 @@ config RN5T618_ADC > will be called rn5t618-adc. > > config ROHM_BD79112 > - tristate "Rohm BD79112 ADC driver" > + tristate "ROHM BD79112 and BD79111 ADC/GPIO driver" > depends on SPI && GPIOLIB > select REGMAP_SPI > select IIO_ADC_HELPER > help > - Say yes here to build support for the ROHM BD79112 ADC. The > - ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. Analog inputs > - can also be used for GPIO. > + Say yes here to build support for the ROHM BD79112 and BD79111 > + ADCs. Both of the ICs are 12-bit SAR ADCs. The ROHM BD79112 has > + 32-channels, the BD79111 has 16. Analog inputs can also be used > + for GPIO. Given it now supports 2 parts and I'm guessing more may be along in the future you might want to jump directly to the style we have in some other kconfig entries of vague option text and then a bulleted list of stuff about specific devices. That way a new part just requires a new bullet point, nothing else changes. > > config ROHM_BD79124 > tristate "Rohm BD79124 ADC driver" > diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c > index 2506fec7be84..604c6ccafb4f 100644 > --- a/drivers/iio/adc/rohm-bd79112.c > +++ b/drivers/iio/adc/rohm-bd79112.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-only > /* > - * ROHM ADC driver for BD79112 signal monitoring hub. > + * ROHM ADC driver for BD79111 and BD79112 signal monitoring hubs. Similar on possibly going vague. The firmware tables make it clear on what is being supported. > * Copyright (C) 2025, ROHM Semiconductor. > * > * SPI communication derived from ad7923.c and ti-ads7950.c > @@ -26,7 +26,17 @@ > > #define BD79112_MAX_NUM_CHANNELS 32 > > +struct bd79112_data; > + > +struct bd7911x_chip_data { > + const char *name; > + const char * const *chan_names; > + unsigned int num_channels; > + int (*init_disable_gpios)(struct bd79112_data *data); > +}; > + > struct bd79112_data { > + const struct bd7911x_chip_data *cd; > struct spi_device *spi; > struct regmap *map; > struct device *dev; > @@ -369,7 +379,6 @@ static int bd79112_gpio_output(struct gpio_chip *gc, unsigned int offset, > } > > static const struct gpio_chip bd79112_gpio_chip = { > - .label = "bd79112-gpio", > .get_direction = bd79112_gpio_dir_get, > .direction_input = bd79112_gpio_input, > .direction_output = bd79112_gpio_output, > @@ -378,20 +387,20 @@ static const struct gpio_chip bd79112_gpio_chip = { > .set_multiple = bd79112_gpio_set_multiple, > .init_valid_mask = bd79112_gpio_init_valid_mask, > .can_sleep = true, > - .ngpio = 32, > .base = -1, > }; There are only two parts, maybe it is simpler to have dual gpio_chip instances pointed to by your chip_data? Keep the full state of each in one place? I don't mind much either way on this. > +static int bd79112_disable_gpios(struct bd79112_data *data) > +{ > + unsigned int i; > + int ret; > + > + for (i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { These days the kernel style allows for (unsigned int i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { Same in various other places. Saves us a few lines of scrolling and keeps the scope tight. > + ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0); > + if (ret) > + return ret; > + } > + > + return 0; > +} > ... > + > +/* The BD79111 channel names as in the data-sheet */ > +static const char * const bd79111_chan_names[] = { > + "AGIO0", "AGIO1", "AGIO2", "AGIO3", /* 0 - 3 */ > + "AGIO4", "AGIO5", "AGIO6", "AGIO7", /* 4 - 7 */ > + "AGIO8", "AGIO9", "AGIO10", "AGIO11", /* 8 - 11 */ > + "AGIO12", "AGIO13", "AGIO14", "AGIO15", /* 12 - 15 */ > +}; > + > +static const struct bd7911x_chip_data bd79111_chip_data = { > + .name = "bd79111", > + .chan_names = bd79111_chan_names, > + .num_channels = 16, > + .init_disable_gpios = bd79111_disable_gpios, > +}; Ordering seems a little strange with the bd79112_chan_names no where near the ones for the 1111 > + > +static const struct bd7911x_chip_data bd79112_chip_data = { > + .name = "bd79112", > + .chan_names = bd79112_chan_names, > + .num_channels = 32, > + .init_disable_gpios = bd79112_disable_gpios, > +}; ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] iio: adc: rohm-bd79112: Support ROHM BD79111 2026-11-19 2:51 ` Jonathan Cameron @ 2026-11-19 7:13 ` Matti Vaittinen 0 siblings, 0 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-19 7:13 UTC (permalink / raw) To: Jonathan Cameron, Matti Vaittinen, Jakub Szczudlo Cc: Matti Vaittinen, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Antoniu Miclaus, linux-iio, devicetree, linux-kernel Hi & Thanks Jonathan! On 19/11/2026 04:51, Jonathan Cameron wrote: > On Wed, 18 Nov 2026 16:19:35 +0200 > Matti Vaittinen <matti.vaittinen@linux.dev> wrote: > >> From: Matti Vaittinen <mazziesaccount@gmail.com> >> >> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, >> where pins can be configured to be either used as GPIO or ADC inputs. >> ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ >> sources. >> >> The main difference is amount of channels/GPIOs. The BD79112 has 32 pins >> for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet >> promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas >> the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI >> clock. >> >> NOTE: In order to achieve those speeds one needs to use more optimized >> protocol compared to the one implemented in this driver. This driver >> retrieves samples using two 16-bit SPI transactions. The first >> transaction writes the channel to be sampled, and ignores data on MISO. >> Then the next 16-bit transaction carries the data. >> >> Achieving maximum sample-rate would require the driver to interpret the >> MISO data of each 16-bit transaction so, that when the >> channel-to-be-sampled was sent in transaction N, the data is read at >> transaction N+1 - which also already configures the channel to be >> sampled for transaction N+2. Supporting this would require the >> channel-to-be-read for the future read to be known when the current >> channel data is retrieved. For raw-reads this is not possible and for >> buffered reads it would make things a bit hairy. > > FWIW there are quite a few drivers implementing that scheme for > buffered capture. Look for drivers that preprepare an SPI transfer. > Absolutely fine to not support that optimization! > > This seems like text that probably applies to both parts rather than Yes. This applies to both of these ADCs. And thanks for the pointer! Once again, I really appreciate your help. I will definitely take a look at how this is done by other ADCs. These two aren't the only (ROHM) ICs using this type of mechanism, so spending some time is well justified :) > being directly relevant to what is added here? If you did add that > support it would be in a different patch. Sure. > I'd cut most of that info > to keep the commit message focused. I kind of agree - while I also believe that noting the performance limitation coming from the driver itself makes sense. It does not need to be this verbose though. Besides, the verbosity already worked as it made you to drop me the above info ;) //snip >> static const struct gpio_chip bd79112_gpio_chip = { >> - .label = "bd79112-gpio", >> .get_direction = bd79112_gpio_dir_get, >> .direction_input = bd79112_gpio_input, >> .direction_output = bd79112_gpio_output, >> @@ -378,20 +387,20 @@ static const struct gpio_chip bd79112_gpio_chip = { >> .set_multiple = bd79112_gpio_set_multiple, >> .init_valid_mask = bd79112_gpio_init_valid_mask, >> .can_sleep = true, >> - .ngpio = 32, >> .base = -1, >> }; > > There are only two parts, maybe it is simpler to have dual gpio_chip > instances pointed to by your chip_data? Keep the full state of each in > one place? I don't mind much either way on this. I didn't even evaluate such option. I'll try it out and see how it looks like. I agree with all other comments - even though declaring the indexer variable in a for-loop requires a bit of learning ;) (Which doesn't mean limiting the scope didn't make sense when index is not used outside the loop). Thanks! -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] iio: adc: rohm-bd79112: Support ROHM BD79111 2026-11-18 14:19 ` [PATCH 2/2] iio: adc: rohm-bd79112: " Matti Vaittinen 2026-11-19 2:51 ` Jonathan Cameron @ 2026-11-19 9:00 ` Andy Shevchenko 2026-11-19 9:09 ` Matti Vaittinen 1 sibling, 1 reply; 10+ messages in thread From: Andy Shevchenko @ 2026-11-19 9:00 UTC (permalink / raw) To: Matti Vaittinen Cc: Matti Vaittinen, Matti Vaittinen, Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel On Wed, Nov 18, 2026 at 04:19:35PM +0200, Matti Vaittinen wrote: > > ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, > where pins can be configured to be either used as GPIO or ADC inputs. > ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ > sources. > > The main difference is amount of channels/GPIOs. The BD79112 has 32 pins > for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet > promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas > the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI > clock. > > NOTE: In order to achieve those speeds one needs to use more optimized > protocol compared to the one implemented in this driver. This driver > retrieves samples using two 16-bit SPI transactions. The first > transaction writes the channel to be sampled, and ignores data on MISO. > Then the next 16-bit transaction carries the data. > > Achieving maximum sample-rate would require the driver to interpret the > MISO data of each 16-bit transaction so, that when the > channel-to-be-sampled was sent in transaction N, the data is read at > transaction N+1 - which also already configures the channel to be > sampled for transaction N+2. Supporting this would require the > channel-to-be-read for the future read to be known when the current > channel data is retrieved. For raw-reads this is not possible and for > buffered reads it would make things a bit hairy. > > So, here we aim for simplicity instead of the peak performance. ... > config ROHM_BD79112 > - tristate "Rohm BD79112 ADC driver" > + tristate "ROHM BD79112 and BD79111 ADC/GPIO driver" So, as Jonathan mentioned this should be rather relaxed, so we don't update it each time the new HW is got supported. Also in a new style we want a bit of an order by having this, text in top comment, and MODULE_DESCRIPTION() to be the same (or very similar, like with or without word 'driver'). > depends on SPI && GPIOLIB > select REGMAP_SPI > select IIO_ADC_HELPER > help > - Say yes here to build support for the ROHM BD79112 ADC. The > - ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. Analog inputs > - can also be used for GPIO. > + Say yes here to build support for the ROHM BD79112 and BD79111 > + ADCs. Both of the ICs are 12-bit SAR ADCs. The ROHM BD79112 has > + 32-channels, the BD79111 has 16. Analog inputs can also be used > + for GPIO. Yeah, and here the style is to have something like a list Say yes here to build support for the following ROHM SAR ADCs: - BD7911 (12-bit, 16 channels) - BD7912 (12-bit, 32 channels) Analog inputs can also be used for GPIO. (feel free to amend, it's just an example). ... > +static int bd79112_disable_gpios(struct bd79112_data *data) > +{ > + unsigned int i; > + int ret; > + for (i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { for (unsigned int i = 0; i < BD79112_NUM_GPIO_EN_REGS; i++) { > + ret = regmap_write(data->map, BD79112_FIRST_GPIO_EN_REG + i, 0); > + if (ret) > + return ret; > + } > + > + return 0; > +} ... > +/* The BD79111 only has the registers for pins 0 - 15 */ > +static int bd79111_disable_gpios(struct bd79112_data *data) > +{ > + static const unsigned int regs[] = { > + BD79112_REG_GPI_EN_A8_A15, BD79112_REG_GPI_EN_A0_A7, > + BD79112_REG_GPO_EN_A8_A15, BD79112_REG_GPO_EN_A0_A7, > + }; > + unsigned int i; > + int ret; > + for (i = 0; i < ARRAY_SIZE(regs); i++) { for (unsigned int i = 0; i < ARRAY_SIZE(regs); i++) { > + ret = regmap_write(data->map, regs[i], 0); > + if (ret) > + return ret; > + } > + > + return 0; > +} ... > data = iio_priv(iio_dev); > + data->cd = spi_get_device_match_data(spi); > + if (!data->cd) > + return -ENODEV; -ENODATA ... > + data->gc.ngpio = data->cd->num_channels; > + data->gc.label = devm_kasprintf(dev, GFP_KERNEL, "%s-gpio", > + data->cd->name); I would use a single line. > + if (!data->gc.label) > + return -ENOMEM; ... > static const struct of_device_id bd79112_of_match[] = { > - { .compatible = "rohm,bd79112" }, > + { .compatible = "rohm,bd79111", .data = &bd79111_chip_data }, > + { .compatible = "rohm,bd79112", .data = &bd79112_chip_data }, > { } > }; So, this can be split to two patches: - introduction of chip_info - adding a new HW. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] iio: adc: rohm-bd79112: Support ROHM BD79111 2026-11-19 9:00 ` Andy Shevchenko @ 2026-11-19 9:09 ` Matti Vaittinen 0 siblings, 0 replies; 10+ messages in thread From: Matti Vaittinen @ 2026-11-19 9:09 UTC (permalink / raw) To: Andy Shevchenko Cc: Matti Vaittinen, Matti Vaittinen, Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Marcelo Schmitt, Joshua Crofts, Radu Sabau, Janani Sunil, Salih Erim, Jishnu Prakash, Antoniu Miclaus, Jakub Szczudlo, linux-iio, devicetree, linux-kernel On 19/11/2026 11:00, Andy Shevchenko wrote: > On Wed, Nov 18, 2026 at 04:19:35PM +0200, Matti Vaittinen wrote: >> >> ROHM BD79111 is very similar to the BD79112. Both are ADC/GPIO devices, >> where pins can be configured to be either used as GPIO or ADC inputs. >> ADCs are 12-bit SAR ADCs and GPIOs support input/output but not being IRQ >> sources. >> >> The main difference is amount of channels/GPIOs. The BD79112 has 32 pins >> for this use, the BD79111 has 16. Furthermore, the BD79111 data-sheet >> promises 0.5 MSPS sample rate with maximum of 10 MHz SPI clock, whereas >> the BD79112 data-sheet mentioned 1MSPS rate with maximum of 20 MHz SPI >> clock. >> >> NOTE: In order to achieve those speeds one needs to use more optimized >> protocol compared to the one implemented in this driver. This driver >> retrieves samples using two 16-bit SPI transactions. The first >> transaction writes the channel to be sampled, and ignores data on MISO. >> Then the next 16-bit transaction carries the data. >> >> Achieving maximum sample-rate would require the driver to interpret the >> MISO data of each 16-bit transaction so, that when the >> channel-to-be-sampled was sent in transaction N, the data is read at >> transaction N+1 - which also already configures the channel to be >> sampled for transaction N+2. Supporting this would require the >> channel-to-be-read for the future read to be known when the current >> channel data is retrieved. For raw-reads this is not possible and for >> buffered reads it would make things a bit hairy. >> >> So, here we aim for simplicity instead of the peak performance. > > ... > >> config ROHM_BD79112 >> - tristate "Rohm BD79112 ADC driver" >> + tristate "ROHM BD79112 and BD79111 ADC/GPIO driver" > > So, as Jonathan mentioned this should be rather relaxed, so we don't update it > each time the new HW is got supported. Also in a new style we want a bit of an > order by having this, text in top comment, and MODULE_DESCRIPTION() to be the > same (or very similar, like with or without word 'driver'). > >> depends on SPI && GPIOLIB >> select REGMAP_SPI >> select IIO_ADC_HELPER >> help >> - Say yes here to build support for the ROHM BD79112 ADC. The >> - ROHM BD79112 is a 12-bit, 32-channel, SAR ADC. Analog inputs >> - can also be used for GPIO. >> + Say yes here to build support for the ROHM BD79112 and BD79111 >> + ADCs. Both of the ICs are 12-bit SAR ADCs. The ROHM BD79112 has >> + 32-channels, the BD79111 has 16. Analog inputs can also be used >> + for GPIO. > > Yeah, and here the style is to have something like a list > > Say yes here to build support for the following ROHM SAR ADCs: > - BD7911 (12-bit, 16 channels) > - BD7912 (12-bit, 32 channels) > > Analog inputs can also be used for GPIO. > > (feel free to amend, it's just an example). //snip Thanks for the examples ... ... and also for the other comments Andy. I'll create v2. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-11-19 9:09 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-18 14:18 [PATCH 0/2] Support ROHM BD79111 ADC/GPIO Matti Vaittinen 2026-11-18 14:19 ` [PATCH 1/2] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen 2026-11-18 14:34 ` sashiko-bot 2026-11-18 17:37 ` Conor Dooley 2026-11-18 17:46 ` Matti Vaittinen 2026-11-18 14:19 ` [PATCH 2/2] iio: adc: rohm-bd79112: " Matti Vaittinen 2026-11-19 2:51 ` Jonathan Cameron 2026-11-19 7:13 ` Matti Vaittinen 2026-11-19 9:00 ` Andy Shevchenko 2026-11-19 9:09 ` Matti Vaittinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox