From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: shengjiu.wang@oss.nxp.com, lgirdwood@gmail.com,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, shawnguo@kernel.org,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Xiubo.Lee@gmail.com,
nicoleotsuka@gmail.com, perex@perex.cz, tiwai@suse.com,
linuxppc-dev@lists.ozlabs.org,
Shengjiu Wang <shengjiu.wang@nxp.com>
Subject: Re: [PATCH v3 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths
Date: Tue, 11 Aug 2026 09:36:26 +0200 [thread overview]
Message-ID: <3219a2e7-d11b-478e-ad2e-5f1ec2bbdf27@kernel.org> (raw)
In-Reply-To: <CAA+D8AOQ_y7BdR4h+X6qxFygPU6h1iFV0cYXHN4KB370yM2Bkw@mail.gmail.com>
On 11/08/2026 09:33, Shengjiu Wang wrote:
>>>>
>>>> Why mentioning upstream in the first place? Either this change breaks
>>>> ABI or not, explain that.
>>>
>>> The deprecated 'port' property is retained, so this change is fully backwards
>>> compatible and does not break ABI.
>>
>> So why? Drop redundant parts.
>
> Ok, I will remove the sentence below in the commit message.
>
> No existing upstream DTS file for fsl,imx-asrc uses the previously
> documented single 'port' node, so this change does not break any
> in-tree device tree.
>
Honestly, it's redundant, because you are not dropping it. So even if
DTS was using the port, what would change?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-11 7:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:02 [PATCH v3 0/5] ASoC: fsl_asrc/fsl_easrc: expose per-pair/context DAIs and fix DMA race shengjiu.wang
2026-08-04 10:02 ` [PATCH v3 1/5] ASoC: dt-bindings: fsl,imx-asrc: update port binding to support multiple paths shengjiu.wang
2026-08-04 14:39 ` Frank Li
2026-08-05 6:57 ` Shengjiu Wang
2026-08-05 17:06 ` Frank Li
2026-08-06 5:27 ` Shengjiu Wang
2026-08-06 16:40 ` Frank Li
2026-08-10 7:12 ` Krzysztof Kozlowski
2026-08-10 19:07 ` Frank Li
2026-08-11 5:44 ` Krzysztof Kozlowski
2026-08-10 7:14 ` Krzysztof Kozlowski
2026-08-11 2:28 ` Shengjiu Wang
2026-08-11 5:44 ` Krzysztof Kozlowski
2026-08-11 7:33 ` Shengjiu Wang
2026-08-11 7:36 ` Krzysztof Kozlowski [this message]
2026-08-11 8:17 ` Shengjiu Wang
2026-08-04 10:02 ` [PATCH v3 2/5] ASoC: dt-bindings: fsl,easrc: add ports binding for multiple conversion paths shengjiu.wang
2026-08-04 14:40 ` Frank Li
2026-08-04 10:02 ` [PATCH v3 3/5] ASoC: fsl_asrc/fsl_easrc: move DMA params into pair/context struct shengjiu.wang
2026-08-04 10:15 ` sashiko-bot
2026-08-04 10:02 ` [PATCH v3 4/5] ASoC: fsl_asrc: expose individual DAIs per conversion path shengjiu.wang
2026-08-04 10:20 ` sashiko-bot
2026-08-04 10:02 ` [PATCH v3 5/5] ASoC: fsl_easrc: " shengjiu.wang
2026-08-04 10:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3219a2e7-d11b-478e-ad2e-5f1ec2bbdf27@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=shengjiu.wang@oss.nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox