Re: [RFC PATCH 06/11] media: iris: Add hooks for pixel and non-pixel context banks

[Vikash Garodia <vikash.garodia@oss.qualcomm.com>]

On 7/10/2026 9:42 PM, Dmitry Baryshkov wrote:
> On Thu, Jul 09, 2026 at 01:54:18PM +0000, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
>>
>> New issues:
>> - [High] Unregistering context bank devices in `remove` while V4L2 FDs are open causes DMA API mismatch and IOMMU faults.
> 
> Please fix the runtime issues. It's not the first one being reported by
> Sashiko. Please go through the previous reviews. I think the nature of
> most of lifecycle issues is the same: corectly handling device removal
> vs userspace lifecycle.

The runtime issue here is nothing specific to the subnode approach we 
are adding in this series. I can look at it separately, or if you 
already have any proposal to address the same, please post for review.

> 
>> - [Medium] Hardcoded platform device ID causes name collision if multiple Iris instances exist.
> 
> Dreams... But using PLATFORM_DEVID_AUTO makes sense.
> 
>>
>> Pre-existing issues:
>> - [High] Missing cancellation of sys_error_handler delayed work leads to Use-After-Free.
>> - [High] Use-After-Free on `iris_core` during deferred V4L2 close due to `devm_kzalloc`.
>> --
>>
> 

Regards,
Vikash