Devicetree
 help / color / mirror / Atom feed
From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: Enable USB controllers on Shikra IQS platform
Date: Fri, 17 Jul 2026 06:00:55 +0530	[thread overview]
Message-ID: <3763d264-e958-4a2a-ad7b-204e6af37655@oss.qualcomm.com> (raw)
In-Reply-To: <606db992-446c-4601-805a-d86d0fb74110@oss.qualcomm.com>



On 7/16/2026 11:10 PM, Konrad Dybcio wrote:
> On 7/16/26 6:29 PM, Krishna Kurapati wrote:
>> Enable both usb controllers in device mode on Shikra IQS platform.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 35 +++++++++++++++++++++++++++++
>>   1 file changed, 35 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
>> index 3003a47bd759..2d4e34ec3b82 100644
>> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
>> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
>> @@ -38,3 +38,38 @@ &sdhc_1 {
>>   
>>   	status = "okay";
>>   };
>> +
>> +&usb_1 {
>> +	dr_mode = "peripheral";
> 
> Why does this one have to be peripheral if the other boards are otg?
> 

Actually I missed adding dr_mode as peripheral for other boards. I put 
in commit message that I want them to work in device mode but missed 
adding dr_mode property. Since the default behavior is peripheral mode, 
i saw no functional issue while testing. Shall I send v2 with either 
removing dr mode here in iqs or adding it in cqs/cqm ?

> [...]
> 
>> +&usb_2 {
>> +	dr_mode = "peripheral";
>> +
>> +	status = "okay";
> 
> And why do the other boards lack the secondary USB?
As mentioned in cover letter, on pure upstream build, I validated both 
controllers on iqs platform and only primary controller on cqs/cqm 
platform on a remote access setup.

Regards,
Krishna,

      reply	other threads:[~2026-07-17  0:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 16:29 [PATCH v3 0/4] Add DT Support for USB on Shikra Krishna Kurapati
2026-07-16 16:29 ` [PATCH v3 1/4] arm64: dts: qcom: Add support for usb nodes " Krishna Kurapati
2026-07-16 16:46   ` sashiko-bot
2026-07-16 16:29 ` [PATCH v3 2/4] arm64: dts: qcom: Enable Primary USB controller on Shikra CQS platform Krishna Kurapati
2026-07-16 16:41   ` sashiko-bot
2026-07-16 17:38   ` Konrad Dybcio
2026-07-16 16:29 ` [PATCH v3 3/4] arm64: dts: qcom: Enable Primary USB controller on Shikra CQM platform Krishna Kurapati
2026-07-16 16:51   ` sashiko-bot
2026-07-16 17:38   ` Konrad Dybcio
2026-07-16 16:29 ` [PATCH v3 4/4] arm64: dts: qcom: Enable USB controllers on Shikra IQS platform Krishna Kurapati
2026-07-16 17:40   ` Konrad Dybcio
2026-07-17  0:30     ` Krishna Kurapati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3763d264-e958-4a2a-ad7b-204e6af37655@oss.qualcomm.com \
    --to=krishna.kurapati@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox