[PATCH 0/2] arm64: dts: qcom: sm8750: Add watchdog support

[PATCH 0/2] arm64: dts: qcom: sm8750: Add watchdog support

[Komal Bajaj]

This series adds Qualcomm SM8750 watchdog support by updating both the
binding and the SM8750 devicetree.

Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
Komal Bajaj (2):
      dt-bindings: watchdog: qcom-wdt: Document SM8750 watchdog
      arm64: dts: qcom: sm8750: Add watchdog node

 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 arch/arm64/boot/dts/qcom/sm8750.dtsi                     | 7 +++++++
 2 files changed, 8 insertions(+)
---
base-commit: 6375e61c01e93e35ee7acd336a689ac1fae4b509
change-id: 20260929-sm8750-watchdog-f666b0e43875

Best regards,
-- 
Komal Bajaj <komal.bajaj@oss.qualcomm.com>

[PATCH 1/2] dt-bindings: watchdog: qcom-wdt: Document SM8750 watchdog

[Komal Bajaj]

Add the SM8750 compatible string to Qualcomm watchdog binding.

Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 4ff61102e407..8cd8331608ba 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -50,6 +50,7 @@ properties:
               - qcom,apss-wdt-sm6350
               - qcom,apss-wdt-sm8150
               - qcom,apss-wdt-sm8250
+              - qcom,apss-wdt-sm8750
               - qcom,apss-wdt-x1e80100
           - const: qcom,kpss-wdt
       - const: qcom,kpss-wdt

-- 
2.34.1

[PATCH 2/2] arm64: dts: qcom: sm8750: Add watchdog node

[Komal Bajaj]

Add a node for the watchdog on the SM8750 SoC.

Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 8ed5fa4d24fc..53125e5dc4cc 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -6006,6 +6006,13 @@ cpucp_mbox: mailbox@16430000 {
 			#mbox-cells = <1>;
 		};
 
+		watchdog@16410000 {
+			compatible = "qcom,apss-wdt-sm8750", "qcom,kpss-wdt";
+			reg = <0x0 0x16410000 0x0 0x1000>;
+			clocks = <&sleep_clk>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		apps_rsc: rsc@16500000 {
 			compatible = "qcom,rpmh-rsc";
 			reg = <0x0 0x16500000 0x0 0x10000>,

-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Add watchdog node

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt: incorrect node ordering in sm8750.dtsi
--

commit 807aba78b66c219c014d5a42b4b7964dbeb6b207
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

arm64: dts: qcom: sm8750: Add watchdog node
    
This commit adds a device tree node for the watchdog on the SM8750 SoC.

> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index 8ed5fa4d24fcd..53125e5dc4cca 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -6006,6 +6006,13 @@ cpucp_mbox: mailbox@16430000 {
>  			#mbox-cells = <1>;
>  		};
>  
> +		watchdog@16410000 {
> +			compatible = "qcom,apss-wdt-sm8750", "qcom,kpss-wdt";
> +			reg = <0x0 0x16410000 0x0 0x1000>;
> +			clocks = <&sleep_clk>;
> +			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> +		};
> +

[Severity: Low]
Does this placement break the ascending unit-address order convention for
Device Tree files?

The new watchdog@16410000 node is being placed immediately after the
mailbox@16430000 node. Should this node be moved above the mailbox node to
keep the children sorted numerically by their unit address?

>  		apps_rsc: rsc@16500000 {
>  			compatible = "qcom,rpmh-rsc";
>  			reg = <0x0 0x16500000 0x0 0x10000>,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929-sm8750-watchdog-v1-0-ea06d5dc7e54@oss.qualcomm.com?part=2

Re: [PATCH 1/2] dt-bindings: watchdog: qcom-wdt: Document SM8750 watchdog

[Krzysztof Kozlowski]

On Tue, Sep 29, 2026 at 04:01:21PM +0530, Komal Bajaj wrote:
> Add the SM8750 compatible string to Qualcomm watchdog binding.
> 
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Add watchdog node

[Konrad Dybcio]

On 9/29/26 12:31 PM, Komal Bajaj wrote:
> Add a node for the watchdog on the SM8750 SoC.
> 
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Add watchdog node

[Komal Bajaj]

On 9/29/2026 4:09 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt: incorrect node ordering in sm8750.dtsi
> --
>
> commit 807aba78b66c219c014d5a42b4b7964dbeb6b207
> Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>
> arm64: dts: qcom: sm8750: Add watchdog node
>      
> This commit adds a device tree node for the watchdog on the SM8750 SoC.
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> index 8ed5fa4d24fcd..53125e5dc4cca 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> @@ -6006,6 +6006,13 @@ cpucp_mbox: mailbox@16430000 {
>>   			#mbox-cells = <1>;
>>   		};
>>   
>> +		watchdog@16410000 {
>> +			compatible = "qcom,apss-wdt-sm8750", "qcom,kpss-wdt";
>> +			reg = <0x0 0x16410000 0x0 0x1000>;
>> +			clocks = <&sleep_clk>;
>> +			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
>> +		};
>> +
> [Severity: Low]
> Does this placement break the ascending unit-address order convention for
> Device Tree files?
>
> The new watchdog@16410000 node is being placed immediately after the
> mailbox@16430000 node. Should this node be moved above the mailbox node to
> keep the children sorted numerically by their unit address?

I missed that. I will fix the node ordering in next version.

Thanks
Komal

>
>>   		apps_rsc: rsc@16500000 {
>>   			compatible = "qcom,rpmh-rsc";
>>   			reg = <0x0 0x16500000 0x0 0x10000>,