From: Dragan Simic <dsimic@manjaro.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: correct the model name for Radxa ROCK 3A
Date: Thu, 18 Apr 2024 17:21:49 +0200 [thread overview]
Message-ID: <39e73428856a6fdf698a5efe6311af0f@manjaro.org> (raw)
In-Reply-To: <20240418130120.67663-2-amadeus@jmu.edu.cn>
On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Looking good to me.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index c62230308457..e859c075bd46 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -8,8 +8,8 @@
> #include "rk3568.dtsi"
>
> / {
> - model = "Radxa ROCK3 Model A";
> - compatible = "radxa,rock3a", "rockchip,rk3568";
> + model = "Radxa ROCK 3A";
> + compatible = "radxa,rock-3a", "rockchip,rk3568";
>
> aliases {
> ethernet0 = &gmac1;
next prev parent reply other threads:[~2024-04-18 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:01 [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A Chukun Pan
2024-04-18 13:01 ` [PATCH 2/2] arm64: dts: " Chukun Pan
2024-04-18 15:21 ` Dragan Simic [this message]
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
2024-04-18 15:37 ` Conor Dooley
2024-04-18 15:46 ` Dragan Simic
2024-04-18 15:57 ` Conor Dooley
2024-04-18 15:58 ` Dragan Simic
2024-04-18 16:34 ` Dragan Simic
2024-04-18 15:36 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39e73428856a6fdf698a5efe6311af0f@manjaro.org \
--to=dsimic@manjaro.org \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox