From: Dragan Simic <dsimic@manjaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
Date: Thu, 18 Apr 2024 17:46:30 +0200 [thread overview]
Message-ID: <7fec3e2f4e16b1aca6cd08e1882bd885@manjaro.org> (raw)
In-Reply-To: <20240418-drove-boasting-d189ee3e22e0@spud>
Hello Conor,
On 2024-04-18 17:37, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> On 2024-04-18 15:01, Chukun Pan wrote:
>> > According to https://radxa.com/products/rock3/3a,
>> > the name of this board should be "Radxa ROCK 3A".
>> > Also update compatible to match the model name.
>> >
>> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>>
>> Looking good to me. I'll send the remaining naming cleanup patches
>> a bit later.
>
> What remaining patches?
The same naming cleanups need to be performed for the Radxa
ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
boards in mind, but I'll drop them after your NAK. [2]
Though, I'm not really sure why the NAK? Those names aren't
used anywhere, neither in the Linux kernel, nor in U-Boot.
[1]
https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/
[2]
https://lore.kernel.org/linux-rockchip/20240418-liberty-pry-d270065a544f@spud/
next prev parent reply other threads:[~2024-04-18 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 13:01 [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A Chukun Pan
2024-04-18 13:01 ` [PATCH 2/2] arm64: dts: " Chukun Pan
2024-04-18 15:21 ` Dragan Simic
2024-04-18 15:21 ` [PATCH 1/2] dt-bindings: arm: " Dragan Simic
2024-04-18 15:37 ` Conor Dooley
2024-04-18 15:46 ` Dragan Simic [this message]
2024-04-18 15:57 ` Conor Dooley
2024-04-18 15:58 ` Dragan Simic
2024-04-18 16:34 ` Dragan Simic
2024-04-18 15:36 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fec3e2f4e16b1aca6cd08e1882bd885@manjaro.org \
--to=dsimic@manjaro.org \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox