Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A

From: Dragan Simic <dsimic@manjaro.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A
Date: Thu, 18 Apr 2024 18:34:45 +0200	[thread overview]
Message-ID: <896b9fa5a87c5724e1f5b8b517227589@manjaro.org> (raw)
In-Reply-To: <d00953aab0f1c978e3720885a6844caa@manjaro.org>

Hello Chukun,

On 2024-04-18 17:21, Dragan Simic wrote:
> On 2024-04-18 15:01, Chukun Pan wrote:
>> According to https://radxa.com/products/rock3/3a,
>> the name of this board should be "Radxa ROCK 3A".
>> Also update compatible to match the model name.
>> 
>> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> 
> Looking good to me.  I'll send the remaining naming cleanup patches
> a bit later.

Please note that I didn't touch the ROCK 3 board(s)
in my patches. [1][2]

[1] 
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
[2] 
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/

>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 99bd5e2c76a0..88e9e0011953 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -772,9 +772,9 @@ properties:
>>            - const: radxa,rock2-square
>>            - const: rockchip,rk3288
>> 
>> -      - description: Radxa ROCK3 Model A
>> +      - description: Radxa ROCK 3A
>>          items:
>> -          - const: radxa,rock3a
>> +          - const: radxa,rock-3a
>>            - const: rockchip,rk3568
>> 
>>        - description: Radxa ROCK 5 Model A
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip