From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Elson Serrao <elson.serrao@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Peter Chen <peter.chen@kernel.org>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 8/9] arm64: dts: qcom: kodiak: Describe EUD UTMI path using child node
Date: Tue, 25 Aug 2026 12:45:25 +0200 [thread overview]
Message-ID: <3c643da8-b817-49a6-ba86-ced9f9e99579@oss.qualcomm.com> (raw)
In-Reply-To: <9a556733-79db-4f69-a149-b678c23cab7d@oss.qualcomm.com>
On 8/25/26 5:28 AM, Elson Serrao wrote:
>
>
> On 8/24/2026 6:48 AM, Konrad Dybcio wrote:
>> On 8/11/26 11:36 PM, Elson Serrao wrote:
>>> The existing EUD description uses a legacy single-path representation
>>> that assumes uniform UTMI routing. This was sufficient for minimal
>>> configurations where the USB port operated only in device mode and role
>>> switching was not considered.
>>
>> [...]
>>
>>> + ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + eud_usb: endpoint {
>>> + remote-endpoint = <&usb_1_dwc3_hs>;
>>
>> This change alone will trip "connection is not bi-directional" warnings,
>> as board DTs override that endpoint already
>>
> Patch 8 on its own would indeed trigger the "connection is not
> bi-directional" warnings. Patch 9 updates the corresponding
> board-level endpoint overrides and resolves those warnings.
>
> Would you prefer that I squash patch 9 into patch 8 so that the
> graph remains valid within a single patch?
This is a pre-requisite - each patch must build and function on its
own, as during a git bisect we may land on it
> Alternatively, we could
> move the endpoint assignment into the board DTS. However, since the
> EUD-to-controller mapping is on-SoC rather than board-specific, keeping
> it in the SoC DTSI appears to be the more appropriate placement.
Yes, that's desirable, it's just that the changes must be made in lockstep
Konrad
next prev parent reply other threads:[~2026-08-25 10:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 21:36 [PATCH v6 0/9] Improve Qualcomm EUD driver and platform support Elson Serrao
2026-08-11 21:36 ` [PATCH v6 1/9] dt-bindings: soc: qcom: eud: Add per-path child nodes for UTMI routing Elson Serrao
2026-08-11 21:50 ` sashiko-bot
2026-08-11 21:36 ` [PATCH v6 2/9] usb: misc: qcom_eud: add sysfs attribute for port selection Elson Serrao
2026-08-11 21:54 ` sashiko-bot
2026-08-11 21:36 ` [PATCH v6 3/9] usb: misc: qcom_eud: add per-path High-Speed PHY control Elson Serrao
2026-08-11 21:56 ` sashiko-bot
2026-08-24 9:14 ` Konrad Dybcio
2026-08-11 21:36 ` [PATCH v6 4/9] usb: misc: qcom_eud: add per-path role switch support Elson Serrao
2026-08-11 21:57 ` sashiko-bot
2026-08-24 13:44 ` Konrad Dybcio
2026-08-25 3:15 ` Elson Serrao
2026-08-11 21:36 ` [PATCH v6 5/9] usb: misc: qcom_eud: improve enable_store API Elson Serrao
2026-08-11 21:56 ` sashiko-bot
2026-08-11 21:36 ` [PATCH v6 6/9] usb: misc: qcom_eud: add role-based EUD control Elson Serrao
2026-08-11 21:54 ` sashiko-bot
2026-08-24 13:46 ` Konrad Dybcio
2026-08-11 21:36 ` [PATCH v6 7/9] usb: misc: qcom_eud: fix virtual attach/detach event handling Elson Serrao
2026-08-11 22:00 ` sashiko-bot
2026-08-11 21:36 ` [PATCH v6 8/9] arm64: dts: qcom: kodiak: Describe EUD UTMI path using child node Elson Serrao
2026-08-11 22:05 ` sashiko-bot
2026-08-24 13:48 ` Konrad Dybcio
2026-08-25 3:28 ` Elson Serrao
2026-08-25 10:45 ` Konrad Dybcio [this message]
2026-08-11 21:36 ` [PATCH v6 9/9] arm64: dts: qcom: Map USB connector to EUD on Kodiak boards Elson Serrao
2026-08-11 22:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c643da8-b817-49a6-ba86-ced9f9e99579@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=elson.serrao@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox