* [PATCH 0/5] Add minimal Exynos8855 SoC support [not found] <CGME20260612161128epcas5p2fe6ebf4b1a7b3ad1794804768180cbdd@epcas5p2.samsung.com> @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-12 16:30 ` [PATCH 1/5] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar ` (4 more replies) 0 siblings, 5 replies; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar This series adds initial support for the Exynos8855 SoC and also initial SMDK board support. Exynos8855 has octa-core CPUs, a combination of Cortex-A720 and Cortex-A520, arranged in 3 clusters. And other peripheral for mobile application. This initial support consists of CPUs, pinctrl and related nodes needed for initial kernel boot. With these patches, kernel can boot using initramfs till file system mounts. More platform support will be added in near future, clock driver to go next. Known issue: uart driver probe fails because of clk being not available yet. Alim Akhtar (5): dt-binding: ARM: samsung: Add Samsung Exynos8855 dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible pinctrl: samsung: Add Exynos8855 pinctrl configuration arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk MAINTAINERS: Add entry for Samsung Exynos8855 SoC .../bindings/arm/samsung/samsung-boards.yaml | 6 + .../bindings/pinctrl/samsung,pinctrl.yaml | 1 + MAINTAINERS | 7 + arch/arm64/boot/dts/exynos/Makefile | 1 + .../boot/dts/exynos/exynos8855-pinctrl.dtsi | 581 ++++++++++++++++++ .../arm64/boot/dts/exynos/exynos8855-smdk.dts | 37 ++ arch/arm64/boot/dts/exynos/exynos8855.dtsi | 214 +++++++ .../pinctrl/samsung/pinctrl-exynos-arm64.c | 124 ++++ drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + 10 files changed, 974 insertions(+) create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi base-commit: b99ae45861eccff1e1d8c7b05a13650be805d437 -- 2.34.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/5] dt-binding: ARM: samsung: Add Samsung Exynos8855 2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-12 16:30 ` [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar ` (3 subsequent siblings) 4 siblings, 0 replies; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar Add Samsung Exynos8855 smdk board to documentation Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml index 753b3ba1b607..273464400477 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml @@ -235,6 +235,12 @@ properties: - winlink,e850-96 # WinLink E850-96 - const: samsung,exynos850 + - description: Exynos8855 based boards + items: + - enum: + - samsung,exynos8855-smdk # Samsung SMDK + - const: samsung,exynos8855 + - description: Exynos8895 based boards items: - enum: -- 2.34.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible 2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar 2026-06-12 16:30 ` [PATCH 1/5] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-12 16:21 ` sashiko-bot 2026-06-12 16:30 ` [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar ` (2 subsequent siblings) 4 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar Document pin controller support on Exynos8855 SoC. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml index 7b006009ca0e..c4773701c92e 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml @@ -53,6 +53,7 @@ properties: - samsung,exynos7870-pinctrl - samsung,exynos7885-pinctrl - samsung,exynos850-pinctrl + - samsung,exynos8855-pinctrl - samsung,exynos8890-pinctrl - samsung,exynos8895-pinctrl - samsung,exynos9610-pinctrl -- 2.34.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible 2026-06-12 16:30 ` [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar @ 2026-06-12 16:21 ` sashiko-bot 0 siblings, 0 replies; 15+ messages in thread From: sashiko-bot @ 2026-06-12 16:21 UTC (permalink / raw) To: Alim Akhtar; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Missing SoC-specific compatible string for Exynos8855 wake-up interrupt controller. -- commit 87a449ad3230af2abf934581a9ca7d771b0d6dd7 Author: Alim Akhtar <alim.akhtar@samsung.com> dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible This commit documents pin controller support for the Exynos8855 SoC. It adds the samsung,exynos8855-pinctrl compatible string to the allowed properties list in the samsung,pinctrl.yaml schema. > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml > index 7b006009ca0e7..c4773701c92e3 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml > @@ -53,6 +53,7 @@ properties: > - samsung,exynos7870-pinctrl > - samsung,exynos7885-pinctrl > - samsung,exynos850-pinctrl > + - samsung,exynos8855-pinctrl [Severity: Low] Should this patch also define a corresponding SoC-specific compatible string for the child wake-up interrupt controller (samsung,exynos8855-wakeup-eint) under properties:compatible:oneOf:items:enum in the following file: Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml? Standard device tree guidelines require an SoC-specific compatible string for all hardware blocks to accommodate potential future quirks, rather than relying exclusively on a fallback like samsung,exynos850-wakeup-eint. > - samsung,exynos8890-pinctrl > - samsung,exynos8895-pinctrl > - samsung,exynos9610-pinctrl -- Sashiko AI review · https://sashiko.dev/#/patchset/20260612163020.411761-1-alim.akhtar@samsung.com?part=2 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration 2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar 2026-06-12 16:30 ` [PATCH 1/5] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar 2026-06-12 16:30 ` [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-12 16:27 ` sashiko-bot 2026-06-12 16:30 ` [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar 2026-06-12 16:30 ` [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar 4 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar Add pinctrl configuration for Exynos8855. The bank type macros are reused from Exynos850 SoC. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- .../pinctrl/samsung/pinctrl-exynos-arm64.c | 124 ++++++++++++++++++ drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + 3 files changed, 127 insertions(+) diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c index fe9f92cb037e..ba2a11f8e19d 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c @@ -943,6 +943,130 @@ const struct samsung_pinctrl_of_match_data exynos850_of_data __initconst = { .num_ctrl = ARRAY_SIZE(exynos850_pin_ctrl), }; +/* pin banks of exynos8855 pin-controller 0 (ALIVE) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks0[] __initconst = { + /* Must start with EINTG banks, ordered by EINT group number. */ + EXYNOS850_PIN_BANK_EINTW(8, 0x000, "gpa0", 0x00), + EXYNOS850_PIN_BANK_EINTW(4, 0x020, "gpa1", 0x04), + EXYNOS850_PIN_BANK_EINTN(3, 0x040, "gpq0"), + EXYNOS850_PIN_BANK_EINTN(2, 0x060, "gpq1"), + EXYNOS850_PIN_BANK_EINTW(1, 0x080, "gpc0", 0x10), + EXYNOS850_PIN_BANK_EINTW(1, 0x0a0, "gpc1", 0x14), + EXYNOS850_PIN_BANK_EINTW(1, 0x0c0, "gpc2", 0x18), + EXYNOS850_PIN_BANK_EINTW(1, 0x0e0, "gpc3", 0x1c), + EXYNOS850_PIN_BANK_EINTW(1, 0x100, "gpc4", 0x20), + EXYNOS850_PIN_BANK_EINTW(1, 0x120, "gpc5", 0x24), + EXYNOS850_PIN_BANK_EINTW(1, 0x140, "gpc6", 0x28), + EXYNOS850_PIN_BANK_EINTW(1, 0x160, "gpc7", 0x2c), + EXYNOS850_PIN_BANK_EINTW(1, 0x180, "gpc8", 0x30), + EXYNOS850_PIN_BANK_EINTW(1, 0x1a0, "gpc9", 0x34), + EXYNOS850_PIN_BANK_EINTW(1, 0x1c0, "gpc10", 0x38), + EXYNOS850_PIN_BANK_EINTW(1, 0x1e0, "gpc11", 0x3c), + EXYNOS850_PIN_BANK_EINTW(1, 0x200, "gpc12", 0x40), + EXYNOS850_PIN_BANK_EINTW(1, 0x220, "gpc13", 0x44), + EXYNOS850_PIN_BANK_EINTW(1, 0x240, "gpc14", 0x48), + EXYNOS850_PIN_BANK_EINTW(1, 0x260, "gpj0", 0x4c), + EXYNOS850_PIN_BANK_EINTW(1, 0x280, "gpj1", 0x50), + EXYNOS850_PIN_BANK_EINTW(1, 0x2a0, "gpj2", 0x54), +}; + +/* pin banks of exynos8855 pin-controller 1 (CMGP) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks1[] __initconst = { + EXYNOS850_PIN_BANK_EINTW(1, 0x00, "gpm0", 0x00), + EXYNOS850_PIN_BANK_EINTW(1, 0x20, "gpm1", 0x04), + EXYNOS850_PIN_BANK_EINTW(1, 0x40, "gpm2", 0x08), + EXYNOS850_PIN_BANK_EINTW(1, 0x60, "gpm3", 0x0c), + EXYNOS850_PIN_BANK_EINTW(1, 0x80, "gpm4", 0x10), + EXYNOS850_PIN_BANK_EINTW(1, 0xa0, "gpm5", 0x14), + EXYNOS850_PIN_BANK_EINTW(1, 0xc0, "gpm6", 0x18), + EXYNOS850_PIN_BANK_EINTW(1, 0xe0, "gpm7", 0x1c), + EXYNOS850_PIN_BANK_EINTW(1, 0x100, "gpm8", 0x20), + EXYNOS850_PIN_BANK_EINTW(1, 0x120, "gpm9", 0x24), + EXYNOS850_PIN_BANK_EINTW(1, 0x140, "gpm10", 0x28), + EXYNOS850_PIN_BANK_EINTW(1, 0x160, "gpm11", 0x2c), + EXYNOS850_PIN_BANK_EINTW(1, 0x180, "gpm12", 0x30), + EXYNOS850_PIN_BANK_EINTW(1, 0x1a0, "gpm13", 0x34), + EXYNOS850_PIN_BANK_EINTW(1, 0x1c0, "gpm14", 0x38), + EXYNOS850_PIN_BANK_EINTW(1, 0x1e0, "gpm15", 0x3c), + EXYNOS850_PIN_BANK_EINTW(1, 0x200, "gpm16", 0x40), + EXYNOS850_PIN_BANK_EINTW(1, 0x220, "gpm17", 0x44), + EXYNOS850_PIN_BANK_EINTW(1, 0x240, "gpm18", 0x48), + EXYNOS850_PIN_BANK_EINTW(1, 0x260, "gpm19", 0x4c), + EXYNOS850_PIN_BANK_EINTW(1, 0x280, "gpm20", 0x50), + EXYNOS850_PIN_BANK_EINTW(1, 0x2a0, "gpm21", 0x54), +}; + + +/* pin banks of exynos8855 pin-controller 2 (HSI UFS) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks2[] __initconst = { + EXYNOS850_PIN_BANK_EINTG(2, 0x0, "gpf3", 0x00), +}; + +/* pin banks of exynos8855 pin-controller 3 (PERIC) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks3[] __initconst = { + EXYNOS850_PIN_BANK_EINTG(8, 0x0, "gpp0", 0x00), + EXYNOS850_PIN_BANK_EINTG(8, 0x20, "gpp1", 0x04), + EXYNOS850_PIN_BANK_EINTG(6, 0x40, "gpp2", 0x08), + EXYNOS850_PIN_BANK_EINTG(4, 0x60, "gpg0", 0x0c), + EXYNOS850_PIN_BANK_EINTG(3, 0x80, "gpg1", 0x10), + EXYNOS850_PIN_BANK_EINTG(6, 0xa0, "gpb0", 0x14), + EXYNOS850_PIN_BANK_EINTG(4, 0xc0, "gpb1", 0x18), +}; + +/* pin banks of exynos8855 pin-controller 4 (PERICMMC) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks4[] __initconst = { + EXYNOS850_PIN_BANK_EINTG(7, 0x0, "gpf2", 0x00), +}; + +/* pin banks of exynos8855 pin-controller 5 (USI) */ +static const struct samsung_pin_bank_data exynos8855_pin_banks5[] __initconst = { + EXYNOS850_PIN_BANK_EINTG(8, 0x00, "gpp3", 0x00), + EXYNOS850_PIN_BANK_EINTG(2, 0x20, "gpp4", 0x04), + EXYNOS850_PIN_BANK_EINTG(2, 0x40, "gpg2", 0x08), + EXYNOS850_PIN_BANK_EINTG(1, 0x60, "gpg3", 0x0c), +}; + +static const struct samsung_pin_ctrl exynos8855_pin_ctrl[] __initconst = { + { + /* pin-controller instance 0 ALIVE data */ + .pin_banks = exynos8855_pin_banks0, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks0), + .eint_wkup_init = exynos_eint_wkup_init, + .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 1 CMGP data */ + .pin_banks = exynos8855_pin_banks1, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks1), + .eint_wkup_init = exynos_eint_wkup_init, + .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 2 HSI UFS data */ + .pin_banks = exynos8855_pin_banks2, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks2), + .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 3 PERIC data */ + .pin_banks = exynos8855_pin_banks3, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks3), + .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 4 PERICMMC data */ + .pin_banks = exynos8855_pin_banks4, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks4), + .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 5 USI data */ + .pin_banks = exynos8855_pin_banks5, + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks5), + .eint_gpio_init = exynos_eint_gpio_init, + }, +}; + +const struct samsung_pinctrl_of_match_data exynos8855_of_data __initconst = { + .ctrl = exynos8855_pin_ctrl, + .num_ctrl = ARRAY_SIZE(exynos8855_pin_ctrl), +}; + /* pin banks of exynos990 pin-controller 0 (ALIVE) */ static struct samsung_pin_bank_data exynos990_pin_banks0[] = { /* Must start with EINTG banks, ordered by EINT group number. */ diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index 5ac6f6b02327..5ecc9ed4c44d 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -1500,6 +1500,8 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = { .data = &exynos7885_of_data }, { .compatible = "samsung,exynos850-pinctrl", .data = &exynos850_of_data }, + { .compatible = "samsung,exynos8855-pinctrl", + .data = &exynos8855_of_data }, { .compatible = "samsung,exynos8890-pinctrl", .data = &exynos8890_of_data }, { .compatible = "samsung,exynos8895-pinctrl", diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.h b/drivers/pinctrl/samsung/pinctrl-samsung.h index 937600430a6e..bb02fb49b2af 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.h +++ b/drivers/pinctrl/samsung/pinctrl-samsung.h @@ -396,6 +396,7 @@ extern const struct samsung_pinctrl_of_match_data exynos7_of_data; extern const struct samsung_pinctrl_of_match_data exynos7870_of_data; extern const struct samsung_pinctrl_of_match_data exynos7885_of_data; extern const struct samsung_pinctrl_of_match_data exynos850_of_data; +extern const struct samsung_pinctrl_of_match_data exynos8855_of_data; extern const struct samsung_pinctrl_of_match_data exynos8890_of_data; extern const struct samsung_pinctrl_of_match_data exynos8895_of_data; extern const struct samsung_pinctrl_of_match_data exynos9610_of_data; -- 2.34.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration 2026-06-12 16:30 ` [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar @ 2026-06-12 16:27 ` sashiko-bot 0 siblings, 0 replies; 15+ messages in thread From: sashiko-bot @ 2026-06-12 16:27 UTC (permalink / raw) To: Alim Akhtar; +Cc: conor+dt, devicetree, robh Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: New issues: - [Medium] Assigning `.eint_gpio_init = exynos_eint_gpio_init` for the ALIVE and CMGP pin controllers is incorrect and will trigger an unconditional `dev_err` on boot. Pre-existing issues: - [High] Out-of-bounds shift and integer truncation in `exynos_wkup_irq_set_wake` due to sparse `eint_offset` values in Exynos8855 pin banks. -- commit 44d88e7478f7688359e44e48fa60a820ac3e8dfa Author: Alim Akhtar <alim.akhtar@samsung.com> pinctrl: samsung: Add Exynos8855 pinctrl configuration Add pinctrl configuration for Exynos8855. The bank type macros are reused from Exynos850 SoC. > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > index fe9f92cb037ea..ba2a11f8e19d8 100644 > --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c > +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c [ ... ] > +/* pin banks of exynos8855 pin-controller 1 (CMGP) */ > +static const struct samsung_pin_bank_data exynos8855_pin_banks1[] __initconst = { > + EXYNOS850_PIN_BANK_EINTW(1, 0x00, "gpm0", 0x00), [ ... ] > + EXYNOS850_PIN_BANK_EINTW(1, 0x280, "gpm20", 0x50), > + EXYNOS850_PIN_BANK_EINTW(1, 0x2a0, "gpm21", 0x54), > +}; [Severity: High] This is a pre-existing issue, but does the configuration of these eint_offset values (up to 0x54) expose an out-of-bounds shift issue? Looking at exynos_wkup_irq_set_wake() in drivers/pinctrl/samsung/pinctrl-exynos.c, it sets wake mask bits using: unsigned long bit = 1UL << (2 * bank->eint_offset + irqd->hwirq); If eint_offset is 0x54, the shift amount becomes 168, which invokes C undefined behavior. Even for shifts between 32 and 63, the 64-bit value is bitwise OR'd into a u32, dropping the upper bits and breaking the hardware wakeup masks for these pins. Will this logic need updating to support these sparse CMGP banks? [ ... ] > +static const struct samsung_pin_ctrl exynos8855_pin_ctrl[] __initconst = { > + { > + /* pin-controller instance 0 ALIVE data */ > + .pin_banks = exynos8855_pin_banks0, > + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks0), > + .eint_wkup_init = exynos_eint_wkup_init, > + .eint_gpio_init = exynos_eint_gpio_init, > + }, { > + /* pin-controller instance 1 CMGP data */ > + .pin_banks = exynos8855_pin_banks1, > + .nr_banks = ARRAY_SIZE(exynos8855_pin_banks1), > + .eint_wkup_init = exynos_eint_wkup_init, > + .eint_gpio_init = exynos_eint_gpio_init, > + }, { [Severity: Medium] Is it correct to assign exynos_eint_gpio_init to the eint_gpio_init callback for the ALIVE and CMGP controllers? Because these controllers only contain EINT_TYPE_WKUP and EINT_TYPE_NONE banks, they do not support standard GPIO interrupts and typically lack an interrupts property in the device tree. When exynos_eint_gpio_init runs and sees no irq, won't it unconditionally log an error during boot: dev_err(dev, "irq number not available\n"); and return -EINVAL? Does this initialization need to be omitted here, similar to how it is handled in exynos850_pin_ctrl? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260612163020.411761-1-alim.akhtar@samsung.com?part=3 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk 2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar ` (2 preceding siblings ...) 2026-06-12 16:30 ` [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-12 16:23 ` sashiko-bot 2026-06-12 16:30 ` [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar 4 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar Add initial devicetree support for Samsung smdk board using Exynos8855 SoC. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm64/boot/dts/exynos/Makefile | 1 + .../boot/dts/exynos/exynos8855-pinctrl.dtsi | 581 ++++++++++++++++++ .../arm64/boot/dts/exynos/exynos8855-smdk.dts | 37 ++ arch/arm64/boot/dts/exynos/exynos8855.dtsi | 214 +++++++ 4 files changed, 833 insertions(+) create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi create mode 100644 arch/arm64/boot/dts/exynos/exynos8855-smdk.dts create mode 100644 arch/arm64/boot/dts/exynos/exynos8855.dtsi diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile index 76cc23acb9b2..8c48ce2e02e5 100644 --- a/arch/arm64/boot/dts/exynos/Makefile +++ b/arch/arm64/boot/dts/exynos/Makefile @@ -14,6 +14,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ exynos7870-on7xelte.dtb \ exynos7885-jackpotlte.dtb \ exynos850-e850-96.dtb \ + exynos8855-smdk.dtb \ exynos8895-dreamlte.dtb \ exynos9810-starlte.dtb \ exynos990-c1s.dtb \ diff --git a/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi new file mode 100644 index 000000000000..f5d30fd299b6 --- /dev/null +++ b/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi @@ -0,0 +1,581 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Samsung's S5E8855 SoC pin-mux and pin-config device tree source + * + * Copyright (c) 2023 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Samsung's S5E8855 SoC pin-mux and pin-config options are listed as device + * tree nodes are listed in this file. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include "exynos-pinctrl.h" + +&pinctrl_alive { + gpa0: gpa0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpa1: gpa1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpq0: gpq0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + }; + + gpq1: gpq1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + }; + + gpc0: gpc0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc1: gpc1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc2: gpc2-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc3: gpc3-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc4: gpc4-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc5: gpc5-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc6: gpc6-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc7: gpc7-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc8: gpc8-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc9: gpc9-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc10: gpc10-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc11: gpc11-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc12: gpc12-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc13: gpc13-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpc14: gpc14-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpj0: gpj0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpj1: gpj1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpj2: gpj2-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + uart0_bus: uart0-bus { + samsung,pins = "gpq0-0", "gpq0-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + }; + +}; + +&pinctrl_cmgp { + gpm0: gpm0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm1: gpm1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm2: gpm2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm3: gpm3 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm4: gpm4 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm5: gpm5 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm6: gpm6 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm7: gpm7 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm8: gpm8 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm9: gpm9 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm10: gpm10 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm11: gpm11 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm12: gpm12 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm13: gpm13 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 127 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm14: gpm14 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 128 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm15: gpm15 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 129 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm16: gpm16 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm17: gpm17 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm18: gpm18 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm19: gpm19 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm20: gpm20 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + gpm21: gpm21 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH 0>; + }; +}; + +&pinctrl_hsi_ufs { + gpf3: gpf3-gpio-bank{ + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; +}; + +&pinctrl_peric { + gpp0: gpp0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpp1: gpp1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpp2: gpp2-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpg0: gpg0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpg1: gpg1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb0: gpb0-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb1: gpb1-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; +}; + +&pinctrl_pericmmc { + gpf2: gpf2-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; +}; + +&pinctrl_usi { + gpp3: gpp3-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpp4: gpp4-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpg2: gpg2-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpg3: gpg3-gpio-bank { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; +}; diff --git a/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts new file mode 100644 index 000000000000..3ebe847c21cf --- /dev/null +++ b/arch/arm64/boot/dts/exynos/exynos8855-smdk.dts @@ -0,0 +1,37 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Samsung Exynos8855 SMDK board device tree source + * + * Copyright (C) 2026 Samsung Electronics Co., Ltd. + * + * Device tree source file for WinLink's E850-96 board which is based on + * Samsung Exynos8855 SoC. + */ + +/dts-v1/; + +#include "exynos8855.dtsi" + +/ { + model = "Samsung Exynos8855 SMDK board"; + compatible = "samsung,exynos8855-smdk","samsung,exynos8855"; + + aliases { + serial0 = &serial_0; + }; + + chosen { + stdout-path = &serial_0; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x0 0x80000000 0x80000000>; + }; + +}; + +&oscclk { + clock-frequency = <76800000>; +}; + diff --git a/arch/arm64/boot/dts/exynos/exynos8855.dtsi b/arch/arm64/boot/dts/exynos/exynos8855.dtsi new file mode 100644 index 000000000000..cffa40b6bb98 --- /dev/null +++ b/arch/arm64/boot/dts/exynos/exynos8855.dtsi @@ -0,0 +1,214 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Samsung Exynos8855 SoC device tree source + * + * Copyright (C) 2023 Samsung Electronics Co., Ltd. + * + * Samsung Exynos8855 SoC device nodes are listed in this file. + * Exynos8855 based board files can include this file and provide + * values for board specific bindings. + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> + +/ { + compatible = "samsung,exynos8855"; + #address-cells = <2>; + #size-cells = <1>; + + interrupt-parent = <&gic>; + + aliases { + pinctrl0 = &pinctrl_alive; + pinctrl1 = &pinctrl_cmgp; + pinctrl2 = &pinctrl_hsi_ufs; + pinctrl3 = &pinctrl_peric; + pinctrl4 = &pinctrl_pericmmc; + pinctrl5 = &pinctrl_usi; + }; + + oscclk: clock-oscclk { + compatible = "fixed-clock"; + clock-output-names = "oscclk"; + #clock-cells = <0>; + }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu-map { + cluster0 { + core0 { + cpu = <&cpu0>; + }; + core1 { + cpu = <&cpu1>; + }; + core2 { + cpu = <&cpu2>; + }; + core3 { + cpu = <&cpu3>; + }; + }; + + cluster1 { + core0 { + cpu = <&cpu4>; + }; + core1 { + cpu = <&cpu5>; + }; + core3 { + cpu = <&cpu6>; + }; + }; + + cluster2 { + core0 { + cpu = <&cpu7>; + }; + }; + }; + + cpu0: cpu@0 { + device_type = "cpu"; + compatible = "arm,cortex-a520"; + reg = <0x0>; + enable-method = "psci"; + }; + + cpu1: cpu@100 { + device_type = "cpu"; + compatible = "arm,cortex-a520"; + reg = <0x100>; + enable-method = "psci"; + }; + + cpu2: cpu@200 { + device_type = "cpu"; + compatible = "arm,cortex-a520"; + reg = <0x200>; + enable-method = "psci"; + }; + + cpu3: cpu@300 { + device_type = "cpu"; + compatible = "arm,cortex-a520"; + reg = <0x300>; + enable-method = "psci"; + }; + + cpu4: cpu@400 { + device_type = "cpu"; + compatible = "arm,cortex-a720"; + reg = <0x400>; + enable-method = "psci"; + }; + + cpu5: cpu@500 { + device_type = "cpu"; + compatible = "arm,cortex-a720"; + reg = <0x500>; + enable-method = "psci"; + }; + + cpu6: cpu@600 { + device_type = "cpu"; + compatible = "arm,cortex-a720"; + reg = <0x600>; + enable-method = "psci"; + }; + + cpu7: cpu@700 { + device_type = "cpu"; + compatible = "arm,cortex-a720"; + reg = <0x700>; + enable-method = "psci"; + }; + }; + + psci { + compatible = "arm,psci-1.0"; + method = "smc"; + }; + + soc: soc@0 { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x0 0x20000000>; + + gic: interrupt-controller@10200000 { + compatible = "arm,gic-v3"; + #interrupt-cells = <4>; + #address-cells = <0>; + #size-cells = <1>; + reg = <0x10200000 0x10000>, + <0x10240000 0x100000>; + interrupt-controller; + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>; + }; + + pinctrl_alive: pinctrl@11850000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x11850000 0x1000>; + + wakeup-interrupt-controller { + compatible = "samsung,exynos850-wakeup-eint", + "samsung,exynos7-wakeup-eint"; + }; + }; + + pinctrl_cmgp: pinctrl@12030000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x12030000 0x1000>; + + wakeup-interrupt-controller { + compatible = "samsung,exynos850-wakeup-eint", + "samsung,exynos7-wakeup-eint"; + }; + }; + + pinctrl_usi: pinctrl@15030000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x15030000 0x1000>; + }; + + pinctrl_peric: pinctrl@15440000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x15440000 0x1000>; + }; + + pinctrl_pericmmc: pinctrl@154f0000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x154f0000 0x1000>; + }; + + pinctrl_hsi_ufs: pinctrl@17040000 { + compatible = "samsung,exynos8855-pinctrl"; + reg = <0x17040000 0x1000>; + }; + + serial_0: serial@15500000 { + compatible = "samsung,exynos850-uart"; + reg = <0x15500000 0x100>; + interrupts = <GIC_SPI 403 IRQ_TYPE_LEVEL_HIGH 0>; + pinctrl-names = "default"; + pinctrl-0 = <&uart0_bus>; + }; + }; + + timer { + compatible = "arm,armv8-timer"; + /* Hypervisor Virtual Timer interrupt is not wired to GIC */ + interrupts = + <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>; + }; +}; + +#include "exynos8855-pinctrl.dtsi" -- 2.34.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk 2026-06-12 16:30 ` [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar @ 2026-06-12 16:23 ` sashiko-bot 2026-06-15 5:36 ` Alim Akhtar 0 siblings, 1 reply; 15+ messages in thread From: sashiko-bot @ 2026-06-12 16:23 UTC (permalink / raw) To: Alim Akhtar; +Cc: robh, conor+dt, devicetree Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider: - [High] Missing Required Property in UART node `serial_0` - [Medium] Device Tree Topology Error: `cluster1` skips `core2` - [Low] Device Tree Binding Violation in `timer` node interrupts - [Low] DT Binding Violation: Missing `-gpio-bank` suffix on GPIO bank nodes - [Low] Device Tree Syntax Error: `gic` node defines `#size-cells = <1>` without `#address-cells = <1>` -- commit fb7d1034f06462e074dc2aa5a08df68787706d6c Author: Alim Akhtar <alim.akhtar@samsung.com> arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Add initial devicetree support for Samsung smdk board using Exynos8855 SoC. > diff --git a/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi > new file mode 100644 > index 0000000000000..f5d30fd299b62 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos8855-pinctrl.dtsi > @@ -0,0 +1,581 @@ [ ... ] > +&pinctrl_alive { > + gpa0: gpa0 { > + gpio-controller; > + #gpio-cells = <2>; [Severity: Low] Does this missing suffix violate the Exynos pinctrl dt-binding schema? Nodes such as gpa0 and gpm0 appear to be missing the required -gpio-bank suffix, which the schema expects to match the pattern: ^[a-z0-9-]+-gpio-bank$ Without this suffix, the nodes will fail DT schema validation, even though the Linux pinctrl driver will still parse them by iterating over child nodes. > + > + interrupt-controller; > + #interrupt-cells = <2>; [ ... ] > diff --git a/arch/arm64/boot/dts/exynos/exynos8855.dtsi b/arch/arm64/boot/dts/exynos/exynos8855.dtsi > new file mode 100644 > index 0000000000000..cffa40b6bb986 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos8855.dtsi > @@ -0,0 +1,214 @@ [ ... ] > + cluster1 { > + core0 { > + cpu = <&cpu4>; > + }; > + core1 { > + cpu = <&cpu5>; > + }; > + core3 { > + cpu = <&cpu6>; > + }; [Severity: Medium] Is it intentional to skip core2 in the cpu-map topology array? The cluster1 node defines core0, core1, and core3, completely skipping core2. Device tree topology indices are generally expected to be contiguous. Skipping core2 might misrepresent the actual hardware topology and confuse kernel topology parsers or the task scheduler. > + }; > + > + cluster2 { [ ... ] > + gic: interrupt-controller@10200000 { > + compatible = "arm,gic-v3"; > + #interrupt-cells = <4>; > + #address-cells = <0>; > + #size-cells = <1>; [Severity: Low] Is this #size-cells assignment a device tree syntax error? The gic node explicitly specifies #address-cells = <0>, but sets #size-cells = <1>. In Device Tree syntax, if #address-cells is 0, the node's children cannot have sizes, so #size-cells must also be 0 or omitted. This mismatch will trigger the avoid_unnecessary_addr_size dtc compiler warning. > + reg = <0x10200000 0x10000>, > + <0x10240000 0x100000>; [ ... ] > + serial_0: serial@15500000 { > + compatible = "samsung,exynos850-uart"; > + reg = <0x15500000 0x100>; > + interrupts = <GIC_SPI 403 IRQ_TYPE_LEVEL_HIGH 0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_bus>; > + }; [Severity: High] Does this node need clocks and clock-names properties? The samsung_tty driver unconditionally requests the uart clock during its probe() function via devm_clk_get(). Without these properties, the driver's probe will fail with -ENOENT and abort. Since serial_0 is set as the stdout-path in the board DTS, this failure would result in a non-functional serial console. > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + /* Hypervisor Virtual Timer interrupt is not wired to GIC */ > + interrupts = > + <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, [Severity: Low] Are these interrupt definitions violating the GICv3 device tree bindings? The timer node defines its GICv3 PPI interrupts using the GIC_CPU_MASK_SIMPLE(8) macro and IRQ_TYPE_LEVEL_LOW. Under GICv3 device tree bindings, the 3rd cell must only encode trigger type and level flags; embedding CPU affinity masks violates the schema. Additionally, GIC device tree bindings standardly expect IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING. This will trigger dtbs_check validation warnings, though the Linux GICv3 driver safely masks out the unsupported bits at runtime. > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>, > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW) 0>; > + }; > +}; -- Sashiko AI review · https://sashiko.dev/#/patchset/20260612163020.411761-1-alim.akhtar@samsung.com?part=4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk 2026-06-12 16:23 ` sashiko-bot @ 2026-06-15 5:36 ` Alim Akhtar 0 siblings, 0 replies; 15+ messages in thread From: Alim Akhtar @ 2026-06-15 5:36 UTC (permalink / raw) To: sashiko-reviews; +Cc: robh, conor+dt, devicetree > -----Original Message----- > From: sashiko-bot@kernel.org <sashiko-bot@kernel.org> > Sent: Friday, June 12, 2026 9:54 PM > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: robh@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org > Subject: Re: [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung > Exynos8855 smdk > > Thank you for your contribution! Sashiko AI review found 5 potential issue(s) > to consider: > - [High] Missing Required Property in UART node `serial_0` > - [Medium] Device Tree Topology Error: `cluster1` skips `core2` > - [Low] Device Tree Binding Violation in `timer` node interrupts > - [Low] DT Binding Violation: Missing `-gpio-bank` suffix on GPIO bank nodes > - [Low] Device Tree Syntax Error: `gic` node defines `#size-cells = <1>` > without `#address-cells = <1>` > -- Thanks, Will fix these in next version > Sashiko AI review · https://protect2.fireeye.com/v1/url?k=f6873d03- > 970c2830-f686b64c-000babff9bb7-7861d1909a20c345&q=1&e=c55a9d49- > 67b5-4ef3-896c- > 48615db6c678&u=https%3A%2F%2Fsashiko.dev%2F%23%2Fpatchset%2F202 > 60612163020.411761-1-alim.akhtar%40samsung.com%3Fpart%3D4 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar ` (3 preceding siblings ...) 2026-06-12 16:30 ` [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar @ 2026-06-12 16:30 ` Alim Akhtar 2026-06-15 7:21 ` Linus Walleij 4 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2026-06-12 16:30 UTC (permalink / raw) To: krzk, peter.griffin, robh, conor+dt, linusw Cc: linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung, Alim Akhtar Add maintainers entry for the Samsung Exynos8855 SoC based platforms Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 49a10f0ceb07..fb9b24220258 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -23914,6 +23914,13 @@ F: arch/arm64/boot/dts/exynos/exynos850* F: drivers/clk/samsung/clk-exynos850.c F: include/dt-bindings/clock/exynos850.h +SAMSUNG EXYNOS8855 SoC SUPPORT +M: Alim Akhtar <alim.akhtar@samsung.com> +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +L: linux-samsung-soc@vger.kernel.org +S: Maintained +F: arch/arm64/boot/dts/exynos/exynos8855* + SAMSUNG EXYNOS ACPM MAILBOX PROTOCOL M: Tudor Ambarus <tudor.ambarus@linaro.org> L: linux-kernel@vger.kernel.org -- 2.34.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-12 16:30 ` [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar @ 2026-06-15 7:21 ` Linus Walleij 2026-06-15 8:04 ` Alim Akhtar 0 siblings, 1 reply; 15+ messages in thread From: Linus Walleij @ 2026-06-15 7:21 UTC (permalink / raw) To: Alim Akhtar Cc: krzk, peter.griffin, robh, conor+dt, linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung Hi Alim, On Fri, Jun 12, 2026 at 6:11 PM Alim Akhtar <alim.akhtar@samsung.com> wrote: > Add maintainers entry for the Samsung Exynos8855 SoC based platforms > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> (...) > +SAMSUNG EXYNOS8855 SoC SUPPORT > +M: Alim Akhtar <alim.akhtar@samsung.com> > +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > +L: linux-samsung-soc@vger.kernel.org > +S: Maintained > +F: arch/arm64/boot/dts/exynos/exynos8855* If you really want to single out a single platform like this (and I don't even know if that is a good idea... how do you keep the big picture in mind?) you should probably want to also add a wildcard for all the 8855 device tree files. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-15 7:21 ` Linus Walleij @ 2026-06-15 8:04 ` Alim Akhtar 2026-06-15 8:12 ` Krzysztof Kozlowski 0 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2026-06-15 8:04 UTC (permalink / raw) To: 'Linus Walleij' Cc: krzk, peter.griffin, robh, conor+dt, linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung Thanks Linus for your review > -----Original Message----- > From: Linus Walleij <linusw@kernel.org> > Sent: Monday, June 15, 2026 12:51 PM > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: krzk@kernel.org; peter.griffin@linaro.org; robh@kernel.org; > conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; linux- > gpio@vger.kernel.org; hajun.sung@samsung.com > Subject: Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 > SoC > > Hi Alim, > > On Fri, Jun 12, 2026 at 6:11 PM Alim Akhtar <alim.akhtar@samsung.com> > wrote: > > > Add maintainers entry for the Samsung Exynos8855 SoC based platforms > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > (...) > > +SAMSUNG EXYNOS8855 SoC SUPPORT > > +M: Alim Akhtar <alim.akhtar@samsung.com> > > +L: linux-arm-kernel@lists.infradead.org (moderated for non- > subscribers) > > +L: linux-samsung-soc@vger.kernel.org > > +S: Maintained > > +F: arch/arm64/boot/dts/exynos/exynos8855* > > If you really want to single out a single platform like this (and I don't even > know if that is a good idea... how do you keep the big picture in mind?) you > should probably want to also add a wildcard for all the > 8855 device tree files. > I am also not sure, just followed what was done historically, other Exynos8855 file will get added once they are posted for review, e.g. clock driver. Let me discuss with Krzk during OSS (Mumbai) and see how do we handle this or any other better ways. > Yours, > Linus Walleij ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-15 8:04 ` Alim Akhtar @ 2026-06-15 8:12 ` Krzysztof Kozlowski 2026-06-15 8:16 ` Krzysztof Kozlowski 0 siblings, 1 reply; 15+ messages in thread From: Krzysztof Kozlowski @ 2026-06-15 8:12 UTC (permalink / raw) To: Alim Akhtar, 'Linus Walleij' Cc: peter.griffin, robh, conor+dt, linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung On 15/06/2026 10:04, Alim Akhtar wrote: > Thanks Linus for your review > >> -----Original Message----- >> From: Linus Walleij <linusw@kernel.org> >> Sent: Monday, June 15, 2026 12:51 PM >> To: Alim Akhtar <alim.akhtar@samsung.com> >> Cc: krzk@kernel.org; peter.griffin@linaro.org; robh@kernel.org; >> conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux- >> gpio@vger.kernel.org; hajun.sung@samsung.com >> Subject: Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 >> SoC >> >> Hi Alim, >> >> On Fri, Jun 12, 2026 at 6:11 PM Alim Akhtar <alim.akhtar@samsung.com> >> wrote: >> >>> Add maintainers entry for the Samsung Exynos8855 SoC based platforms >>> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> (...) >>> +SAMSUNG EXYNOS8855 SoC SUPPORT >>> +M: Alim Akhtar <alim.akhtar@samsung.com> >>> +L: linux-arm-kernel@lists.infradead.org (moderated for non- >> subscribers) >>> +L: linux-samsung-soc@vger.kernel.org >>> +S: Maintained >>> +F: arch/arm64/boot/dts/exynos/exynos8855* >> >> If you really want to single out a single platform like this (and I don't even >> know if that is a good idea... how do you keep the big picture in mind?) you >> should probably want to also add a wildcard for all the >> 8855 device tree files. >> > I am also not sure, just followed what was done historically, other Exynos8855 file will get added once they > are posted for review, e.g. clock driver. > Let me discuss with Krzk during OSS (Mumbai) and see how do we handle this or any other better ways. > You are Alim already reviewer for entire Samsung, so not sure if this is beneficial but I also do not mind. For Exynos850 and Google GS101, these were added because folks wanted to be involved in these specific bits. In the past I was voting for per-DTS file maintainer entry and rejecting per-board maintainer entries. There was even get_maintainers.pl patch doing that. Unfortunately after many tries that patch eventually did not land and I got bored bringing it up, thus I agreed to earlier NXP approach for per-board or per-SoC maintainers. I would like to encourage more people doing meaningful reviews, so if having maintainers entry helps that, then I am in. Therefore I am fine with this patch as is. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-15 8:12 ` Krzysztof Kozlowski @ 2026-06-15 8:16 ` Krzysztof Kozlowski 2026-06-15 8:37 ` Alim Akhtar 0 siblings, 1 reply; 15+ messages in thread From: Krzysztof Kozlowski @ 2026-06-15 8:16 UTC (permalink / raw) To: Alim Akhtar, 'Linus Walleij' Cc: peter.griffin, robh, conor+dt, linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung On 15/06/2026 10:12, Krzysztof Kozlowski wrote: > On 15/06/2026 10:04, Alim Akhtar wrote: >> Thanks Linus for your review >> >>> -----Original Message----- >>> From: Linus Walleij <linusw@kernel.org> >>> Sent: Monday, June 15, 2026 12:51 PM >>> To: Alim Akhtar <alim.akhtar@samsung.com> >>> Cc: krzk@kernel.org; peter.griffin@linaro.org; robh@kernel.org; >>> conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; linux- >>> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux- >>> gpio@vger.kernel.org; hajun.sung@samsung.com >>> Subject: Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 >>> SoC >>> >>> Hi Alim, >>> >>> On Fri, Jun 12, 2026 at 6:11 PM Alim Akhtar <alim.akhtar@samsung.com> >>> wrote: >>> >>>> Add maintainers entry for the Samsung Exynos8855 SoC based platforms >>>> >>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>> (...) >>>> +SAMSUNG EXYNOS8855 SoC SUPPORT >>>> +M: Alim Akhtar <alim.akhtar@samsung.com> >>>> +L: linux-arm-kernel@lists.infradead.org (moderated for non- >>> subscribers) >>>> +L: linux-samsung-soc@vger.kernel.org >>>> +S: Maintained >>>> +F: arch/arm64/boot/dts/exynos/exynos8855* >>> >>> If you really want to single out a single platform like this (and I don't even >>> know if that is a good idea... how do you keep the big picture in mind?) you >>> should probably want to also add a wildcard for all the >>> 8855 device tree files. >>> >> I am also not sure, just followed what was done historically, other Exynos8855 file will get added once they >> are posted for review, e.g. clock driver. >> Let me discuss with Krzk during OSS (Mumbai) and see how do we handle this or any other better ways. >> > > You are Alim already reviewer for entire Samsung, so not sure if this is > beneficial but I also do not mind. > > For Exynos850 and Google GS101, these were added because folks wanted to > be involved in these specific bits. In the past I was voting for per-DTS > file maintainer entry and rejecting per-board maintainer entries. There Lemme clarify: "voting for in-DTS file maintainer entry", so like we have for DT bindings, which lists maintainers. > was even get_maintainers.pl patch doing that. Unfortunately after many > tries that patch eventually did not land and I got bored bringing it up, > thus I agreed to earlier NXP approach for per-board or per-SoC maintainers. > > I would like to encourage more people doing meaningful reviews, so if > having maintainers entry helps that, then I am in. > > Therefore I am fine with this patch as is. > > Best regards, > Krzysztof Best regards, Krzysztof ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC 2026-06-15 8:16 ` Krzysztof Kozlowski @ 2026-06-15 8:37 ` Alim Akhtar 0 siblings, 0 replies; 15+ messages in thread From: Alim Akhtar @ 2026-06-15 8:37 UTC (permalink / raw) To: 'Krzysztof Kozlowski', 'Linus Walleij' Cc: peter.griffin, robh, conor+dt, linux-samsung-soc, linux-kernel, devicetree, linux-gpio, hajun.sung > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, June 15, 2026 1:47 PM > To: Alim Akhtar <alim.akhtar@samsung.com>; 'Linus Walleij' > <linusw@kernel.org> > Cc: peter.griffin@linaro.org; robh@kernel.org; conor+dt@kernel.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-gpio@vger.kernel.org; > hajun.sung@samsung.com > Subject: Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 > SoC > > On 15/06/2026 10:12, Krzysztof Kozlowski wrote: > > On 15/06/2026 10:04, Alim Akhtar wrote: > >> Thanks Linus for your review > >> > >>> -----Original Message----- > >>> From: Linus Walleij <linusw@kernel.org> > >>> Sent: Monday, June 15, 2026 12:51 PM > >>> To: Alim Akhtar <alim.akhtar@samsung.com> > >>> Cc: krzk@kernel.org; peter.griffin@linaro.org; robh@kernel.org; > >>> conor+dt@kernel.org; linux-samsung-soc@vger.kernel.org; linux- > >>> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux- > >>> gpio@vger.kernel.org; hajun.sung@samsung.com > >>> Subject: Re: [PATCH 5/5] MAINTAINERS: Add entry for Samsung > >>> Exynos8855 SoC > >>> > >>> Hi Alim, > >>> > >>> On Fri, Jun 12, 2026 at 6:11 PM Alim Akhtar > >>> <alim.akhtar@samsung.com> > >>> wrote: > >>> > >>>> Add maintainers entry for the Samsung Exynos8855 SoC based > >>>> platforms > >>>> > >>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > >>> (...) > >>>> +SAMSUNG EXYNOS8855 SoC SUPPORT > >>>> +M: Alim Akhtar <alim.akhtar@samsung.com> > >>>> +L: linux-arm-kernel@lists.infradead.org (moderated for non- > >>> subscribers) > >>>> +L: linux-samsung-soc@vger.kernel.org > >>>> +S: Maintained > >>>> +F: arch/arm64/boot/dts/exynos/exynos8855* > >>> > >>> If you really want to single out a single platform like this (and I > >>> don't even know if that is a good idea... how do you keep the big > >>> picture in mind?) you should probably want to also add a wildcard > >>> for all the > >>> 8855 device tree files. > >>> > >> I am also not sure, just followed what was done historically, other > >> Exynos8855 file will get added once they are posted for review, e.g. clock > driver. > >> Let me discuss with Krzk during OSS (Mumbai) and see how do we handle > this or any other better ways. > >> > > > > You are Alim already reviewer for entire Samsung, so not sure if this > > is beneficial but I also do not mind. > > > > For Exynos850 and Google GS101, these were added because folks wanted > > to be involved in these specific bits. In the past I was voting for > > per-DTS file maintainer entry and rejecting per-board maintainer > > entries. There > > Lemme clarify: "voting for in-DTS file maintainer entry", so like we have for > DT bindings, which lists maintainers. > Sounds interesting to me, lets see what community thinks about this. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2026-06-15 8:37 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20260612161128epcas5p2fe6ebf4b1a7b3ad1794804768180cbdd@epcas5p2.samsung.com>
2026-06-12 16:30 ` [PATCH 0/5] Add minimal Exynos8855 SoC support Alim Akhtar
2026-06-12 16:30 ` [PATCH 1/5] dt-binding: ARM: samsung: Add Samsung Exynos8855 Alim Akhtar
2026-06-12 16:30 ` [PATCH 2/5] dt-binding: pinctrl: samsung: Add exynos8855-pinctrl compatible Alim Akhtar
2026-06-12 16:21 ` sashiko-bot
2026-06-12 16:30 ` [PATCH 3/5] pinctrl: samsung: Add Exynos8855 pinctrl configuration Alim Akhtar
2026-06-12 16:27 ` sashiko-bot
2026-06-12 16:30 ` [PATCH 4/5] arm64: dts: exynos: add initial support for Samsung Exynos8855 smdk Alim Akhtar
2026-06-12 16:23 ` sashiko-bot
2026-06-15 5:36 ` Alim Akhtar
2026-06-12 16:30 ` [PATCH 5/5] MAINTAINERS: Add entry for Samsung Exynos8855 SoC Alim Akhtar
2026-06-15 7:21 ` Linus Walleij
2026-06-15 8:04 ` Alim Akhtar
2026-06-15 8:12 ` Krzysztof Kozlowski
2026-06-15 8:16 ` Krzysztof Kozlowski
2026-06-15 8:37 ` Alim Akhtar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox